|
My eyes are hurting! "Why so big?", he asks. Nice MS fonting, tho'. 
/ravi
|
|
|
|
|
clicks stopwatch
Mate. You're about 22hrs late. In our morning meeting I was just talking to Matthew and wondering where you were! 
cheers
Chris Maunder
|
|
|
|
|
What a reputation I have! 
/ravi
|
|
|
|
|
You can't keep anything nice.
|
|
|
|
|
"Walmart sells fake 30TB hard drive that’s actually two small SD cards in a trench coat"
OK, so no surprises there, but I just wanted to add:
🎶 "Gonna hide inside my trench coat and be clever" 🎶
I've always thought that's a great line and I knew I'd find a use for it one day, although my favourite song is probably Winter.
Paul Sanders.
If I had more time, I would have written a shorter letter - Blaise Pascal.
Some of my best work is in the undo buffer.
|
|
|
|
|
|
That's not the one I meant actually (reckon you know that), but I took a listen and I rather like it. I'm loving the Abba look they're sporting there.
Paul Sanders.
If I had more time, I would have written a shorter letter - Blaise Pascal.
Some of my best work is in the undo buffer.
|
|
|
|
|
Cut of meat gets Aslan gong? (9)
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
Medallion ?
shouldn't it be gong aslan ?
Life should not be a journey to the grave with the intention of arriving safely in a pretty and well-preserved body, but rather to skid in broadside in a cloud of smoke, thoroughly used up, totally worn out, and loudly proclaiming “Wow! What a Ride!" - Hunter S Thompson - RIP
|
|
|
|
|
I figured it would either go really quickly or last all day, but I liked it! 
Cut of meat
Aslan LION (From Narnia)
gong MEDAL
MEDALLION
I was hoping the two sets of nine letters would confuse: ASLAN GONG <==> SANG ALONG for example.
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
How does a gong equate to a medal?
Thanks!
|
|
|
|
|
Shape?
“Real stupidity beats artificial intelligence every time.”
― Terry Pratchett, Hogfather
|
|
|
|
|
|
why does gong mean medal - Google Search[^]
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
I looked over a jillion meanings of gong but found no connection to Medal. However, I did find that a lion gong is also known as a wind going or a feng. You don't even want to know how far down that rabbit hole I went! 
|
|
|
|
|
I'm headdesking this code I'm trying to port. It's just a godawful mess. I'm barely treading water, even as I understand about 70% of it more or less, it's really difficult to modify.
https://github.com/KurtE/ILI9341_t3n
specifically:
https://github.com/KurtE/ILI9341_t3n/blob/master/src/ILI9341_t3n.cpp
Kurt's a nice guy. I've corresponded with him, not about this code directly, but about my attempt at making similar code that works with htcw_gfx, my graphics library for IoT devices.
That said, I hate the way he coded this. I feel like design was either an afterthought, or he just added to it over and over without ever bothering to step back and refactor. I've done that too, so it's not really a judgment of his coding in general, but it *is* difficult to deal with in this case.
Now I need to though, because for starters his device reads are not const (if you know C++ then you should understand the ramifications of that) and they aren't easily made const because of the way it's implemented, so if I want to read pixels off the display device I can't do that, because htcw_gfx expects readable things to be able to const.
I can fix that by moving all the driver communication code to a static template class whose arguments include the DC and CS pins, so I have statics per SPI device, but it means open heart surgery on Kurt's code, and I'm kind of overwhelmed trying to piece this all together. This is already my second attempt.
I love building things, but sometimes the act itself stifles the creative part. Like, the inspiration for the creation vs the act of creation itself - sometimes they are at odds. Hebrew has words for each part of that creative process. I wish English did.
To err is human. Fortune favors the monsters.
modified 31-Aug-22 2:08am.
|
|
|
|
|
From a very quick scan the things that concern me with that code aren't whether reads are const or not. The number of "TODO", "BUG" and commented out lines imply that it hasn't been finished.
May be suitable for what you need but having a clean codebase you can trust is far more important than whether it is fully optimised for language semantics.
|
|
|
|
|
There's a bunch of that too. 
I'd love a clean codebase, but this code does black magic with the ARM Cortex M7 SPI registers, and I don't know enough about it to write it from scratch.
To err is human. Fortune favors the monsters.
|
|
|
|
|
You could take the time to reverse engineer it. Then again, I remember a comment in somewhat similar code at a previous job: "Abandon hope, all ye who look at this code. Not even its author understands how it works, or why."
|
|
|
|
|
Starting at page 913 or so.
Reading this nonsense is like reading sheet music to me - I can get it, if I squint, and I pray.
This is what I'd be reverse engineering to get at.
This is some of the code. It's all like this:
#elif defined(__IMXRT1052__) || defined(__IMXRT1062__) // Teensy 4.x
#define TCR_MASK \
(LPSPI_TCR_PCS(3) | LPSPI_TCR_FRAMESZ(31) | LPSPI_TCR_CONT | LPSPI_TCR_RXMSK)
void maybeUpdateTCR(
uint32_t requested_tcr_state) {
if ((_spi_tcr_current & TCR_MASK) != requested_tcr_state) {
bool dc_state_change = (_spi_tcr_current & LPSPI_TCR_PCS(3)) !=
(requested_tcr_state & LPSPI_TCR_PCS(3));
_spi_tcr_current = (_spi_tcr_current & ~TCR_MASK) | requested_tcr_state;
if (!dc_state_change || !_dcpinmask) {
while ((_pimxrt_spi->FSR & 0x1f))
;
_pimxrt_spi->TCR = _spi_tcr_current;
} else {
waitTransmitComplete();
if (requested_tcr_state & LPSPI_TCR_PCS(3))
DIRECT_WRITE_HIGH(_dcport, _dcpinmask);
else
DIRECT_WRITE_LOW(_dcport, _dcpinmask);
_pimxrt_spi->TCR = _spi_tcr_current &
~(LPSPI_TCR_PCS(3) |
LPSPI_TCR_CONT); }
}
}
void writecommand_cont(uint8_t c) __attribute__((always_inline)) {
maybeUpdateTCR(_tcr_dc_assert | LPSPI_TCR_FRAMESZ(7) );
_pimxrt_spi->TDR = c;
pending_rx_count++; waitFifoNotFull();
}
void writedata8_cont(uint8_t c) __attribute__((always_inline)) {
maybeUpdateTCR(_tcr_dc_not_assert | LPSPI_TCR_FRAMESZ(7) | LPSPI_TCR_CONT);
_pimxrt_spi->TDR = c;
pending_rx_count++; waitFifoNotFull();
}
void writedata16_cont(uint16_t d) __attribute__((always_inline)) {
maybeUpdateTCR(_tcr_dc_not_assert | LPSPI_TCR_FRAMESZ(15) | LPSPI_TCR_CONT);
_pimxrt_spi->TDR = d;
pending_rx_count++; waitFifoNotFull();
}
To err is human. Fortune favors the monsters.
|
|
|
|
|
I think of someone else's code as clay; to be reworked if necessary; incrementally. Reworking code also helps me understand it better; even if it's just changing local variable names. But just staring at it ... not so much. Be one with the code.
"Before entering on an understanding, I have meditated for a long time, and have foreseen what might happen. It is not genius which reveals to me suddenly, secretly, what I have to say or to do in a circumstance unexpected by other people; it is reflection, it is meditation." - Napoleon I
|
|
|
|
|
All I can say is you have not seen this code.
To err is human. Fortune favors the monsters.
|
|
|
|
|
Reformat file to tab/space/bracket system that your mind comprehends best.
Start with one variable. Figure out what it does. Universally rename it so you can understand it and not think about it again.
Repeat x 1 billion or so.
Continually perform incantations to the appropriate gods, including all the curse words you know, and make up some for good measure.
Swear some more.
Before you know it, success!!!
|
|
|
|
|
Let me show you what I'm working with.
Frankly the variable names don't bother me. There aren't many variables, and I understand most of the class members like _csport and _dcport at this point. My main issue is the behavior of the registers. I have the manual but it reads like bad stereo instructions
#elif defined(__IMXRT1052__) || defined(__IMXRT1062__) // Teensy 4.x
#define TCR_MASK \
(LPSPI_TCR_PCS(3) | LPSPI_TCR_FRAMESZ(31) | LPSPI_TCR_CONT | LPSPI_TCR_RXMSK)
void maybeUpdateTCR(
uint32_t requested_tcr_state) {
if ((_spi_tcr_current & TCR_MASK) != requested_tcr_state) {
bool dc_state_change = (_spi_tcr_current & LPSPI_TCR_PCS(3)) !=
(requested_tcr_state & LPSPI_TCR_PCS(3));
_spi_tcr_current = (_spi_tcr_current & ~TCR_MASK) | requested_tcr_state;
if (!dc_state_change || !_dcpinmask) {
while ((_pimxrt_spi->FSR & 0x1f))
;
_pimxrt_spi->TCR = _spi_tcr_current;
} else {
waitTransmitComplete();
if (requested_tcr_state & LPSPI_TCR_PCS(3))
DIRECT_WRITE_HIGH(_dcport, _dcpinmask);
else
DIRECT_WRITE_LOW(_dcport, _dcpinmask);
_pimxrt_spi->TCR = _spi_tcr_current &
~(LPSPI_TCR_PCS(3) |
LPSPI_TCR_CONT); }
}
}
void writecommand_cont(uint8_t c) __attribute__((always_inline)) {
maybeUpdateTCR(_tcr_dc_assert | LPSPI_TCR_FRAMESZ(7) );
_pimxrt_spi->TDR = c;
pending_rx_count++; waitFifoNotFull();
}
void writedata8_cont(uint8_t c) __attribute__((always_inline)) {
maybeUpdateTCR(_tcr_dc_not_assert | LPSPI_TCR_FRAMESZ(7) | LPSPI_TCR_CONT);
_pimxrt_spi->TDR = c;
pending_rx_count++; waitFifoNotFull();
}
void writedata16_cont(uint16_t d) __attribute__((always_inline)) {
maybeUpdateTCR(_tcr_dc_not_assert | LPSPI_TCR_FRAMESZ(15) | LPSPI_TCR_CONT);
_pimxrt_spi->TDR = d;
pending_rx_count++; waitFifoNotFull();
}
To err is human. Fortune favors the monsters.
|
|
|
|
|
honey the codewitch wrote: I can't rename the processor's SPI register constants.
The magic of C++ macros allows any possibility! Have fun swearing!
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
