|
What if we put those silly advertisements at the bottom of programming sites, and they linked to tips on good programming practices?
Reverse psychology to get the copy-pasters to pick up better habits. 
To err is human. Fortune favors the monsters.
|
|
|
|
|
You would still have to read it to them.
|
|
|
|
|
How many of you are into Advent-of-Code (or aware of it)? It is quite big in my office, and I assure you, not just among youngsters. The puzzles can be nifty, I wish I had the energy to take them on.
If this has been discussed here already, I am sorry.
"If we don't change direction, we'll end up where we're going"
|
|
|
|
|
Yes, I'm doing them.
It's just annoying that due to timezones it's not possible to compete on the leaderboard.
|
|
|
|
|
nain page is ascii gibberish almost black on black (Chrome)
«The mind is not a vessel to be filled but a fire to be kindled» Plutarch
|
|
|
|
|
I did it a couple of years ago.
"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles
|
|
|
|
|
I did 3 days last year before getting annoyed with them.
Hogan
|
|
|
|
|
But overcoming the annoyingness is the real challenge!
"If we don't change direction, we'll end up where we're going"
|
|
|
|
|
Very short dog junction (4)
Life should not be a journey to the grave with the intention of arriving safely in a pretty and well-preserved body, but rather to skid in broadside in a cloud of smoke, thoroughly used up, totally worn out, and loudly proclaiming “Wow! What a Ride!" - Hunter S Thompson - RIP
|
|
|
|
|
Nice and simple!
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
That's me 
Life should not be a journey to the grave with the intention of arriving safely in a pretty and well-preserved body, but rather to skid in broadside in a cloud of smoke, thoroughly used up, totally worn out, and loudly proclaiming “Wow! What a Ride!" - Hunter S Thompson - RIP
|
|
|
|
|
curt
cur - dog
t - junction
Treading on the toes of giants . . .
|
|
|
|
|
Thats the one YAUT 
Life should not be a journey to the grave with the intention of arriving safely in a pretty and well-preserved body, but rather to skid in broadside in a cloud of smoke, thoroughly used up, totally worn out, and loudly proclaiming “Wow! What a Ride!" - Hunter S Thompson - RIP
|
|
|
|
|
I reviewed only one line of code for one business rule. I did comprehensive testing and validation, and I think this code change meets the purpose.
what is the better statement to wrap up my approval? any good words to recommend?
diligent hands rule....
|
|
|
|
|
|
Southmountain wrote: I reviewed only one line of code for one business rule. I did comprehensive testing and validation, and I think this code change meets the purpose.
throw new NotImplementedException();
Yup, that definitely requires comprehensive testing and validation! 
|
|
|
|
|
abort();
an old favorite. works as advertised. no obvious flaws. 
To err is human. Fortune favors the monsters.
|
|
|
|
|
works
"A little time, a little trouble, your better day"
Badfinger
|
|
|
|
|
Southmountain wrote: I reviewed only one line of code for one business rule.
Delete this part. It completely invalidates your second sentence. If you worked for me, and I read this line in a code review, you'd be looking for work. A one line change usually has many unintended consequences, and a proper review requires a much more extensive analysis. No code change, nor any hardware change, lives in a vacuum; there are always other effects, and they can be very subtle. If you're willing to accept this review as your best work, stick with the second sentence, and be prepared to defend it.
Will Rogers never met me.
|
|
|
|
|
|
"Approved after review and testing".
|
|
|
|
|
I have no idea what system or process you use for your code reviews, but I don't write comments for approvals.
I will do 10-20 code reviews per week, sometimes more, sometimes less.
We use Azure DevOps Services | Microsoft Azure[^] and I usually only make comments if there are issues, but when I approve I just click the Approve button and that is it, no comments necessary.
|
|
|
|
|
my approval is written in an email to reply to developer's request. this email will be saved and embed into BRD document.
diligent hands rule....
|
|
|
|
|
your code review system uses email as its method of communication?
I don't want to know the answer. 
|
|
|
|
|
If there are no comments for the review, we just approve the PR.
CI/CD = Continuous Impediment/Continuous Despair
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
![Rose | [Rose]](https://codeproject.freetls.fastly.net/script/Forums/Images/rose.gif)