Managed C++/CLI

Rendering problems with DirectWrite

7-Nov-15 17:22

FYI - I have found and reported a bug with std::unique_ptr when used in code built with /clr in VS 2015.

Consider this code:

C++

void accept_ownership( std::unique_ptr<MyClass> ptr ) { ... }

void test() {
   std::unique_ptr<MyClass> mc = std::make_unique<MyClass>( args );

   accept_ownership( std::move(mc) );
}

When accept_ownership is called in C++/CLI code, mc will be destructed and accept_ownership receives a unique_ptr pointing to freed memory. There will be a double-free at exit as well.

I've reported the bug with send-a-frown and it is NOT fixed in the Update 1 RC. Let's hope it's fixed in Update 1 RTM.

The code works as expected when not built with /clr.

John

paul116713-Oct-15 23:25

13-Oct-15 23:25

As a warmup for a more complex project in C#, I have started to code a C++/CLI library to allow simple access of C# applications to features of DirectWrite. (I am aware that there are such helper libraries already out there but I was not able yet to get them to work with in Visual Studio 2015 and with Windows 10.)

So far so good. A first test run showed the text in the target window but not as I would have expected for ClearType display. A screenshot of the displayed text can be found here.

My understanding of the relating MSDN documentation is that ClearType is enabled by default. The title bar text of the window is obviously set up with text in ClearType. I guess I missed a setting in the DWrite factory but I do not know which.

Does anybody have an advice for me?

Richard MacCutchan13-Oct-15 23:48

13-Oct-15 23:48

It looks like your coordinates are being calculated incorrectly and you are not leaving enough space between lines of text.

paul116714-Oct-15 4:26

14-Oct-15 4:26

Thank you for your response. You had indeed a good idea but I am afraid that this is not likely the reason:

You can see from the screenshot, the character 'g' is shown completely where other characters like the adjacent are not shown completely.
The text has been sent to DX as one single block, without the explicit specification of leading. I would assume then that DX selects a sufficient leading.

Meanwhile, I have made several more tests with my application but I have not found a way yet to improve the text display. However, I do not give up. ClearType works well on my computer; any application - except mine - is using it successfully.

I have collected my little test in a ZIP file which can be loaded from this location. I am currently using Windows 10 and Visual Studio Community 2015.

Richard MacCutchan14-Oct-15 5:57

14-Oct-15 5:57

paul1167 wrote:
I am afraid that this is not likely the reason

Well I am no expert in DirectX, but that is certainly what it looks like. I would suggest you take a look at https://github.com/Microsoft/Windows-universal-samples/tree/master/Samples/DWriteLineSpacingModes[^] to see how Microsoft does it.

paul116715-Oct-15 20:05

15-Oct-15 20:05

I had downloaded that example yesterday - It's really HUGE! And - unfortunately - it fails to build. I am receiving error message "C:\Program Files (x86)\MSBuild\14.0\bin\Microsoft.Common.CurrentVersion.targets(2048,5): error MSB3774: Could not find SDK "Microsoft.VCLibs, Version=14.0".".

There are several comments about this issue in the net but only very few solution proposals. I tried one and ran the repair of my Visual Studio but the building problem remained.

I will now start to work myself through the code and try to find answers to my specific problem. That will take a while since I do not know if the problem is caused by any System or VS settings or just by my code.

Richard MacCutchan16-Oct-15 0:01

16-Oct-15 0:01

Some of the members here are quite selective about which forums they visit, and it's quite possible that the people who would maybe know the answer never come here. Your problem has nothing to do with C++/CLI but is about DirectX, so a question in the Graphics forum may catch someone's eye. You could also try a search of the Articles section to see if anyone has written about it.

paul116716-Oct-15 0:44

16-Oct-15 0:44

Hi Richard,
That is a real good point. You are right: DirectWrite is much more a matter of Graphics. The C++/CLI issues in my problem are secondary.
Thank you for this advice.

Richard MacCutchan14-Oct-15 8:15

14-Oct-15 8:15

I have had a look at your code (I am not able to build it). I wonder if you need to adjust your line spacing based on the actual size of the created font, rather than the requested size.

John Schroedl14-Oct-15 9:08

14-Oct-15 9:08

I built your project and played with it a bit but was not able to eliminate the issue. I consulted some of our DX code and things are very similar. We do create a DC render target instead of an HWND render target and set the flags to be GDI compatible but everything else looks similar. Our content is hosted within a WPF window so that's another difference.

Is this a high-DPI issue by chance? I run at 125% and didn't try your app at 100% (96 dpi). Perhaps some sizes need to be scaled differently.

I see that things stretch as the window is resized. So perhaps the drawing is extra compressed which causes the bitmap to be resampled?

Sorry I'm not much more help. I certainly feel your pain though.

John

paul116714-Oct-15 20:47

14-Oct-15 20:47

I have now tested with several different font sizes. Looks ok at 36pt. Real bad result at 12pt: Even the two lines of text (rendered as one single text block) seem to have different sizes, see screenshot. This is definitively not ClearType.
I guess now I missed somewhere to enable ClearType and will give a close look to the sample Richard MacCutchan indicated to me.

Stretching of the text block upon resizing of the window is an undesired effect caused by the very simple design of the test, should be done better in a 'real' application.

paul116714-Oct-15 21:05

14-Oct-15 21:05

I have also tried to switch from 100% to 125% -- same result (25% larger than in previous test, and my desktop got 'reorganized' by Windows). Gone back to 100%

paul116717-Oct-15 6:36

Re: flicker issue in Onpaint

17-Oct-15 6:36

Meanwhile, I have modified the test to a sole C++ application, and Ido still get the same (non-ClearType like) result. I am reposting this in the Graphics forum.

flicker issue in Onpaint

Amrit Agr8-Oct-15 1:53

Amrit Agr

8-Oct-15 1:53

Hi Guys,

I am getting flicker while painting a border on control, bannerbar(its derived from CWnd only). So the case if control is getting focus , border should get paint otherwise not.

I am handling OnsetFocus and OnKillfocus and calling Paintborder() in which I checked if banner got focus(by checking m_BannerHasFocus flag) i will call parent->InavlidateRect() here i passed banner rect as argument.

In Onpaint I am taking PS_DOT pen (if its have focus) and PS_NULL if don' have focus.

I am getting flicker while its getting/loosing focus Even i pass FALSE parameter in InvalidateRect, which will not erase background.

Please help me out. I pasted source code here. Thanks

void CBannerBar::OnSetFocus(CWnd* pOldWnd)
{
CBaseWnd::OnSetFocus(pOldWnd);
// TODO: Add your message handler code here
m_BannerHasFocus = true;
PaintBannerBorder();
}

void CBannerBar::OnKillFocus(CWnd* pNewWnd)
{
CBaseWnd::OnKillFocus(pNewWnd);

// TODO: Add your message handler code here
m_BannerHasFocus = false;
PaintBannerBorder();

}

void CBannerBar::PaintBannerBorder()
{
//Invalidate the control in order to hide the focus rectangle.
CRect rect;
GetWindowRect(&rect);
CWnd* pParent = GetParent();
if (!rect.IsRectEmpty() && pParent != NULL)
{
pParent->ScreenToClient(rect);
pParent->InvalidateRect(rect, FALSE);
}
}

void CBannerBar::OnPaint()
{
CPaintDC dc(this); // device context for painting

// create a brush of the background color and paint the window with it
CBrush  brush (BACK_COLOR);
dc.FillRect(&dc.m_ps.rcPaint, &brush);
brush.DeleteObject();

CDC* pDC = GetWindowDC();

CRect rect;
GetWindowRect(&rect);
rect.OffsetRect(-rect.left, -rect.top);
COLORREF dColour = GetSysColor(COLOR_HIGHLIGHT);
if (m_BannerHasFocus)
{
    dColour = RGB(255, 0, 0);
}

CPen pen(m_BannerHasFocus ? PS_DOT : PS_NULL, 1, dColour);
CPen* penOld = (CPen*)pDC->SelectObject(&pen);
pDC->SetBkMode(TRANSPARENT);

pDC->MoveTo(rect.left, rect.top);
pDC->LineTo(rect.right - 1, rect.top);
pDC->LineTo(rect.right - 1, rect.bottom - 1);
pDC->LineTo(rect.left, rect.bottom - 1);
pDC->LineTo(rect.left, rect.top);

pDC->SelectObject(penOld);

ReleaseDC(pDC);

// Do not call CBaseWnd::OnPaint() for painting messages

}

John Schroedl8-Oct-15 4:54

Debug Visualizers coming for C++/CLI!

8-Oct-15 4:54

You may want to try this in the C / C++ / MFC forum. This is C++ / CLI.

John Schroedl2-Oct-15 3:05

I have spy ware on this computer I tracked it......

2-Oct-15 3:05

Good news for us C++/CLI devs! (a small but proud group)

A comment by Adam Welch [MSFT] in the vcblog post titled: Debug Visualizers in Visual C++ 2015[^] states that Microsoft is working on updating the Mixed Mode debugger to support debug visualizers. This is something I've personally requested for YEARS.

So I'm very happy to see that news and thought I'd pass it along here.

John

modified 8-Oct-15 9:55am.

Member 1198386422-Sep-15 9:54

Member 11983864

22-Sep-15 9:54

Solve this. I have a malware spyware on this computer right now and a Samsung dealer with remote support put it here. It is in internet explorer my curser, files, net mass downloading,making other profiles and making your screen look normal. I found it in internet explorer's setting and right clicked and got some words that didn't make sense I followed it to a site that was and is still hooked to this computer probably watching me write this comment. I am not important, why do they want to spy on me? I watched it and got into their files where they write C++ code into everything. I had the internet off. My android phone off. When I turned my phone on it popped up a big red warning so I turned it off really fast, then waited 10 min turned it on and hit lookout really quick and blocked everything. Well I finally turned my phone back on and it is in there. I think it is a window's product because admittedly my windows is not genuine .They keep file logs of everything. They watch and listen to you. They have a bunch of squares they called emulation. they have a console veiw where they put enabled words into the code. They have a search and a Rendering box at the bottom At the top it says Elements,Network,Sources,Timeline and Profiles. I was so busy trying to get my profile back away from them I was actually reading the script that popped up when I clicked help telling me how to hack someones computer using C++ and code words. They have call stacks,DOM breakpoints,XHR breakpoints,Event listener breakpoints,It tells you how to go to the computers profile page and make names similar so the user won't know and take system control and ownership and permissions away. When the caught me I kept opening more windows and pushing buttons and deleting stuff etc. But they shut me down and I turned my computer back to an earlier time and they are still here. They caught me watching them I was trying to delete the extra accounts they made and they shut me down. but it had all the products they use to infect you could click on the one you needed and It had windows xp, vista, 7, 10 Linux, x box 360, x box one, Firefox opera, that new quota is them too.Android, The name of the company had a help website for big businesses. I wish I could have gotten the name it started with a bunch of xx's I have an old windows xp notebook I let my Grandson play on and I fiddled with it this morning until it became diseased I found the port and I am actually watching it now but it is way less suffocated than the one on my Window's 7 and android phone. Lookout did not log it and I have not asked for my stuff back yet but I know it is on my phone even with it being blocked every way possible. Any ideas on how to get this off? I tried to post this to comments in CW but it would not let me. I am really not a paranoid nut. I guess gmail is safe for now.

Re: I have spy ware on this computer I tracked it......

Richard Andrew x6422-Sep-15 11:42

Richard Andrew x64

22-Sep-15 11:42

What does this have to do with C++/CLI?

Also, here's some whitespace " ", you really need it.

The difficult we do right away...
...the impossible takes slightly longer.

Re: I have spy ware on this computer I tracked it......

Member 1198386423-Sep-15 11:22

Member 11983864

23-Sep-15 11:22

I am a 60 year old woman with no computer skills. I put it under this heading because it was using C++ to hack peoples computers. I was typing fast so I could list everything I was seeing before they found out and blocked it again. I looked up white space so I guess that was an insult on my post being not grammatically correct.Instead of being a jerk you could have used your"jerk space" to tell me where I should have posted it.

Re: I have spy ware on this computer I tracked it......

Richard MacCutchan23-Sep-15 22:42