Managed C++/CLI Discussion Boards

Richard Andrew x6427-Mar-11 15:24

27-Mar-11 15:24

I think the problem might be that you're not keeping track of which panel is at the head of the snake, since movement is referenced against the head panel.

The code might go something like this: ( I have not tested this code. It might need modification. )

if ( y2 == -1 ) // Move down
{
    segments[last]->panel->Top = y + segments[head]->panel->Top + 2;
    segments[last]->panel->Left = segments[head]->panel->Left;

    head = last;
    last++;
    if ( last >= size )
    {
        last = 0;
    }

}

The difficult we do right away...
...the impossible takes slightly longer.

Re: Animating a snake (aka Snafu)

Cyclone_S28-Mar-11 13:21

Cyclone_S

28-Mar-11 13:21

You are correct, that's what the problem was. The snake is now moving in all directions. Thanks for helping me out. Smile | :)

Re: Animating a snake (aka Snafu)

Cyclone_S30-Mar-11 13:22

Cyclone_S

30-Mar-11 13:22

One last thing. I got the collision function working 99% but there's a small glitch where if
the head collides with the tail the collision function doesn't catch it and the snake keeps moving.

The collision function.

void check_for_collision()
			{
				for(int Tail = 0; Tail <= (size-1); Tail++)
				{
					for(int I = 0;I <= (size-1); I++)
					{
						if(I != head){segments[I]->panel->BackColor= Color::Blue;} else
						{
							segments[head]->panel->BackColor= Color::Yellow; // Color the head a different yellow.
						}

						if(head!= Tail && segments[head]->panel->Left == segments[Tail]->panel->Left && segments[head]->panel->Top == segments[Tail]->panel->Top) // Detect a collision is segments overlap.
						{
							segments[head]->panel->BackColor= Color::Red;
							Timer1->Stop();
						}
					
					}
				}
			}

Entire code.

#include "stdafx.h"
using namespace System;
using namespace System::Drawing;
using namespace System::Windows::Forms;
using namespace System::Collections::Generic; // Required to make lists.

public ref class snake_segment
{
	public:
			Panel^ panel; // A Panel is used to make the snake.

			snake_segment( Form ^ form ) // Class Constructor.
			{ 
				
				panel = gcnew Panel();
				//panel->BackColor= Color::Blue;
				panel->Width = 20; panel->Height = 20;
				form->Controls->Add(panel);
			}
};

public ref class Form1 : public Form 
{
	public:
			List<snake_segment^>^ segments; // A list that contains the snake segments.
			int l; // Length of the snake at begining of game.
			int size; // The number of segments in snake/list.
			int tail;  // The tail segment of the snake.
			int head;  // The head segment of the snake.
			int x, y; // The coordinates of the snake segment(head).
			int direction; // Stores the direction the snake will move.
			Timer^ Timer1; // The timer that will move the snake.
			bool game_started;
			

			Form1() // Class constructor.
			{	
				segments = gcnew List<snake_segment^>();
				Timer1 = gcnew Timer();
				Timer1->Interval = 500;
				Timer1->Start();
				Timer1->Tick += gcnew System::EventHandler(this, &Form1::timer1_Tick);
				this->KeyDown += gcnew System::Windows::Forms::KeyEventHandler(this, &Form1::Form_KeyDown);
				Make_Snake();
			}
			
			void Make_Snake()
			{
				for(int I = 0; I <= 5; I++)
				{
					snake_segment^ s = gcnew snake_segment(this);
					s->panel->BackColor = Color::FromArgb(0,0,255);
					segments->Add(s);
				}

				for each (snake_segment^ s in segments) // Position the segments at start of game.
				{
					l += s->panel->Width + 2;
					s->panel->Left = l;
				}
				get_size_of_snake();
				segments[size-1]->panel->BackColor= Color::Yellow; // Color the head yellow.
			}

			void get_size_of_snake() // Get the size of the snake when a new segment is added by eating something etc.
			{
				size=0;
				for each (snake_segment^ s in segments)
				{
					size++;	
				}
				head=size-1;
			}

			void head_position() // The head position at start of game.
			{
				x = segments[size-1]->panel->Left;
				y = segments[size-1]->panel->Top;
			}

			void move_snake()
			{
				if(direction==1) // Move snake left.
				{
					segments[tail]->panel->Location = Drawing::Point(x - 20 - 2,y); // Note using "Location" instead of "Left/Top" solved a problem where the segment would flicker as it's being moved to the head position.
					head = tail;
					x = segments[head]->panel->Left;
					y = segments[head]->panel->Top;
					tail++;
					if(tail >= size){tail=0;}
				}

				if(direction==-1) // Move snake right.
				{
					segments[tail]->panel->Location = Drawing::Point(x + 20 + 2,y);
					head = tail;
					x = segments[head]->panel->Left;
					y = segments[head]->panel->Top;
					tail++;
					if(tail >= size){tail=0;}
				}

				if(direction==2) // Move snake up;
				{
					segments[tail]->panel->Location = Drawing::Point(x,y - 20 - 2);
					head = tail;
					x = segments[head]->panel->Left;
					y = segments[head]->panel->Top;
					tail++;
					if(tail >= size){tail=0;}
				}
				
				if(direction==-2) // Move snake down;
				{
					segments[tail]->panel->Location = Drawing::Point(x,y + 20 + 2);
					head = tail;
					x = segments[head]->panel->Left;
					y = segments[head]->panel->Top;
					tail++;
					if(tail >= size){tail=0;}
				}
				
			}

			void check_for_collision()
			{
				for(int Tail = 0; Tail <= (size-1); Tail++)
				{
					for(int I = 0;I <= (size-1); I++)
					{
						if(I != head){segments[I]->panel->BackColor= Color::Blue;} else
						{
							segments[head]->panel->BackColor= Color::Yellow; // Color the head a different yellow.
						}

						if(head!= Tail && segments[head]->panel->Left == segments[Tail]->panel->Left && segments[head]->panel->Top == segments[Tail]->panel->Top) // Detect a collision is segments overlap.
						{
							segments[head]->panel->BackColor= Color::Red;
							Timer1->Stop();
						}
					
					}
				}
			}

			System::Void timer1_Tick(System::Object^  sender, System::EventArgs^  e) // A timer that will move the snake;
			{
				
				if(!game_started){head_position();game_started=true;} // Find first head position at start of game.
				move_snake();
				check_for_collision();
			}

			System::Void Form_KeyDown(System::Object^ sender, System::Windows::Forms::KeyEventArgs^ e)
			{
				if(e->KeyCode == Keys::Left){direction=1;}
				if(e->KeyCode == Keys::Right){direction=-1;}
				if(e->KeyCode == Keys::Up){direction=2;}
				if(e->KeyCode == Keys::Down){direction=-2;}

				if(e->KeyCode == Keys::Space) // Add a new segment to the snake.
				{
					snake_segment^ s = gcnew snake_segment(this);
					segments->Insert(tail,s);
					head = tail;
					segments[tail]->panel->Location = Drawing::Point(x + segments[head]->panel->Width + 2,y); 
					x = segments[head]->panel->Left;
					y = segments[head]->panel->Top;
					tail++;
					get_size_of_snake();
					if(tail >= size){tail=0;}
				}	
			}
};

[STAThread]
int main()
{
    Application::Run(gcnew Form1());
}

Thanks.

Re: Animating a snake (aka Snafu)

Richard Andrew x6430-Mar-11 14:41

Richard Andrew x64

30-Mar-11 14:41

I think you should simplify the collision function. I don't think you need two loops.

If you want to check whether the head is colliding with any of the other segments, then just do:

for (int ThisSegment = 0; ThisSegment < (size-1); ThisSegment ++ )
{
    if ( ThisSegment == head ) continue;

    if ( segments[ThisSegment]->panel->Left == segments[head]->panel->Left &&
         segments[ThisSegment]->panel->Top  == segments[head]->panel->Top )
    {
        Timer->Stop();
    }
}

The difficult we do right away...
...the impossible takes slightly longer.

Re: Animating a snake (aka Snafu)

Cyclone_S31-Mar-11 9:14

Cyclone_S

31-Mar-11 9:14

Thanks. Thats much simpler code then what I had.

Re: Animating a snake (aka Snafu)

Cyclone_S16-Apr-11 8:44

Cyclone_S

16-Apr-11 8:44

Hi Richard. I was wondering if you would be able to help me with a bit of code. I posted it here. Thank You.

[Algorthm][^]

issue while loading MFC extension dll dynamically

ptr_Electron24-Mar-11 23:37

ptr_Electron

24-Mar-11 23:37

I had MFC dll which exposes some clases. I would like to load this dll dynamically.

hResult = LoadLibrary(_T("c:\test.dll));
if (0 != hResult)
{
		_InitSomeDLLFun = (InitSomeDLL)::GetProcAddress(hResult, "InitSomeDLL");
// always Undefind value is returned by GetProcAddress
																		  
		if(_InitSomeDLL)
		{
			_InitSomeDLLFun();
		}
		err = GetLastError();

}

Please advice

Re: issue while loading MFC extension dll dynamically

Richard MacCutchan25-Mar-11 0:02

Richard MacCutchan

25-Mar-11 0:02

What error is returned? Have you checked that InitSomeDLL is exported by your DLL and is not a mangled C++ name?

I must get a clever new signature for 2011.

Re: issue while loading MFC extension dll dynamically

ptr_Electron25-Mar-11 0:21

ptr_Electron

25-Mar-11 0:21

The LoadLibrary() call was sucessfull, but
GetProcAddress() always returns <undefind value="">

the dlls are unmanaged dlls.

Please advice

Re: issue while loading MFC extension dll dynamically

Richard MacCutchan25-Mar-11 1:03

Richard MacCutchan

25-Mar-11 1:03

Very interesting, but you didn't answer my questions.

I must get a clever new signature for 2011.

Re: issue while loading MFC extension dll dynamically

ptr_Electron25-Mar-11 2:50

ptr_Electron

25-Mar-11 2:50

GetLastError() after the GetProcAddress returnts error code: 127

Re: issue while loading MFC extension dll dynamically

Richard MacCutchan25-Mar-11 4:24

Richard MacCutchan

25-Mar-11 4:24

Did you bother to look up error code 127 to see what it indicates? I guess not; see here[^] for more information. Now you know what's wrong you can probably make a start at fixing it.

I must get a clever new signature for 2011.

Instances of an object

Cyclone_S19-Mar-11 15:47

Cyclone_S

19-Mar-11 15:47

Hi,

I'm currently making a simple game. Pressing the down arrow places a box on the form. Pressing up shoots missiles(blue boxes) and creates multiple instances of m1 which is part of the missle class.

What I want to do is change the color of each missle as it collides with the red box. So far only the last missile changes color. The other instances of the missle class get ignored.

#include "stdafx.h"
using namespace System;
using namespace System::Drawing;
using namespace System::Windows::Forms;

public ref class object
{
	public:
			PictureBox^ Box3;
			
			object( Form ^ form ) // Class Constructor.
			{
				Box3 = gcnew PictureBox();
				Box3->Left = 150;
				Box3->Top = 50;
				Box3->Width = 100;
				Box3->Height = 100;
				Box3->BackColor = System::Drawing::Color::Red;
				form->Controls->Add(Box3);
			}
};

public ref class missile
{
	public:
			PictureBox^ Box1;
			Timer^ Timer1;

			missile( Form ^ form ) // Class Constructor.
			{
				Timer1 = gcnew Timer;
				Timer1->Interval = 1;
				Timer1->Start();
				Box1 = gcnew PictureBox();
				Box1->Left = 150;
				Box1->Top = 240;
				Box1->Width = 10;
				Box1->Height = 10;
				Box1->BackColor = System::Drawing::Color::Blue;
				form->Controls->Add(Box1);
				Timer1->Tick += gcnew System::EventHandler(this, &missile::timer1_Tick);
			}

		System::Void timer1_Tick(System::Object^  sender, System::EventArgs^  e)
		{
			Box1->Top -= 1;
		}
};


public ref class Form1 : public Form 
{
	public:
			PictureBox^ Box2;
			missile^ m1;
			object^ o1;
			Timer^ Timer3;
			bool x;

			Form1() // Class constructor.
			{	
				x=false;
				Timer3 = gcnew Timer();
				Timer3->Interval = 1;
				Timer3->Start();
				Box2 = gcnew PictureBox();
				Box2->BackColor = Color::Blue;
				Box2->Top = 240;
				Box2->Left = (this->Width / 2) - 40;
				Box2->Width = 40;
				Box2->Height = 10;
				this->Controls->Add(Box2);
				this->KeyDown += gcnew System::Windows::Forms::KeyEventHandler(this, &Form1::Form_KeyDown);
				Timer3->Tick += gcnew System::EventHandler(this, &Form1::timer3_Tick);
			}

			System::Void Form_KeyDown(System::Object^ sender, System::Windows::Forms::KeyEventArgs^ e)
			{	
				if(e->KeyCode == Keys::Up){x=true;m1 = gcnew missile(this);m1->Box1->Left = Box2->Left + (Box2->Width / 2) - 10;}
				if(e->KeyCode == Keys::Left){Box2->Left -= 4;}
				if(e->KeyCode == Keys::Right){Box2->Left += 4;}
				if(e->KeyCode == Keys::Down) {o1 = gcnew object(this); }
			}

			System::Void timer3_Tick(System::Object^  sender, System::EventArgs^  e)
			{
				if(x==true)
				{
					if(m1->Box1->Top == o1->Box3->Bottom){m1->Box1->BackColor = Color::Green;}
				}
			}

			bool isColliding(PictureBox^ box1, PictureBox^ box3)
			{
				Rectangle r1 = m1->Box1->Bounds;
				Rectangle r2 = o1->Box3->Bounds;
				return r1.IntersectsWith(r2); //return true if they collide
			}
			
};


[STAThread]
int main()
{	
    Application::Run(gcnew Form1());
}

I also am trying to figure out how to remove the instances from memory after a set amount of time as too many instances slows the program.

Thanks for the help.

Re: Instances of an object

John Schroedl19-Mar-11 17:51

John Schroedl

19-Mar-11 17:51

I think your real slowdown comes from having a timer in each individual missiles. They keep ticking even after they've left the screen. And you never stop the timer and unsubscribe the tick event in each missile. This keeps the timers and missiles all alive all the time.

I've tweaked your code some and removed those separate timers and just update all the missiles from the Form's timer. Also, I remove the missiles which have gone off-screen so those won't be updated after they're gone . This should allow for more missiles and better perf/memory usage.

There are clearly other improvements you could do such as having the logic to determine whether a missile is off-screen determined by the missile class.

I hope this helps you get going...

John

using namespace System;

using namespace System::ComponentModel;
using namespace System::Collections;
using namespace System::Windows::Forms;
using namespace System::Data;
using namespace System::Drawing;

using namespace System::Collections::Generic;

public ref class object{	
	public:			
		PictureBox^ Box3;						
		
		object( Form ^ form ) // Class Constructor.			
		{				
			Box3 = gcnew PictureBox();				
			Box3->Left = 150;				
			Box3->Top = 50;				
			Box3->Width = 100;				
			Box3->Height = 100;				
			Box3->BackColor = System::Drawing::Color::Red;				
			form->Controls->Add(Box3);			
		}
};

public ref class missile{	
	public:			
		PictureBox^ Box1;			
		
		missile( Form ^ form ) // Class Constructor.			
		{				
			Box1 = gcnew PictureBox();				
			Box1->Left = 150;				
			Box1->Top = 240;				
			Box1->Width = 10;				
			Box1->Height = 10;				
			Box1->BackColor = System::Drawing::Color::Blue;				
			form->Controls->Add(Box1);				
		}		
		
		void update()
		{
			Box1->Top--;
		}
};

public ref class Form1 : public System::Windows::Forms::Form
{
public:		
	PictureBox^ Box2;			
	object^ o1;			
	Timer^ Timer3;			
	bool x;			
	List<missile^>^ Missiles;
		
	Form1() // Class constructor.			
	{		
		Missiles = gcnew List<missile^>();

		x=false;				
		Timer3 = gcnew Timer();				
		Timer3->Interval = 1;				
		Timer3->Start();				
		Box2 = gcnew PictureBox();				
		Box2->BackColor = Color::Blue;				
		Box2->Top = 240;				
		Box2->Left = (this->Width / 2) - 40;				
		Box2->Width = 40;				
		Box2->Height = 10;				
		this->Controls->Add(Box2);				
		this->KeyDown += gcnew System::Windows::Forms::KeyEventHandler(this, &Form1::Form_KeyDown);				
		Timer3->Tick += gcnew System::EventHandler(this, &Form1::timer3_Tick);			
	}			
		
	System::Void Form_KeyDown(System::Object^ sender, System::Windows::Forms::KeyEventArgs^ e)			
	{					
		if(e->KeyCode == Keys::Up)
		{
			x=true;
			missile^ m = gcnew missile(this);
			m->Box1->Left = Box2->Left + (Box2->Width / 2) - 10;
			Missiles->Add(m);
		}				
			
		if(e->KeyCode == Keys::Left) {Box2->Left -= 4; }							
		if(e->KeyCode == Keys::Right){Box2->Left += 4; }				
		if(e->KeyCode == Keys::Down) {o1 = gcnew object(this); }			
	}			
		
	bool IsMissileOffScreen(missile^ m)
	{
		return m->Box1->Bottom < 0;
	};

	System::Void timer3_Tick(System::Object^  sender, System::EventArgs^  e)			
	{		
		for each (missile^ m in Missiles)
		{
			m->update();
				if(x==true && o1 != nullptr)				
			{					
				if (m->Box1->Top == o1->Box3->Bottom)
				{
					m->Box1->BackColor = Color::Green;
				}				
			}	
		}

		Missiles->RemoveAll(gcnew Predicate<missile^>(this, &Form1::IsMissileOffScreen));
	}			
		
	bool isColliding(PictureBox^ box1, PictureBox^ box3)			
	{	
		Rectangle r2 = o1->Box3->Bounds;				
		for each (missile^ m in Missiles)
		{
			Rectangle r1 = m->Box1->Bounds;				
			if (r1.IntersectsWith(r2)) //return true if they collide		
				return true;
		}
		return false;
	}			
};

Re: Instances of an object

John Schroedl19-Mar-11 18:01

John Schroedl

19-Mar-11 18:01

Also, if you want to detect a collision, change the logic in the timer tick:

System::Void timer3_Tick(System::Object^  sender, System::EventArgs^  e)
{
    for each (missile^ m in Missiles)
    {
        m->update();

        if(x==true && o1 != nullptr)
        {
            if (o1->Box3->Bounds.IntersectsWith(m->Box1->Bounds))
            {
                m->Box1->BackColor = Color::Green;
            }
        }
    }

    Missiles->RemoveAll(gcnew Predicate<missile^>(this, &Form1::IsMissileOffScreen));
}

Other advice: It would be courteous to let us know that you've posted about this in the C++ forum as well to prevent duplication of efforts.

John

Re: Instances of an object

Cyclone_S20-Mar-11 9:56

Cyclone_S

20-Mar-11 9:56

Thanks for the help.

how would I go about deleting m1,m2 in my original code? Not sure how to delete the m1,m2 objects. I currently have something like this.

if(e->KeyCode == Keys::Up) // Check if m1,m2 objects exist or not. If they don't then create them.
				{
					mcount += 1;
					l1->Text = mcount.ToString();
					if(mcount == 1 && !m1){mcount1 = true; m1 = gcnew missile(this);m1->Box1->Left = Box2->Left + (Box2->Width / 2) - 10;}
					if(mcount == 2 && !m2){mcount=0;mcount2 = true;m2 = gcnew missile(this);m2->Box1->Left = Box2->Left + (Box2->Width / 2) - 10;}
					if(mcount == 2){mcount=0;}

Re: Instances of an object

Luc Pattyn20-Mar-11 10:47

Luc Pattyn

20-Mar-11 10:47

The easiest way is to keep only real missiles in your collection, which means:
- the collection starts off empty;
- when you create a missile, add it to the collection;
- when you destroy a missile, remove it from the collection.

Avoid overall variables (such as mcount in your example), as they typically are redundant and hence just can cause bugs and inconsistencies.

Smile | :)

Luc Pattyn [Forum Guidelines] [My Articles] Nil Volentibus Arduum

Please use <PRE> tags for code snippets, they preserve indentation, improve readability, and make me actually look at the code.

Re: Instances of an object

Cyclone_S20-Mar-11 14:47

Cyclone_S

20-Mar-11 14:47

Thanks.

John a have a few questions about your code.

1.

Missiles->RemoveAll(gcnew Predicate<missile^>(this, &Form1::IsMissileOffScreen));

How exactly does this work.

2. What does the ^ character do.

Thanks again.

Re: Instances of an object

Luc Pattyn20-Mar-11 14:50

Luc Pattyn

20-Mar-11 14:50

Oops. You replied to me, not to John. I suggest you try again.

Smile | :)

Luc Pattyn [Forum Guidelines] [My Articles] Nil Volentibus Arduum

Please use <PRE> tags for code snippets, they preserve indentation, improve readability, and make me actually look at the code.

Re: Instances of an object

Cyclone_S20-Mar-11 15:30

Cyclone_S

20-Mar-11 15:30

Thanks.

John a have a few questions about your code.

1.
Missiles->RemoveAll(gcnew Predicate<missile^>(this, &Form1::IsMissileOffScreen));How exactly does this work.

2. What does the ^ character do.

Thanks again.

Re: Instances of an object

John Schroedl21-Mar-11 4:02

John Schroedl

21-Mar-11 4:02

Let's start with #2:

The ^ character indicates a handle which is a reference to a managed object on the CLI heap.

The Wikipedia article isn't too good at explaining in my opinion: http://en.wikipedia.org/wiki/C%2B%2B/CLI#Handles[^] but you may want to look at it anyway.

This intro may be a bit friendlier: http://www.functionx.com/cppcli/handles/Lesson06c.htm[^]

For #1:

I'm creating a Predicate which is really just a function which returns True or False based on my own rules. Often predicates are used for sorting.

So my predicate function (IsMissileOffScreen) returns True if I see the missile has left the screen.

In RemoveAll, my predicate is called and passed one missile at a time as a parameter (the type of the parameter is missile^ which I indicate in the < > arguments. If I return True from IsMissileOffScreen, the RemoveAll() call will remove the missile from the Missiles list. So after this line, we're left with only on-screen missiles in the Missiles list.

Make sense?

John

Re: Instances of an object

Cyclone_S21-Mar-11 15:44

Cyclone_S

21-Mar-11 15:44

Yea it mostly makes sense. I apreciate the help.

Re: Instances of an object

Cyclone_S23-Mar-11 13:21

Cyclone_S

23-Mar-11 13:21

I have one little issue. I can't seem to delete the enemy object. I have tried "delete o1" and dispose "o1->Box3->Dispose" and none work. Any ideas? Thanks.

System::Void timer1_Tick(System::Object^  sender, System::EventArgs^  e) // A timer that checks for missile collisions.
			{
				for each (missile^ m in Missiles) // Go through the "Missiles" list and check for certain conditions such as a missile collision.
				{
					if(IsColliding(m)) // Run the collision detection function.
					{
						collision = false;
						if(m->Timer1->Enabled || m->Timer2->Enabled || m->Timer3->Enabled || m->Timer4->Enabled){collision_counter++;}
						Label1->Text = collision_counter.ToString();
						if(collision_counter == 1){} // Destroy the enemy object.
						m->Timer1->Stop(); // Stop the missiles from animatiing.
						m->Timer2->Stop();
						m->Timer3->Stop();
						m->Timer4->Stop();
					}
				}
				Missiles->RemoveAll(gcnew Predicate<missile^>(this, &Form1::IsMissileOffScreen)); // Remove any m("missile" class object instances) from the "Missile" list.
			}

Entire Code

#include "stdafx.h"
#include <stdlib.h>
#include <time.h>
using namespace System;
using namespace System::Windows::Forms;
using namespace System::Drawing;
using namespace System::Collections::Generic;

public ref class missile // missile class
{
	public:
			PictureBox^ Box1; // Create the missile using a Picturebox control.			
			Timer^ Timer1;
			Timer^ Timer2;
			Timer^ Timer3;
			Timer^ Timer4;

			missile( Form ^ form ) // Class Constructor.
			{
				Timer1 = gcnew Timer();
				Timer2 = gcnew Timer();
				Timer3 = gcnew Timer();
				Timer4 = gcnew Timer();
				Timer1->Interval = 1;
				Timer1->Start();
				Timer2->Interval = 1;
				Timer3->Interval = 1;
				Timer4->Interval = 1;
				Box1 = gcnew PictureBox();
				Box1->Width = 10;
				Box1->Height = 10;
				Box1->Left = 150;
				Box1->Top = 335;
				Box1->BackColor = System::Drawing::Color::Blue;
				form->Controls->Add(Box1);
				Timer1->Tick += gcnew System::EventHandler(this, &missile::timer1_Tick);
				Timer2->Tick += gcnew System::EventHandler(this, &missile::timer2_Tick);
				Timer3->Tick += gcnew System::EventHandler(this, &missile::timer3_Tick);
				Timer4->Tick += gcnew System::EventHandler(this, &missile::timer4_Tick);
			}
			
			System::Void timer1_Tick(System::Object^  sender, System::EventArgs^  e)
			{
				Box1->Top--; // Move the missiles up using a timer.
			}

			System::Void timer2_Tick(System::Object^  sender, System::EventArgs^  e) 
			{
				Box1->Left++; // Move the missiles right using a timer.
			}

			System::Void timer3_Tick(System::Object^  sender, System::EventArgs^  e) 
			{
				Box1->Top++; // Move the missiles down using a timer.
			}

			System::Void timer4_Tick(System::Object^  sender, System::EventArgs^  e) 
			{
				Box1->Left--; // Move the missiles left using a timer.
			}
};

public ref class object // The enemy 'object' class.
{
	public:
			PictureBox^ Box3; // Create the enemies using a Picturebox control.
			

			object( Form ^ form ) // Class Constructor.
			{   
				Box3 = gcnew PictureBox();
				Box3->Width = 100;
				Box3->Height = 100;
				Box3->Left = 145;
				Box3->Top = 125;
				Box3->BackColor = System::Drawing::Color::Red;
				form->Controls->Add(Box3);
			}
};

public ref class laser // Enemy lasers.
{
	public:
			PictureBox^ Box4;
			Timer^ Timer1;

			laser( Form ^ form ) // Class Constructor.
			{
				Timer1 = gcnew Timer();
				Timer1->Interval = 1;
				Timer1->Start();
				Box4 = gcnew PictureBox();
				Box4->Width = 8;
				Box4->Height = 50;
				Box4->Left = 145;
				Box4->Top = 125;
				Box4->BackColor = System::Drawing::Color::Red;
				form->Controls->Add(Box4);
				Timer1->Tick += gcnew System::EventHandler(this, &laser::timer1_Tick);
			}

			System::Void timer1_Tick(System::Object^  sender, System::EventArgs^  e) 
			{
				Box4->Top++; // Move the missiles down using a timer.
			}
};

public ref class Form1 : public Form // The main form.
{
	public:
			PictureBox^ Box2; // Create the turret using a Picturebox control.
			object^ o1;
			Timer^ Timer1; // A timer which checks for missile collisions.
			Timer^ Timer2; // A timer which fires lasers from the enemy objects.
			List<missile^>^ Missiles; // A list that contains the missile objects.
			List<laser^>^ Lasers; // A list that contains the laser objects.
			bool collision;
			bool tLeft;
			bool tBottom;
			bool tTop;
			bool tRight;
			int collision_counter;
			Label^ Label1;

			Form1() // Class constructor.
			{	
				Label1 = gcnew Label();
				Label1->Text = "0";
				tBottom = true;
				Missiles = gcnew List<missile^>();
				Lasers = gcnew List<laser^>();
				Timer1 = gcnew Timer();
				Timer1->Interval = 1;
				Timer1->Start();
				Timer2 = gcnew Timer();
				Timer2->Interval = 1000;
				Box2 = gcnew PictureBox();
				Box2->BackColor = Color::Blue;
				Box2->Top = 340;
				Box2->Left = (this->Width / 2) + 15;
				Box2->Width = 40;
				Box2->Height = 10;
				this->Controls->Add(Box2);
				this->Controls->Add(Label1);
				this->Width = 400;
				this->Height = 400;
				this->KeyDown += gcnew System::Windows::Forms::KeyEventHandler(this, &Form1::Form_KeyDown);
				Timer1->Tick += gcnew System::EventHandler(this, &Form1::timer1_Tick);
				Timer2->Tick += gcnew System::EventHandler(this, &Form1::timer2_Tick);
			}

			System::Void Form_KeyDown(System::Object^ sender, System::Windows::Forms::KeyEventArgs^ e)
			{	
				if(o1 != nullptr)
				{
				if(e->KeyCode == Keys::Up) // Fire the missiles.
				{	
					missile^ m = gcnew missile(this);
					if(tBottom == true)
					{
						m->Box1->Left = Box2->Left + (Box2->Width / 2) - 10;
						m->Timer1->Start();m->Timer2->Stop();m->Timer3->Stop();m->Timer4->Stop();
					}
					else if(tLeft == true)
					{
						m->Timer1->Stop(); m->Timer2->Start();m->Timer3->Stop();m->Timer4->Stop();
						m->Box1->Left = Box2->Left + Box2->Width;
						m->Box1->Top = Box2->Top + (Box2->Width / 2) + 10;
					}
					else if(tTop == true)
					{
						m->Timer1->Stop(); m->Timer2->Stop();m->Timer3->Start();m->Timer4->Stop();
						m->Box1->Left = Box2->Left + (Box2->Width / 2) - 6;
						m->Box1->Top = Box2->Bottom - 10;
					}
					else if(tRight == true)
					{
						m->Timer1->Stop(); m->Timer2->Stop();m->Timer3->Stop();m->Timer4->Start();
						m->Box1->Left = Box2->Left;
						m->Box1->Top = Box2->Bottom - 25;
					}
					Missiles->Add(m); // Add the m (missile object instances) to the list.
				}
				
				// Move the turret.
				if(e->KeyCode == Keys::Left) // Move the turret along all 4 sides of window.
				{

					if(tBottom == true)
					{
						Box2->Left -= 4;
						if(Box2->Left <=4)
						{
							Box2->Width = 10;Box2->Height = 40;
							Box2->Top -= 30; Box2->Left += 1;
							tBottom = false; tLeft = true;
						}
					}
					
					if(tLeft == true)
					{
						Box2->Top -= 4;
						if(Box2->Top <=4)
						{
							Box2->Width = 40;Box2->Height = 10;
							tLeft = false; tTop = true;
						}
					}

					if(tTop == true)
					{
						Box2->Left += 4;
						if(Box2->Right >= 380)
						{
							Box2->Width = 10;Box2->Height = 40;
							Box2->Left += 28; Box2->Top -= 4;
							tTop = false; tRight = true;
						}
					}

					if(tRight == true)
					{
						Box2->Top += 4;
						if(Box2->Bottom >= 350)
						{
							Box2->Width = 40;Box2->Height = 10;
							Box2->Left -= 31; Box2->Top += 30;
							tRight = false; tBottom = true;
						}
					}
				}

				if(e->KeyCode == Keys::Right)
				{
					if(tBottom == true)
					{
						Box2->Left += 4;
						if(Box2->Right >= 380)
						{
							Box2->Width = 10;Box2->Height = 40;
							Box2->Top -= 26; Box2->Left += 28;
							tBottom = false; tRight = true;
						}
					}
					
					if(tRight == true)
					{
						Box2->Top -= 4;
						if(Box2->Top <=4)
						{
							Box2->Left -= 26;
							Box2->Width = 40;Box2->Height = 10;
							tRight = false; tTop = true;
						}
					}

					if(tTop == true)
					{
						Box2->Left -= 4;
						if(Box2->Left <= 4)
						{
							
							Box2->Top -= 4;
							Box2->Width = 10;Box2->Height = 38;
							tTop = false; tLeft = true;
						}
					}

					if(tLeft == true)
					{
						Box2->Top += 4;
						if(Box2->Bottom >= 350)
						{
							Box2->Left -= 0; Box2->Top += 25;
							Box2->Width = 40;Box2->Height = 10;
							tLeft = false; tBottom = true;
						}
					}
				}
				}
				// Start the game.
				if(e->KeyCode == Keys::Down) {o1 = gcnew object(this);Timer2->Start();}
			}

			bool IsMissileOffScreen(missile^ m) // Check is a missile goes off screen.
			{
				return m->Box1->Bottom < 0;
			}

			bool IsColliding(missile^ m) // Check is a missile collides with the box.
			{
				if((m->Box1->Right >= o1->Box3->Left && m->Box1->Right <= o1->Box3->Right) ||  (m->Box1->Left >= o1->Box3->Left && m->Box1->Left <= o1->Box3->Right))
				{
					if((m->Box1->Top >= o1->Box3->Top && m->Box1->Top <= o1->Box3->Bottom) || (m->Box1->Bottom >= o1->Box3->Top && m->Box1->Bottom <= o1->Box3->Bottom))
					collision = true;
				}
				else if((m->Box1->Top >= o1->Box3->Top && m->Box1->Top <= o1->Box3->Bottom) || (m->Box1->Bottom >= o1->Box3->Top && m->Box1->Bottom <= o1->Box3->Bottom))
				{
					if((m->Box1->Right >= o1->Box3->Left && m->Box1->Right <= o1->Box3->Right) || (m->Box1->Left >= o1->Box3->Left && m->Box1->Left <= o1->Box3->Right))
					collision = true;
				}
				return collision; // Returns true if there is a collision.
			}
		
			System::Void timer1_Tick(System::Object^  sender, System::EventArgs^  e) // A timer that checks for missile collisions.
			{
				for each (missile^ m in Missiles) // Go through the "Missiles" list and check for certain conditions such as a missile collision.
				{
					if(IsColliding(m)) // Run the collision detection function.
					{
						collision = false;
						if(m->Timer1->Enabled || m->Timer2->Enabled || m->Timer3->Enabled || m->Timer4->Enabled){collision_counter++;}
						Label1->Text = collision_counter.ToString();
						if(collision_counter == 1){} // Destroy the enemy object.
						m->Timer1->Stop(); // Stop the missiles from animatiing.
						m->Timer2->Stop();
						m->Timer3->Stop();
						m->Timer4->Stop();
					}
				}
				Missiles->RemoveAll(gcnew Predicate<missile^>(this, &Form1::IsMissileOffScreen)); // Remove any m("missile" class object instances) from the "Missile" list.
			}

			System::Void timer2_Tick(System::Object^  sender, System::EventArgs^  e) // A timer that fires lasers from the enemy object.
			{
				
				laser^ lD = gcnew laser(this);
				lD->Box4->Top = o1->Box3->Bottom;



				Lasers->Add(lD); // Add the l (laser object instances) to the list.
			}
};


[STAThread]
int main()
{	
    Application::Run(gcnew Form1()); // Run the application\create the main form.
}

Re: Instances of an object

Luc Pattyn23-Mar-11 16:01

Luc Pattyn

23-Mar-11 16:01

why would each missile need four timers? you can have multiple statements in a single Tick handler, and you can skip part of the handler if not all code needs the same period, as in (C# code again):

int tick=0;

public void TickHandler(object sender, EventArgs e) {
    tick++;
    doSomethingEachTime();
    if (tick%10==0) doSomethingEveryTenthTime();
}

And I already told you an interval of 1 msec does not really exist for the timers you are using, see the article I provided a link to.

Smile | :)

Luc Pattyn [Forum Guidelines] [My Articles] Nil Volentibus Arduum

Please use <PRE> tags for code snippets, they preserve indentation, improve readability, and make me actually look at the code.

Re: Instances of an object

John Schroedl23-Mar-11 18:22

John Schroedl

23-Mar-11 18:22

Luc is correct, the missile really should not maintain four timers.

As for why you cannot seem to delete the object, there are a few things here:

When you detect the collision, you need to remove o1->Box3 from the form children so that it disappears from the screen. After that, simply set o1 = null;

It's probably smart to make a function in the object class like explode() which does the removal of Box3.

Also, you have lots of code which assumes o1 is non-null. You need to check o1 for null before using it.

And one more suggestion is to rename your class from "object" to something like "target" since it's easy to confuse with System::Object.

John

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.