Android

Re: Android: High Pass filter

13-Feb-17 2:41

Himanshu Bhutani wrote:
Now i can't tell if it is filtering out everything and hence playing nothing or that the output file never gets the filtered part.

Have you stepped through the code using your debugger?

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles

Nick_314159265415-Apr-17 3:55

Nick_3141592654

15-Apr-17 3:55

I suggest that you add logging to your application using the default android log utility. This will make your investigation much easier. Using a debugger - as somebody else suggested - is a very valid approach, but where you are looking at real-time effects (which may or may not be relevant) there's no substitute for logging. You can do this as follows:

Add this import to your MainActivity and Filter classes:

Java

import android.util.Log;

Then add this static variable as a class variable to each:

Java

private static final String TAG = "Himanshu";

Now add some logging like this:

Java

while ((read = in.read(buff)) > 0) {
    Log.i(TAG, "Raw audio: " + read);    // *** Nick's suggested log point. ***               
    out.write(buff, 0, read);
}
out.flush();
byte[] audioBytes = out.toByteArray();
final FloatBuffer fb = ByteBuffer.wrap(audioBytes).asFloatBuffer();
final float[] dst = new float[fb.capacity()];
fb.get(dst);

Filter filter = new Filter(15000,44100, Filter.PassType.Highpass,1);
for (int i = 0; i <dst.length; i++) {
    filter.Update(dst[i]);
    dst[i] = filter.getValue();
    Log.i(TAG, "Filtered audio: " + dst[i]);   // *** Nick's suggested log point. ***
}

etc etc..

In order to view your log you need to use adb. If you work in a windows environment you'd do this in a DOS command shell:

adb logcat Himanshu:* *:s -v time

Issue the above logcat command BEFORE starting your app and triggering the audio record & playback. This command is saying: Capture all log messages (.i, .d, .v, .w, .e etc.. i.e. of category: Information, Debug, Verbose, Warning and Error) and do NOT capture any other log messages, show log timestamps.

I didn't check all of the places in your code where that would also shed light on the problem. It's your code and I'm sure that you can quickly identify these places.

Actually I would have done a couple of other things also before going quite so far as you have:

1. Confirm that you can play audio samples, do this by creating a simple square wave, storing it in memory and squirting it out. You can use PCM at 16 kSamples/sec and a ~200 Hz waveform.

2. Capture recorded audio to a file and check that this is valid audio.

One other thing to mention is that you are using the AMR Narrow Band voice codec. This is not a generic audio encoding algorithm. AMR (NB) has been highly optimised for voice telephony, and as is the case for such codecs. This may be important because these codecs do not handle tones at all well and music isn't very well supported. I'm not sure what kind of audio you are dealing with. You may want to consider an alternative audio encoding format such as MP3 or plain/differential PCM.

Android Day of Week Calculator

Pavlex49-Feb-17 9:50

9-Feb-17 9:50

I have created program that calculates day of week when entered date in format "January 7 2000" .Why do I get NullPointerException exception when I click button to calculate day of week?

Here is source code of app:

Java

public class MainActivity extends AppCompatActivity
{
    private int position;
    private int value;
    private Button button;
    private EditText editText;
    private TextView textView1,textView2;
    private Spinner spinner,spinner2;
    private ArrayAdapter<CharSequence> adapter;

    private boolean isValid;
    private Date date;
    private int inMonth, inDay, inYear;

    static boolean isDateValid(int month, int day, int year)
    {
        boolean validation = true;
        int[] daysInMonth = { 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 };

        if (month < 1 || month > 12)
        {
            validation = false;
        }

        if (day < 1 || day > daysInMonth[month - 1])
        {
            validation = false;
        }

        if (year < 1700 || year > 3000)
        {
            validation = false;
        }
        return validation;
    }

    static String zellerCalc(int month, int day, int year)
    {
        String dayOfWeek;
        int m = -1; 
        int h = -1; 
        int q = day;
        int k;
        int j;

        if (month == 1)
        {
            m = 13;
        }
        else if (month == 2)
        {
            m = 14;
        }
        else
        {
            m = month;
        }

        if (m == 13 || m == 14)
        {
            year--;
        }

        k = year % 100;
        j = year / 100; 

        h = (q + (int)((13 * (m + 1)) / 5.0) + k + (int)(k / 4.0) + (int)(j / 4.0) + (5 * j)) % 7;

        if (h == 0)
        {
            dayOfWeek = "Subota";
        }
        else if (h == 1)
        {
            dayOfWeek = "Nedelja";
        }
        else if (h == 2)
        {
            dayOfWeek = "Ponedeljak";
        }
        else if (h == 3)
        {
            dayOfWeek = "Utorak";
        }
        else if (h == 4)
        {
            dayOfWeek = "Sreda";
        }
        else if (h == 5)
        {
            dayOfWeek = "Četvrtak";
        }
        else
            dayOfWeek = "Petak";

        return dayOfWeek;
    }

    @Override
    protected void onCreate(Bundle savedInstanceState)
    {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
        Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar);
        setSupportActionBar(toolbar);

        button = (Button) findViewById(R.id.button_calculate);
        textView1 = (TextView) findViewById(R.id.textView_day);
        textView2 = (TextView) findViewById(R.id.textView_year);
        spinner = (Spinner) findViewById(R.id.spinner_month);
        spinner2 = (Spinner) findViewById(R.id.spinner_day);
        editText = (EditText) findViewById(R.id.editText_year);

        adapter = ArrayAdapter.createFromResource(this,R.array.months,android.R.layout.simple_spinner_item);
        adapter.setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item);
        spinner.setAdapter(adapter);

        adapter = ArrayAdapter.createFromResource(this,R.array.day,android.R.layout.simple_spinner_item);
        adapter.setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item);
        spinner2.setAdapter(adapter);

        if (spinner2.getSelectedItemPosition() == 0)
            value = 1;
        if (spinner2.getSelectedItemPosition() == 1)
            value = 2;
        if (spinner2.getSelectedItemPosition() == 2)
            value = 3;
        if (spinner2.getSelectedItemPosition() == 3)
            value = 4;
        if (spinner2.getSelectedItemPosition() == 4)
            value = 5;
        if (spinner2.getSelectedItemPosition() == 5)
            value = 6;
        if (spinner2.getSelectedItemPosition() == 6)
            value = 7;
        if (spinner2.getSelectedItemPosition() == 7)
            value = 8;
        if (spinner2.getSelectedItemPosition() == 8)
            value = 9;
        if (spinner2.getSelectedItemPosition() == 9)
            value = 10;
        if (spinner2.getSelectedItemPosition() == 10)
            value = 11;
        if (spinner2.getSelectedItemPosition() == 11)
            value = 12;

        button.setOnClickListener(new View.OnClickListener()
        {
            @Override
            public void onClick(View view)
            {
                String dayOfWeek;
                boolean isValid;

                Calendar c = Calendar.getInstance();
                SimpleDateFormat sdf = new SimpleDateFormat("yyyyMMdd_HHmmss");
                String strDate = sdf.format(c.getTime());
            do
            {
                try
                {
                    String getdate = spinner.getItemAtPosition(position).toString() + value
                            + textView2.getText().toString();
                    Date date = sdf.parse(getdate);
                }
                catch (ParseException ex)
                {

                }

                isValid = isDateValid(date.getMonth(), date.getDay(), date.getYear());

                if (isValid == false)
                {
                   Toast.makeText(MainActivity.this,"You entered wrong date",Toast.LENGTH_SHORT).show();
                }
            }
            while (isValid == false);

                dayOfWeek = zellerCalc(date.getMonth(), date.getDay(), date.getYear());

                textView1.setText(dayOfWeek);
            }
        });
    }

    @Override
    public boolean onCreateOptionsMenu(Menu menu)
    {
        getMenuInflater().inflate(R.menu.menu_main, menu);
        return true;
    }

    @Override
    public boolean onOptionsItemSelected(MenuItem item)
    {
        int id = item.getItemId();

        if (id == R.id.action_settings)
        {
            return true;
        }

        return super.onOptionsItemSelected(item);
    }
}

Logcat:

02-07 12:32:16.349 3049-3049/com.example.pavle.dayofborn E/AndroidRuntime: FATAL EXCEPTION: main Process: com.example.pavle.dayofborn, PID: 3049 java.lang.NullPointerException at com.example.pavle.dayofborn.MainActivity$2.onClick(MainActivity.java:230) at android.view.View.performClick(View.java:4633) at android.view.View$PerformClick.run(View.java:19270) at android.os.Handler.handleCallback(Handler.java:733) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:136) at android.app.ActivityThread.main(ActivityThread.java:5476) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:515) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1283) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1099) at dalvik.system.NativeStart.main(Native Method)

//Line 230: isValid = isDateValid(date.getMonth(), date.getDay(), date.getYear());

David Crow9-Feb-17 10:02

9-Feb-17 10:02

Seriously? A NullPointerException is being thrown on line 230 because date is null. A simple walkthrough with the debugger would have revealed this. D'Oh! | :doh:

Pavlex49-Feb-17 10:09

9-Feb-17 10:09

I have initialized Date date = new Date(); but now I get application has stopped working and error is still in the same line!!!

Java

try
                    {
                        Date date = new Date();
                        String getdate = spinner.getItemAtPosition(position).toString() + value
                                + textView2.getText().toString();
                        date = sdf.parse(getdate);
                    } catch (ParseException ex)
                    {
                        // handle parsing exception if date string was different from the pattern applying into the SimpleDateFormat contructor
                    }
                    // isDateValid function call
                    isValid = isDateValid(date.getMonth(), date.getDay(), date.getYear());

David Crow9-Feb-17 10:12

9-Feb-17 10:12

Pavlex4 wrote:
I have initialized Date date = new Date();

Which is not the one being passed to isDateValid().

Pavlex49-Feb-17 10:15

9-Feb-17 10:15

So,what should I do?

David Crow9-Feb-17 10:23

9-Feb-17 10:23

Maybe look at (or around) line 12.

Pavlex49-Feb-17 10:32

9-Feb-17 10:32

You mean this "private Date date;" ?

David Crow9-Feb-17 10:36

9-Feb-17 10:36

Correct.

Pavlex49-Feb-17 10:38

9-Feb-17 10:38

What is problem with that line?

Richard MacCutchan9-Feb-17 21:07

Richard MacCutchan

9-Feb-17 21:07

Nothing.

Pavlex49-Feb-17 21:39

9-Feb-17 21:39

I added date = new Date(); to button onclicklistener but when I click button inside app it gets pressed and stays like that and nothing happens!!!

Java

button.setOnClickListener(new View.OnClickListener()
        {
            @Override
            public void onClick(View view)
            {
                String dayOfWeek;
                boolean isValid;

                date = new Date();

                Calendar c = Calendar.getInstance();
                SimpleDateFormat sdf = new SimpleDateFormat("yyyyMMdd_HHmmss");
                String strDate = sdf.format(c.getTime());

Richard MacCutchan9-Feb-17 22:20

Richard MacCutchan

9-Feb-17 22:20

You really need to make more effort to do some debugging of your code first. You have a problem which could be caused by any part of your code, so you need to do the troubleshooting to collect more information. Also you have a try/catch block in your code that reads:

Java

try
    {
        String getdate = spinner.getItemAtPosition(position).toString() + value
                + textView2.getText().toString();
        Date date = sdf.parse(getdate);
    }
    catch (ParseException ex)
    {

    }

Do not do this, you are just hiding any problems that may occur. Put some proper code in the catch block to help you find errors.

David Crow10-Feb-17 2:08

10-Feb-17 2:08

Can you not see that you have two Date objects (in separate scopes)?

Mobile and o/s application development

Richard MacCutchan10-Feb-17 2:46

Richard MacCutchan

10-Feb-17 2:46

Why check your own code when you can get it done for free at CodeProject? Poke tongue | ;-P

JimmiJames337-Feb-17 5:42

JimmiJames33

7-Feb-17 5:42

Where can I take my application and O/S program ideas too?

Re: Mobile and o/s application development

David Crow7-Feb-17 6:15

7-Feb-17 6:15

For the purpose of what? Confused | :confused:

Android Popup Window

Pavlex42-Feb-17 8:09