C#

auting82 wrote:

What are the real time requirements of this application?

 class Program
    {
        static void Main(string[] args)
        {           
         
            RunAsync().GetAwaiter().GetResult();
            Environment.Exit(0);
        }

static async Task RunAsync()
        {
            string httpReasonStatus = string.Empty;
            int reasoncode;

            using (var client = new HttpClient())
            {
                string baseURL = ConfigurationManager.AppSettings["APIURL"].ToString().Trim();
                client.BaseAddress = new Uri(baseURL);
                //client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("OAuth","xyz");
                client.DefaultRequestHeaders.Accept.Clear();
                client.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));

                Console.WriteLine("Get");
                HttpResponseMessage response = await client.GetAsync("/api/SendBulkSMS");
                if (response.IsSuccessStatusCode)
                {
                    reasoncode = (int)response.StatusCode;
                    httpReasonStatus = response.ReasonPhrase;

                }
                else
                {
                    reasoncode = 0;
                    httpReasonStatus = "error";

                }

            }
        }
    }

static class Program
{
    static async Task<int> Main()
    {
        string baseURL = ConfigurationManager.AppSettings["APIURL"].Trim();
        if (!Uri.TryCreate(baseURL, UriKind.Absolute, out var baseAddress))
        {
            Console.Error.WriteLine("Invalid API URL: '{0}'", baseURL);
            return -1;
        }
        
        using (var client = new HttpClient())
        {
            client.BaseAddress = baseAddress;
            client.DefaultRequestHeaders.Accept.Clear();
            client.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
            
            Console.WriteLine("Get");
            using (var response = await client.GetAsync("/api/SendBulkSMS"))
            {
                Console.WriteLine("{0}: {1}", response.StatusCode, response.ReasonPhrase);
                
                if (response.IsSuccessStatusCode) return 0;
                return (int)response.StatusCode;
            }
        }
    }
}

• Since C# 7.1, you can make the Main method async.
• You can return the exit code directly, rather than using Environment.Exit.
• You should avoid throwing an exception if the URL in the config file is invalid.
• You should wrap the HttpResponseMessage in a using block.
• There's no point in the reasoncode and httpReasonStatus variables, since you never use them.
• Console applications should generally return 0 if they succeed, and non-zero if they fail. The non-successful HTTP status code looks like a good candidate here.

Exoskeletor wrote:

but it's not working and i'm guessing it is not working because you cannot query with parameter "Images", in the database is stored as a blob. So im guessing i have to convert List to something else that is more easily supported in sqlite.

Exoskeletor wrote:

In my application every template has 5 images, but this might change in the future. What is the correct approach according to DB design, to have a TemplateImage object with 5 images or to have only one image for every TemplateImage object like this:

Bastard Programmer from Hell
If you can't read my code, try converting it here[^]
"If you just follow the bacon Eddy, wherever it leads you, then you won't have to think about politics." -- Some Bell.

Exoskeletor wrote:

i would have to retrieve all the images and check them one by one

 public static int GetSequenceHashCode<T>(this IList<T> sequence)
        {
            const int seed = 487;
            const int modifier = 31;

            unchecked
            {
                return sequence.Aggregate(seed, (current, item) =>
                    (current * modifier) + item.GetHashCode());
            }
        }
public static void AddTemplate(int category, List<int> images)
        {
var tmpl = new Template()
            {
                Category = category,
            };
            var img1 = new TemplateImage()
            {
                Category = category,
                Image = images[0],
            };
            var img2 = new TemplateImage()
            {
                Category = category,
                Image = images[1],
            };
            var img3 = new TemplateImage()
            {
                Category = category,
                Image = images[2],
            };
            var img4 = new TemplateImage()
            {
                Category = category,
                Image = images[3],
            };
            var img5 = new TemplateImage()
            {
                Category = category,
                Image = images[4],
            };
            tmpl.TemplateImages = new List<TemplateImage>() { img1, img2, img3, img4, img5 };
            tmpl.ImagesHash = tmpl.TemplateImages.GetSequenceHashCode();
            var result = DatabaseHelper.db().Query<Template>("Select * From Templates where ImagesHash=?", tmpl.ImagesHash).ToList();
            if (result.Count == 0)
            {
                DatabaseHelper.db().InsertAll(tmpl.TemplateImages);
                DatabaseHelper.db().Insert(tmpl);
                DatabaseHelper.db().UpdateWithChildren(tmpl);

                var employeeStored = DatabaseHelper.db().GetWithChildren<Template>(tmpl.Id);
            }

var result = DatabaseHelper.db().Query<TemplateImage>("Select * from TemplateImages where Image=?", images[0]).Count +
     DatabaseHelper.db().Query<TemplateImage>("Select * from TemplateImages where Image=?", images[1]).Count +
      DatabaseHelper.db().Query<TemplateImage>("Select * from TemplateImages where Image=?", images[2]).Count +
       DatabaseHelper.db().Query<TemplateImage>("Select * from TemplateImages where Image=?", images[3]).Count +
        DatabaseHelper.db().Query<TemplateImage>("Select * from TemplateImages where Image=?", images[4]).Count;


    ;//.ToList();
if (result.Count == 5)

Exoskeletor wrote:

however the GetSequenceHashCode doesnt work as expected, it gives different results on every run, so i will have to check with another code.

Exoskeletor wrote:

But looks very bad to me, will this have impact on performance? is there any other way for the same result?

Bastard Programmer from Hell
If you can't read my code, try converting it here[^]
"If you just follow the bacon Eddy, wherever it leads you, then you won't have to think about politics." -- Some Bell.