|
Off topic, but why do you keep putting your messages in text tags?
Social Media - A platform that makes it easier for the crazies to find each other.
Everyone is born right handed. Only the strongest overcome it.
Fight for left-handed rights and hand equality.
|
|
|
|
|
Hi Guys,
I'm trying to write 100 Doors Kata using TDD. I have created the logic like below
But not sure from where I should start to write the Test. I've written 2 test cases like
[TestMethod]
public void TestIfAllDoorsAreClosedAtBiginning()
{
bool[] result = _100DoorsKata.CheckDoorState(0);
for (int i = 1; i <= 100; i++)
{
Assert.IsFalse(result[i]);
}
}
[TestMethod]
public void TestIfAllDoorsAreOpenedAfterFirstRound()
{
bool[] result = _100DoorsKata.CheckDoorState(1);
for (int i = 1; i <= 100; i++)
{
Assert.IsTrue(result[i]);
}
}
And code seems to be:
public bool[] CheckDoorState(int pass)
{
bool[] doors = new bool[101];
for (int i = 1; i <= 100; i++)
{
if (pass == 0)
{
doors[i] = false;
}
else
{
doors[i] = true;
}
}
return doors;
}
Can someone please help me to complete it.
Thanks
modified 18-Mar-20 11:37am.
|
|
|
|
|
IMO it's a bit impractical to use TDD here since you should have a test case for every door, which means having 100 cases.
What you can do to reduce number of test cases is to use test oracle technique. You implement the simplest algorithm possible and compare your solution to output it renders. For example
public static void OracleImplementation(bool[] doors)
{
for (int p = 0; p < 100; p++)
{
for (int d = 0; d < 100; d++)
{
if ((d + 1) % (p + 1) == 0)
{
doors[d] = !doors[d];
}
}
}
}
[Fact]
public void Test()
{
var a = new bool[100];
OracleImplementation(a);
var b = new bool[100];
YourCleverImplementation(b);
b.Should().Equal(a);
}
Note that I've used here a rough sketch of what FluentAssertions do. It may be incomplete tho.
Now in YourCleverImplementation you can come up with more witty solution i.e. select all perfect squares from 1 to 100 and just set your array items to true at indices that are perfect square - 1.
Alternatively, you can use this approach as a test oracle and come up with one more implementation.
I'll leave the rest up to you
|
|
|
|
|
good evening gentlemen and thank you to you who brought me help but I am continuing my project and I have a problem retrieving info from one table to insert it into another.
I have three tables which are related
1.product (article_ID, design, price_U, Qty)
2.order (com_number, com_date, com_amount)
3.detail_command (num_det, num_com, ID_article, qute_det)
I can't fill the detail_commende table. It must be said that I am lost. can you put me on the track please
I may have made a serious mistake in my codes.
private void BtnValider_Click(object sender, EventArgs e)
{
DialogResult dialogResult = MessageBox.Show("Voulez vous valider la facture?", "VALIDATION DE LA FACTURE", MessageBoxButtons.YesNo);
if (dialogResult == DialogResult.Yes)
{
try
{
setConnection();
sql_con.Open();
using (OleDbCommand cmd1 = sql_con.CreateCommand())
{
cmd1.CommandText = "INSERT INTO Commandes (montant_com) VALUES (@montant_com)";
cmd1.Parameters.AddWithValue("@montant_com", TxtTotalCmd.Text);
cmd1.ExecuteNonQuery();
}
long Qte_prod, numCmd;
string ref_prod;
using (OleDbCommand cmd2 = sql_con.CreateCommand())
{
cmd2.CommandText = "SELECT MAX(num_com) AS dernier_num FROM Commandes";
object result = cmd2.ExecuteScalar();
if (result is null || Convert.IsDBNull(result))
{
numCmd = 0;
}
else
{
numCmd = Convert.ToInt64(result);
TxtNunCmd.Text = numCmd.ToString();
for (int i = 0; i < dataGridView1.Rows.Count; i++)
{
ref_prod = Convert.ToString(dataGridView1.Rows[i].Cells[0].Value);
Qte_prod = Convert.ToInt64(dataGridView1.Rows[i].Cells[1].Value);
using (OleDbCommand cmd3 = sql_con.CreateCommand())
{
cmd3.CommandText = "INSERT INTO * Detail_commandes (com_det, ref_det, qute_det) VALUES (@com_det,@ref_det,@qute_det)";
cmd3.Parameters.AddWithValue("@com_det", TxtNunCmd.Text);
cmd3.Parameters.AddWithValue("@ref_det", ref_prod);
cmd3.Parameters.AddWithValue("@qute_det", Qte_prod);
cmd3.ExecuteNonQuery();
}
using (OleDbCommand cmd4 = sql_con.CreateCommand())
{
setConnection();
cmd4.CommandText = "UPDATE Catalogue SET Quantite = Quantite - (@Qte_cmd) WHERE code_article = (@code_article)";
cmd4.Parameters.AddWithValue("@Qte_cmd", Qte_prod);
cmd4.Parameters.AddWithValue("@code_article", TxtRefProduit.Text);
cmd4.ExecuteNonQuery();
}
}
sql_con.Close();
SupDetail_Temp();
TxtTotalCmd.Text = "";
}
}
}
catch (Exception ex)
{
MessageBox.Show(ex.ToString());
sql_con.Close();
}
}
else if (dialogResult == DialogResult.No)
{
}
}
|
|
|
|
|
First off, you cannot assume that the last INSERT you did is the last INSERT done by the system - if you have multiple users then their INSERTS can happen at any time. So instead of a separate SELECT to return the maximum value issue a combination command which does the INSERT and returns the value of the IDENTITY field:
INSERT INTO ...; SELECT SCOPE_IDENTITY(); And it will return the IDENTITY vlaue associated with your INSERT as a scalar value.
This is assuming that the commandes table you speak of is actually the detail_command you describe at the top of your question - but if it isn't, then that would explain why you are having trouble with getting it to work ...
Oh, and BTW: I think we've mentioned that you shouldn't recycle SqlConnections before - create them in a using block and they will be Disposed correctly when you are finished with them.
If you must faff with them like you are, then don't close the connection in the main code and the catch block - add a finally block to your try and close it there.
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
thank you for your answer but I wanted to point out that (num_com) is auto-incremente. I would like to know if that doesn't count?
|
|
|
|
|
Yes, that's the whole point. That is what an IDENTITY field in SQL Server is.
And when you use autoincremented fields you can't rely on the MAX value to be the one you inserted: you do your INSERT, then two dozen other users add their own before you issue your SELECT. YOur MAX then fetches the ID for a totally different row, and you start to get intermittent problems that are fiendishly difficult to duplicate, track down, fix, and prove.
Using SCOPE_IDENTITY returns the last autoincremented value used by that connection, and will never return values from different users.
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
OK well sir and I just found her in my research, are I adapting well to my code?
using (OleDbCommand cmd1 = sql_con.CreateCommand ())
{
cmd1.CommandText = "INSERT INTO Orders (amount_com) VALUES (@montant_com)";
cmd1.CommandText = "SELECT @@ IDENTITY";
int id = Convert.ToInt32 (cmd1.ExecuteScalar ());
cmd1.Parameters.AddWithValue ("@ amount_com", TxtTotalCmd.Text);
cmd1.ExecuteNonQuery ();
}
|
|
|
|
|
Stop guessing. Start thinking.
Look at your code and tell me what is wrong with it.
Where have we seen that problem before?
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
Ok my apologies, this is the error I get
System.Data.Oledb.Ole Exception (0x80040E14): Character found after the end of the Sql instruction
using (OleDbCommand cmd1 = sql_con.CreateCommand())
{
cmd1.CommandText = "INSERT INTO Commandes (montant_com) VALUES (@montant_com);" + "SELECT SCOPE_IDENTITY()";
int id;
cmd1.Parameters.AddWithValue("@montant_com", TxtTotalCmd.Text);
cmd1.ExecuteNonQuery();
id = (int)cmd1.ExecuteScalar();
TxtNunCmd.Text = id.ToString();
}
|
|
|
|
|
That's better!
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
OK, the edited version makes a little more sense.
You need to split your command into two: Do the INSERT, then build a new Command to do the SELECT (some DB engines don't like command chaining). As long as you use the same connection and you don't close it in between the INSERT and SELECT, you'll be fine.
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
I just did it but I have an error: the function 'SCOPE_IDENTITY' not defined in the expression
using (OleDbCommand cmd1 = sql_con.CreateCommand())
{
cmd1.CommandText = "INSERT INTO Commandes (montant_com) VALUES (@montant_com)";
cmd1.CommandText = "SELECT SCOPE_IDENTITY()";
cmd1.Parameters.AddWithValue("@montant_com", TxtTotalCmd.Text);
cmd1.ExecuteNonQuery();
int id = Convert.ToInt32(cmd1.ExecuteScalar());
TxtNunCmd.Text = id.ToString();
}
|
|
|
|
|
and I wanted to clarify that I am on an access database
|
|
|
|
|
Ah. That makes a difference.
Access doesn't support SCOPE_IDENTITY: You need to use @@IDENTITY instead.
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
it’s already done sir but what I don't understand textbox does not recover the id, it displays zero
using (OleDbCommand cmd1 = sql_con.CreateCommand())
{
cmd1.CommandText = "INSERT INTO Commandes (montant_com) VALUES (@montant_com)";
cmd1.CommandText = "SELECT @@IDENTITY";
cmd1.Parameters.AddWithValue("@montant_com", TxtTotalCmd.Text);
cmd1.ExecuteNonQuery();
id = (int)cmd1.ExecuteScalar();
TxtNunCmd.Text = id.ToString();
}
|
|
|
|
|
Do you know what the wonderful thing about banging your head on the desk is?
Desk *BANG*
Desk *BANG*
Desk *BANG*
Desk *BANG*
Desk *BANG*
Desk *BANG*
It feels wonderful when you stop ...
We've been here before. Yesterday in fact.
Look at your code. What can you see that is wrong?
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
:doh: :doh: :doh: :doh: you are right sir and I promise you find the solution and you ride it
|
|
|
|
|
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
it probably is too early to stop.
|
|
|
|
|
You had to say that, didn't you?
Desk *BANG*
Desk *BANG*
Desk *BANG*
...
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
yes yes sir I am still looking for, I will find it, I assure you sir
|
|
|
|
|
using (OleDbCommand cmd1 = sql_con.CreateCommand())
{
cmd1.CommandText = "INSERT INTO Commandes (montant_com) VALUES (@montant_com)";
OleDbCommand cmr = sql_con.CreateCommand();
cmr.CommandText = "SELECT @@IDENTITY AS LastId";
cmd1.Parameters.AddWithValue("@montant_com", TxtTotalCmd.Text);
id = (int)cmr.ExecuteScalar();
TxtNunCmd.Text = id.ToString();
cmd1.ExecuteNonQuery();
}
but i can't get the id
|
|
|
|
|
Stop guessing, and start thinking.
When is the ID actually created? What line of code causes that to happen?
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
Hello sir and all my excuses for yesterday I had a connection problem that's why I disconnected but by dint of fighting all night I could find the solution regaré and tell me if the code is clean. I must say I am glad I did ...
using (OleDbCommand cmd1 = sql_con.CreateCommand())
{
cmd1.CommandText = "INSERT INTO Commandes (montant_com) VALUES (@montant_com)";
cmd1.Parameters.AddWithValue("@montant_com", TxtTotalCmd.Text);
cmd1.ExecuteNonQuery();
OleDbCommand cmr = sql_con.CreateCommand();
cmr.CommandText = "SELECT @@IDENTITY AS LastId";
int LastId = Convert.ToInt32(cmr.ExecuteScalar());
TxtNunCmd.Text = LastId.ToString();
}
|
|
|
|