|
I just started learning Unity a few days ago, and I have found a very helpful tutorial on how to make a game. However, I keep getting this error and I have tried everything to figure out why its occurring. Maybe someone can take a look at the code and help me out? Thanks!
The error is on the line "DialogueSystem.Instance.AddNewDialogue (dialogue);"
And the full error is "No overload for method 'AddNewDialogue' takes '1' arguments"
using System.Collections;
using System.Collections.Generic;
using UnityEngine;
public class NPC : Interactable {
public string[] dialogue;
public string name;
public override void Interact()
{
DialogueSystem.Instance.AddNewDialogue (dialogue);
Debug.Log ("Interacting with NPC.");
}
}
|
|
|
|
|
Use IntelliSense: Remove and re-type the opening brace after AddNewDialogue and Visual Studio will show you a pop-up with all valid signatures of that method(name). And most likely there actually will be none with only one argument.
If your tutorial suggests otherwise then you're probably missing a using-declaration or an assembly reference. If it's the former then Visual Studio should show a "Quick Actions and Refactorings"-tooltip when hovering over AddNewDialogue that allows you to have the using-declaration added. Otherwise look through the tutorial for instructions on which assemblies to reference.
If the brain were so simple we could understand it, we would be so simple we couldn't. — Lyall Watson
|
|
|
|
|
Thanks! That did the trick
|
|
|
|
|
I'm writing a C# WinForms project that uses DotNetZip. Here's the step-by-step to save a file:
1. Write the file to a temp file using FileStream and BinaryWriter...
glbstrSaveFilePath = strfilepath;
string strTempPath = Path.GetTempFileName();
Path.ChangeExtension(strTempPath, ".bin");
FileStream fs = new FileStream(strTempPath, FileMode.Create, FileAccess.Write);
BinaryWriter bw = new BinaryWriter(fs);
bw.Write(somestring);
bw.Write(someboolean);
bw.Write(someotherstring);
2. Next, I use DotNetZip to compress it and save it to the location from the SaveFileDialog...
using (ZipFile zip = new ZipFile())
{
Path.ChangeExtension(strTempPath, ".bin");
zip.AddFile(strTempPath, "MyProject");
zip.Save(strfilepath);
}
The file seems to be compressing and saving correctly because I can open the resulting file in 7-Zip and then read the "MyProject" file. Everything looks OK.
Here's where the problem occurs. To open the file I do...
1. Extract the file from its location using DotNetZip...
ZipFile zip = ZipFile.Read(strfilepath);
Directory.CreateDirectory(strTempPath);
Path.ChangeExtension(strTempPath, ".bin");
foreach (ZipEntry e in zip)
{
if (e.FileName == "MyProject")
e.Extract(strTempPath, ExtractExistingFileAction.OverwriteSilently);
}
2. Next, I open the temp file (strTempPath) using FileStream and BinaryReader...
FileStream fs = new FileStream(strTempPath, FileMode.Open, FileAccess.Read);
BinaryReader br = new BinaryReader(fs);
strStringOne = br.ReadString();
blBooleanOne = br.ReadBoolean();
strStringTwo = br.ReadString();
Unfortunately, steps 1 and 2 above don't seem to execute. I'm at a loss to find out why. Is there anything wrong with the code in Step 1?
|
|
|
|
|
I haven't used DotNetZip yet but there are some things catching my eye, the first one most likely being the culprit (even though "don't seem to execute" isn't very specific  ).
This:
Path.ChangeExtension(strTempPath, ".bin"); ..does nothing for you. You most probably intended this:
strTempPath = Path.ChangeExtension(strTempPath, ".bin"); Strings are immutable. When using a method that "modifies" a string you always have to use the returned version.
Most probably this line fails then:
e.Extract(strTempPath, ExtractExistingFileAction.OverwriteSilently); ..because strTempPath is still the name of the directory.
Other observations:
You're not enclosing your streams in using-blocks. Probably not the cause of your problem here but I strongly advise you to always do that. I've seen funny things happening when not doing that, which do not always immediately reveal themselves as stream issues and send you on a wild goose chase.
Don't use the same variable once for a directory name and then for a file name. It was confusing to read and I bet it will confuse you too, when you read your code again after doing different stuff for a while.
And a style suggestion: Don't use Systems Hungarian. It's not recommended by Microsoft, for a good reason, I think. If you're interested: Making Wrong Code Look Wrong – Joel on Software[^]
If the brain were so simple we could understand it, we would be so simple we couldn't. — Lyall Watson
|
|
|
|
|
Also take into account that string strTempPath = Path.GetTempFileName(); creates the file on disc already - you should remove it afterwards.
Or create the temp filename your self, e.g.
string tempPath = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString() + ".bin");
Oh sanctissimi Wilhelmus, Theodorus, et Fredericus!
|
|
|
|
|
Thank you all for taking your time to help.
Had an issue with adding in music files, now that is resolved. However the path to the music files is in a certain sequence. I tried to move that sequence by using remove and insert however that removes the path to the file so when I click on the file I want to play, it doesn't play. Below is the code I have just for up button. So How can I move an item in the 'path' list to move without removing it?
public partial class JukeBox : Form
{
private readonly List<string> paths = new List<string>();
public JukeBox()
{
InitializeComponent();
}
private void btnFiles_Click(object sender, EventArgs e)
{
OpenFileDialog openFileDialog1 = new OpenFileDialog();
openFileDialog1.Multiselect = true;
if (openFileDialog1.ShowDialog() == System.Windows.Forms.DialogResult.OK)
{
paths.AddRange(openFileDialog1.FileNames);
string[] files = openFileDialog1.SafeFileNames;
for (int i = 0; i < files.Length; i++)
{
listBox1.Items.Add(files[i]);
}
}
}
private void btnPlay_Click(object sender, EventArgs e)
{
axWindowsMediaPlayer1.URL = paths[listBox1.SelectedIndex];
}
private void btnUp_Click(object sender, EventArgs e)
{
if (listBox1.SelectedItems.Count > 0)
{
object selected = listBox1.SelectedItem;
string lbName = listBox1.GetItemText(listBox1.SelectedItem);
int lbIndex = listBox1.Items.IndexOf(selected);
int lbTotal = listBox1.Items.Count;
int pathIndex = paths.IndexOf(lbName);
if (lbIndex == 0)
{
paths.Remove(lbName);
paths.Insert(lbTotal - 1,lbName);
listBox1.Items.Remove(selected);
listBox1.Items.Insert(lbTotal - 1, selected);
listBox1.SetSelected(lbTotal - 1, true);
}
else
{
paths.Remove(lbName);
paths.Insert(lbIndex - 1, lbName);
listBox1.Items.Remove(selected);
listBox1.Items.Insert(lbIndex - 1, selected);
listBox1.SetSelected(lbIndex - 1, true);
}
}
}
|
|
|
|
|
|
Richard,
The reason for this layout, I've tried a lot of ways to add music files to a listbox than add some more files and they wouldn't play due to out of range error. With this layout it allows me to add music files to my list box and if I want to add some more I can.
Thank you
|
|
|
|
|
Yes, except it still does not work. And if you get of range errors you need to diagnose the problem and fix your code rather than just ignoring it.
|
|
|
|
|
Richard,
Coming to this site doesn't mean that I was ignoring the problem, one cannot complete a task if they ignore the problems. Me coming to this site was me asking for help for an issue that I've been trying to fix for some time. I kindly ask, if you cannot help with the issue please don't reply again.
Thank you
|
|
|
|
|
Well I did try to help, by suggesting a class that would make your application much easier to manage. But if you want to dismiss it out of hand that is fine with me.
|
|
|
|
|
For your Info (if you don't know it) : with Richard you got one of the most famous members of this forum. I would suggest that you try to understand what he has suggested to you :
You can also create a Class which contains different information. This Class could be added as well to your ListBox and allows you to do what you are missing in the moment. Perhaps you re-think this ...
|
|
|
|
|
|
Member 13489244 wrote: OpenFileDialog openFileDialog1
Perhaps there is an incorrect assumption here.
If you get a list of files from a file dialog you cannot "move" anything.
That list of files represent real resources on the OS. If you want to move a file (not an entry in the list) then you must move it. And the only way you can "move" it is by changing the directory.
If you want to change the order in a directory you must rename it.
And regardless of what you are doing if you modify the file name or location then you need to requery the OS for an updated list of files. You shouldn't attempt to modify the list yourself.
Alternatively perhaps you want to order the list based on criteria that the OS does not know about. That however is much more complicated and it REQUIRES that you store files and the additional data is some persistent data store (file, database, etc.) You would then load that, load the current file list from the OS, correlate the two and then with a brand new list that you created manage the files themselves and associated data for each file. On exit you would then update your persistent data store with changes.
|
|
|
|
|
Use an ObservableCollection as the data source for your listbox.
ObservableCollection has a "move" command:
.Move( oldIndex, newIndex )
"(I) am amazed to see myself here rather than there ... now rather than then".
― Blaise Pascal
|
|
|
|
|
Than you for taking the time to look over my problem.
I'm trying to make a playlist in c# that will allow me to play music. Below is the code that I have so far. I have the ability to add files from a fold and play they on the media player. However the issue is when I add additional music files is gives me an error message that reads IndexOutOfRange. So my question is: How can I add music files to a listbox than add some mote music files and be able to play them?
public MusicBox()
{
InitializeComponent();
}
private void btnFiles_Click(object sender, EventArgs e)
{
OpenFileDialog openFileDialog1 = new OpenFileDialog();
openFileDialog1.Multiselect = true;
if (openFileDialog1.ShowDialog() == System.Windows.Forms.DialogResult.OK)
{
files = openFileDialog1.SafeFileNames;
paths = openFileDialog1.FileNames;
for (int i = 0; i < files.Length; i++)
{
listBox1.Items.Add(files[i]);
}
}
}
private void btnPlay_Click(object sender, EventArgs e)
{
axWindowsMediaPlayer1.URL = paths[listBox1.SelectedIndex];
}
|
|
|
|
|
Use the debugger: check the value of listBox1.SelectedIndex and the number of items in paths
Either listBox1.SelectedIndex will be too big, or it will be negative.
Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
You're appending the new files to the list, but replacing the paths variable with the new paths.
So, for example, if you've already selected files A, B and C:
List = { A, B, C }
Paths = { A, B, C }
and you then select D and E:
List = { A, B, C, D, E }
Paths = { D, E }
if you try to play A, you'll get D; if you try to play B, you'll get E; if you try to play anything else, you'll get an IndexOutOfRangeException.
If you want to replace the list of files, you'll need to call listBox1.Items.Clear() before adding the new files.
If you want to append the list of files, you'll need to append them to the paths list as well. The simplest option would probably be to change it to be a List<string> instead of an array:
private readonly List<string> paths = new List<string>();
private void btnFiles_Click(object sender, EventArgs e)
{
OpenFileDialog openFileDialog1 = new OpenFileDialog();
openFileDialog1.Multiselect = true;
if (openFileDialog1.ShowDialog() == System.Windows.Forms.DialogResult.OK)
{
paths.AddRange(openFileDialog1.FileNames);
string[] files = openFileDialog1.SafeFileNames;
for (int i = 0; i < files.Length; i++)
{
listBox1.Items.Add(files[i]);
}
}
}
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
Richard Deeming ,
You sir are my hero!!! Thank you so much
|
|
|
|
|
Never use "SelectedIndex" unless you know its value first.
The default is "-1"; which means "not selected"; and always results in an invalid index.
(And SelectedIndex will "bounce around" prior to a form / window being fully loaded).
Just because a "list control" has items, does not mean that SelectedIndex is "in range".
That also goes for "SelectedItem", "CurrentItem", "Position", etc. when dealing with "lists" and navigation.
"(I) am amazed to see myself here rather than there ... now rather than then".
― Blaise Pascal
|
|
|
|
|
Hello,
I am new to C# and has been assigned a task to modify a code.
One of our Reporting Tool is fetching the data from our Historian server and generating the report in excel format. But time taken for the generation of each report is around 15-20 mins depending upon the size of data. But this time should be less.
So, the developer of the Tool told us to try by our own exporting the data to .csv format. I tried it and changed the format to .csv but the time did not reduced.
I am attaching the part of our code:
private void export_to_excel(string template)
{
try
{
Microsoft.Office.Interop.Excel.Application excelApp = new Microsoft.Office.Interop.Excel.Application();
Microsoft.Office.Interop.Excel.Workbook excelWorkBook = excelApp.Workbooks.Open(path + "Report.xltx");
Microsoft.Office.Interop.Excel.Worksheet excelWorkSheet = (Microsoft.Office.Interop.Excel.Worksheet)excelWorkBook.Sheets["Report"];
string excelfile = IniReadValue("TemplateDetails", "ExpPath", SlTemplate.Text) + template +"_" + Fdt.Text.Replace('/', '_').Replace('-', '_').Replace(' ', '_').Replace(':', '_') + ".xlsx";
object misValue = System.Reflection.Missing.Value;
Microsoft.Office.Interop.Excel.Range range;
int j = 0, k = 0, i = 0, l = 0,m=0;
for (k = 0; k < dt.Rows.Count; k++)
{
i = 0;
for (j = 0; j < dt.Columns.Count; j++)
{
if (stat == false)
{
excelWorkSheet.Cells[9 + k, j + 2] = dt.Rows[k].ItemArray[j].ToString();
}
else
{
if(j==0)
{
excelWorkSheet.Cells[9 + k, i + 2] = dt.Rows[k].ItemArray[j].ToString();
}
else if(dt.Columns[j].ColumnName.Contains("C"))
{
excelWorkSheet.Cells[9 + k, i + 3] = dt.Rows[k].ItemArray[j].ToString();
if (dt.Columns.Contains("C" + i.ToString()))
{
if (dt.Rows[k]["S" + i.ToString()].ToString().ToUpper() != "GOOD" & (dt.Rows[k]["S" + i.ToString()].ToString() != ""))
{
range = excelWorkSheet.get_Range(Number2String(9 + k) + (k + 9).ToString(), Number2String(i + 3) + (k + 9).ToString());
range.Cells.Font.Color = Microsoft.Office.Interop.Excel.XlRgbColor.rgbRed;
}
}
i++;
}
}
}
}
excelApp.DisplayAlerts = false;
for (m = 4; m < ((j + 3)/2); m++)
{
if (m < j + 1)
{
if (excelWorkSheet.Cells[9, m].Value.ToString() == excelWorkSheet.Cells[9, m + 1].Value.ToString())
{
l++;
}
else
{
if (l > 0)
{
range = excelWorkSheet.get_Range(Number2String(m - l) + "9", Number2String(m) + "9");
range.Merge();
range.HorizontalAlignment = Microsoft.Office.Interop.Excel.XlHAlign.xlHAlignCenter;
}
l = 0;
}
}
else
{
if (l > 0)
{
range = excelWorkSheet.get_Range(Number2String(m - l) + "9", Number2String(m) + "9");
range.Merge();
}
l = 0;
}
}
excelWorkSheet.Cells[5, 5] = IniReadValue("TemplateDetails", "Substation", SlTemplate.Text);
excelWorkSheet.Cells[6, 5] = IniReadValue("TemplateDetails", "Region", SlTemplate.Text);
excelWorkSheet.Cells[7, 5] = Fdt.Text;
string alph = "A";
if(stat==false)
{
alph = Number2String(j + 1);
}
else
{
alph = Number2String(Convert.ToInt16(Math.Abs(Convert.ToDouble((j + 4) / 2))));
}
range=excelWorkSheet.get_Range("B9", alph + (dt.Rows.Count + 8).ToString());
range.Borders.LineStyle = Microsoft.Office.Interop.Excel.XlLineStyle.xlContinuous;
range = excelWorkSheet.get_Range("C12", alph + (dt.Rows.Count + 3).ToString());
range.NumberFormat = "General";
excelWorkSheet.Cells[12 + k, 1] = "Remarks:";
range = excelWorkSheet.get_Range("A"+(12 + k).ToString() ,"E"+ (14 + k).ToString());
range.Merge();
for (j = 0; j < pntid.Count; j++)
{
excelWorkSheet.Cells[49+j, 2] = DGSet[j];
excelWorkSheet.Cells[49+j, 3] = dgval[j];
excelWorkSheet.Cells[49+j, 2].Interior.Color = System.Drawing.ColorTranslator.ToOle(System.Drawing.Color.Yellow);
excelWorkSheet.Cells[49+j, 3].Interior.Color = System.Drawing.ColorTranslator.ToOle(System.Drawing.Color.Yellow);
}
range = excelWorkSheet.get_Range("B49", "C"+ (49+j-1).ToString());
range.Borders.LineStyle = Microsoft.Office.Interop.Excel.XlLineStyle.xlContinuous;
range.VerticalAlignment = Microsoft.Office.Interop.Excel.XlHAlign.xlHAlignCenter;
range.HorizontalAlignment = Microsoft.Office.Interop.Excel.XlHAlign.xlHAlignCenter;
range.Cells.WrapText = true;
range = excelWorkSheet.get_Range("B49");
range.EntireColumn.AutoFit();
excelWorkSheet.PageSetup.Orientation = Microsoft.Office.Interop.Excel.XlPageOrientation.xlPortrait;
excelWorkSheet.PageSetup.PaperSize = Microsoft.Office.Interop.Excel.XlPaperSize.xlPaperA3;
Microsoft.Office.Interop.Excel.Worksheet excelWorkSheet1 = (Microsoft.Office.Interop.Excel.Worksheet)excelWorkBook.Sheets["Chart"];
if (graph.Checked == true)
{
Microsoft.Office.Interop.Excel.ChartObject chartObject11 = (Microsoft.Office.Interop.Excel.ChartObject)excelWorkSheet1.ChartObjects(1);
chartObject11.Activate();
Microsoft.Office.Interop.Excel.Chart chartPage = chartObject11.Chart;
range = excelWorkSheet.get_Range("B9", alph + (dt.Rows.Count + 3).ToString());
excelApp.ActiveChart.SetSourceData(range, Microsoft.Office.Interop.Excel.XlRowCol.xlColumns);
excelWorkSheet1.PageSetup.Orientation = Microsoft.Office.Interop.Excel.XlPageOrientation.xlPortrait;
excelWorkSheet1.PageSetup.PaperSize = Microsoft.Office.Interop.Excel.XlPaperSize.xlPaperA3;
}
else
{
excelWorkSheet1.Visible = Microsoft.Office.Interop.Excel.XlSheetVisibility.xlSheetHidden;
}
excelWorkBook.SaveAs(excelfile, Microsoft.Office.Interop.Excel.XlFileFormat.xlOpenXMLWorkbook, misValue, misValue, misValue, misValue, Microsoft.Office.Interop.Excel.XlSaveAsAccessMode.xlExclusive, misValue, misValue, misValue, misValue, misValue);
excelWorkBook.Close();
excelApp.Quit();
releaseObject(excelWorkSheet);
releaseObject(excelWorkBook);
releaseObject(excelApp);
foreach (Process clsProcess in Process.GetProcesses())
{
if (clsProcess.ProcessName.Equals("EXCEL"))
clsProcess.Kill();
}
}
catch (Exception err)
{
fail = fail+1;
ErrorLog(DateTime.Now.ToString() + "----- Export to excel ---" + err.ToString()); ;
}
}
Can anyone please help me getting out of the situation with or without using interop.excel.
Thanks in Advance,
Rohit
|
|
|
|
|
If you do it in the way as showed inside your code you could save it as XLS-File.
Your time comes from using Excel per "remote"-access.
When you want to export your data to a CSV-File you use the Standard-Features from .Net to create a Text-File with the Extension 'CSV'. Different Cells/Entries are seperated with a Comma or Semicolon. This kind of writing data will be very much faster ...
|
|
|
|
|
Thanks Ralf for the reply,
Can you please add the codes (of course if possible) or give some hint to dump to .txt.
Or you can suggest some similar threat.
Thanks,
Rohit
|
|
|
|
|
I suggest you ask Google for this - 'C# write CSV' for example.
Now you will get a lot of Results - you should look by yourself which matches best to your requirement (because I think you must also learn how to use the commands) and how to create the Method you really need ...
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
