C#

JP_Rocks wrote:

I have many constants, each recurring as per country and declared in class as below:

class CountryRequests
{
  public const string JAP_ABC="JAP_012686";
  public const string JAP_PQR="JAP_012457";

enum CountryRequests
{
  JAP_012686,
  JAP_012457
}

JP_Rocks wrote:

What is best coding here

JP_Rocks wrote:

I cannot change from CountryRequests class to collection as it is used by multiple projects.

Bastard Programmer from Hell

public void GetCountryRequestCode(string countryCode)
{
	switch (countryCode)
	{
		Case "JAP":
			return JAP_ABC;
		....
	}
}

JP_Rocks wrote:

I cannot change from CountryRequests class to collection as it is used by multiple projects.

public class CountryRequestsServer : CountryRequests
{
    internal static CountryRequestsServer instanceCRServer;

    internal static Dictionary<string, string> countryLookUp;

    internal CountryRequestsServer()
    {
        countryLookUp = new Dictionary<string, string>()
        {
            {"JAP", JAP_ABC},
            { "USA", US_POP},
            { "UK", ENG_POP}
        };
    }

    public static string getCountry(string request)
    {
        // CTor called here if null
        if(instanceCRServer == null)
        {
            instanceCRServer = new CountryRequestsServer();
        }

        // handle lookup error
        return countryLookUp.ContainsKey(request) 
        ? 
            countryLookUp[request] 
        : 
            "No Match: Input = " + request;        
    }
}

string myCountryRequest = CountryRequestsServer.getCountry("JAP");
// ==> "JAP_012686"

BillWoodruff wrote:

using Reflection ... with great frequency

public class CountryInfo {
 public readonly string ABC, POP, PQR, ...;
 
 private CountryInfo(string abc, string pop, string pqr ...){
  ABC = abc; POP = pop; PQR = pqr;
  // ... etc
 }
 
 public static readonly CountryInfo
   JAP = new CountryInfo(CountryRequests.JAP_ABC, CountryRequests.JAP_POP, CountryRequests.JAP_PQR, ...),
    UK = new CountryInfo(CountryRequests. UK_ABC, CountryRequests. UK_POP, CountryRequests. UK_PQR, ...),
    US = new CountryInfo(CountryRequests. US_ABC, CountryRequests. US_POP, CountryRequests. US_PQR, ...),
   // etc
}

void CountryDependentFunction(CountryInfo countryInfo){
 someFunction(countryInfo.POP);
}

SELECT
    [Serial Number],
    [Failure Code],
    COUNT(*) AS [Counter]
    FROM
        [Failure Codes]
    WHERE
        [Serial Number] = @SerialNumber
    GROUP BY
        [Serial Number],
        [Failure Code]
    ORDER BY
        [Counter] ASC

Member 8069795 wrote:

file I want is being used by another process

Member 8069795 wrote:

doc.Load("Subscription.xml");

//Load and parse tree nodes
defXmlDoc.Load(xmlPath)

TreeView1.Nodes.Clear()

//Ignore root node and add level 1's as multi roots
For Each node As XmlNode In defXmlDoc.DocumentElement.ChildNodes
    AddNode(node, TreeView1.Nodes)
    AddNodeTree(node, TreeView1.Nodes.Item(TreeView1.Nodes.Count - 1))
Next

defXmlDoc = Nothing

Private Sub AddNode(ByVal xmlNode As XmlNode, ByVal NodeCol As TreeNodeCollection)
     Dim id, label, desc As String
     label = xmlNode.Name
     desc = ""
     id = "Unknown"
     If Not xmlNode.Attributes("label") Is Nothing Then
         label = xmlNode.Attributes.GetNamedItem("label").Value
     End If
     If Not xmlNode.Attributes("description") Is Nothing Then
         desc = xmlNode.Attributes.GetNamedItem("description").Value
     End If
     If Not xmlNode.Attributes("id") Is Nothing Then
         id = xmlNode.Attributes.GetNamedItem("id").Value
         If id > maxId Then maxId = id
     End If
     NodeCol.Add(id, label)
     NodeCol(id).Tag = desc
 End Sub

 Private Sub AddNodeTree(ByVal xmlNode As XmlNode, ByVal treeNode As TreeNode)
     Dim i As Integer
     Dim xNode As XmlNode
     Dim tNode As TreeNode
     Dim nodeList As XmlNodeList
     If (xmlNode.HasChildNodes) Then
         nodeList = xmlNode.ChildNodes
         For i = 0 To nodeList.Count - 1
             xNode = xmlNode.ChildNodes(i)
             AddNode(xNode, treeNode.Nodes)
             tNode = treeNode.Nodes(i)
             AddNodeTree(xNode, tNode)
         Next
     Else
         'Leaf
     End If
 End Sub

using (DbDataReader dr = command.ExecuteReader())
{
     while (dr.Read())
     {
          String col1 = dr[1];
     }
}