C#

MacRaider4 wrote:

I'm probably missing something obvious

public BGW()
  {
    this.WorkerReportsProgress = true;
    this.WorkerSupportsCancellation = true;
  }

private void backgroundWorker1_ProgressChanged(object sender, ProgressChangedEventArgs e)
{
    pgbWrite.Value = e.ProgressPercentage;
    lblCurrentCount.Text = e.UserState.ToString();
}

percentComplete = (int)((float)currentMail / (float)intEmail * 100);
if (percentComplete <= highestPercentageReached)
{
    if (percentComplete == 0)
    {
        percentComplete = 1;
    }
    highestPercentageReached = percentComplete + 1;
    string strCounter = currentMail + " of " + intEmail;
    //backgroundWorker1.ReportProgress(percentComplete, strCounter);
    BGWs[0].ReportProgress(percentComplete, strCounter);
}

protected override void OnDoWork(DoWorkEventArgs e)
{
  base.OnDoWork(e);
  WriteMail.WriteAndParseMail(this);
}

highestPercentageReached = percentComplete + 1;
string strCounter = currentMail + " of " + intEmail;
(sender as BackgroundWorker).ReportProgress(percentComplete, strCounter);

MacRaider4 wrote:

(as if it were a bgw perhaps in a thread you can use the variable directally)?

MacRaider4 wrote:

Plus when I was getting into more advanced someone reccomended keeping as little as you can on your main form and using classes for as much as possible. Is this a good habbit, bad habbit or just personal preference?

// This can go in a static class somewhere
public static void SendMessagesAsync(ProgressChangedHandler progressCallback, params SomeClass[] messages)
{
  for (int idx = 0; idx < messages.Length; idx++)
  {
    BackgroundWorker wkr = new BackgroundWorker();
    wkr.WorkerSupportsProgress = true;
    wkr.ProgressChanged += progressCallback;  // This will go back to your main form and display something
    wkr.DoWorkEventArgs += wkr_DoWork;  // This is inside the same static class, below, not part of its public interface
    wkr.RunWorkerAsync(messages[idx]);
  }
}

// All of your workers can use the same DoWork, as long as they're given different arguments
private static void wkr_DoWork(object sender, DoWorkEventArgs e)
{
  BackgroundWorker wkr = sender as BackgroundWorker; // Use this to report progress
  SomeClass args = e.Argument as SomeClass;  // Here's any info you need to pass to the worker

  // ... Do your processing here ... WriteMail, or whatever
}

// And on your form...

private void SomethingCalledFromYourForm()
{
  MyStaticClass.SendMessagesAsync(wkr_ProgressChanged, new SomeClass[] {
    new SomeClass() { Whatever = parameters, YouWant = toset },
    new SomeClass() { Subject = someone, Body = "something else?", Recipient = "someone@somewhere.sometime" }
  });
}

Ian Shlasko wrote:

I wonder if the BackgroundWorker only allows ReportProgress to be called during the DoWork

public void ReportProgress(int percentProgress, object userState)
{
    if (!this.WorkerReportsProgress)
    {
        throw new InvalidOperationException(SR.GetString("BackgroundWorker_WorkerDoesntReportProgress"));
    }
    ProgressChangedEventArgs arg = new ProgressChangedEventArgs(percentProgress, userState);
    if (this.asyncOperation != null)
    {
        this.asyncOperation.Post(this.progressReporter, arg);
    }
    else
    {
        this.progressReporter(arg);
    }
}