C# Discussion Boards - CodeProject

25-Feb-09 3:12

I want to read an image and display its content in PictureBoxes.
The PictureBoxes get added dynamcally to a Panel (or is there a better control to keep them all together?) dpending on the image size.
The PictureBoxes all have a size of 32x32 pixels.

If you ever used an rpg maker, I'm trying to make some map maker wher you can see the source image on the left side, select a tile and then edit the map on the right side with it.

I have 2 problems, first and foremost I added a ScrollBar to the control and to the Controls property of the Panel.
Obviously nothing happens when you scroll, though you are supposed to be able to scroll up and down when the source image is too large to display at once.

How can I get the ScrollBar to make the Panel display a different part of the source image, whenever you scroll?

I thought of clearing the Controls property of the Panel and always just adding the visible PictureBoxes (they all are stored in an extra collection), determining which ones are visible by Panel and PictureBox size.
Though, this would need calculations and have to be pixel-exact, if possible I dould like to avoid this and use a more elegant way.

The second problem is that I have a for loop which is repeated once for image width/32 (8 times, I intend to have a fixed width of 256 pixels) and adds a PictureBox everytime (again, 8).
The problem is that 8.5 PictureBoxes are display in width, the half PictureBox seems to be downscaled version:
http://i43.tinypic.com/snhyjc.jpg[^]

Xmen Real 25-Feb-09 3:19

Re: How to add a ScrollBar where there is none? [modified]

25-Feb-09 3:19

Megidolaon wrote:
I added a ScrollBar to the control and to the Controls property of the Panel.

You dont need to put ScrollBar control in panel, just set AutoScroll Property of panel to True

Megidolaon wrote:
I thought of clearing the Controls property of the Panel and always just adding the visible PictureBoxes (they all are stored in an extra collection), determining which ones are visible by Panel and PictureBox size.Though, this would need calculations and have to be pixel-exact, if possible I dould like to avoid this and use a more elegant way.

Try FlowLayoutPanel

TVMU^P[[IGIOQHG^JSH`A#@`RFJ\c^JPL>;"[,*/|+&WLEZGc`AFXc!L
%^]*IRXD#@GKCQ`R\^SF_WcHbORY87֦ʻ6ϣN8ȤBcRAV\Z^&SU~%CSWQ@#2
W_AD`EPABIKRDFVS)EVLQK)JKSQXUFYK[M`UKs*$GwU#(QDXBER@CBN%
Rs0~53%eYrd8mt^7Z6]iTF+(EWfJ9zaK-iTV.C\y<pjxsg-b$f4ia>
--------------------------------------------------------
128 bit encrypted signature, crack if you can

Megidolaon25-Feb-09 21:23

25-Feb-09 21:23

Thanks, the FlowLayoutPanel is exactly what I need.

Though, the second problem is there, the PictueBoxes have a weird layout and weird images, what confuses me the most is that most of the tme it seems to work, but some seem corrupted.

This is the original image (256 x 2000 pixel):
http://i43.tinypic.com/10qjng4.jpg[^]

This is what the PictureBoxes look like(the black lines are the PictureBoxes' FixedSingle Border):
http://i42.tinypic.com/1677e44.jpg[^]

The code I use to assign the images to the PictureBoxes:

g.DrawImage(resource, new Rectangle(0, 0, 32, 32), 
   new Rectangle(32 * i, 32 * k, 32, 32), GraphicsUnit.Pixel);

Where i is the counter for the height(0-7) and k is the counter for the height (0-63).
I have 2 nested for loops, the outer one for the width and the inner one for the height.
I store the PictureBoxes in a Dictionary<point,picturebox>;. I already checked but I create a new Point for ever PictureBox and the coordinates are unique.

modified on Thursday, February 26, 2009 3:48 AM

Xmen Real 25-Feb-09 23:01

25-Feb-09 23:01

you mean the half gray square is the problem ? if yes then I just noticed something that this is happening after every 8th boxes...in other words its happening at the end of patterned boxes. Its hard to findout problem without seeing code...

Megidolaon25-Feb-09 23:41

25-Feb-09 23:41

ok, this is the code:

for (int i = 0; i <= width; i++)
            {
                for (int k = 0; k <= height; k++)
                {
                    if (i == 7 && k == 15)
                    {
                        this.Text = this.Text;
                    }
                    g = Graphics.FromImage(memory);

                    coordinate = new Point(i, k);
                    pictureboxes.Add(coordinate, new PictureBox());
                    pictureboxes[coordinate].Height = 32;
                    pictureboxes[coordinate].Width = 32;
                    pictureboxes[coordinate].Visible = true;
                    pictureboxes[coordinate].Anchor = AnchorStyles.Left | AnchorStyles.Top;
                    pictureboxes[coordinate].BorderStyle = BorderStyle.FixedSingle;
                    pictureboxes[coordinate].Margin = new Padding(0);

                    pictureboxes[coordinate].Location = new Point(32 * i, 32 * k);

                    pictureboxes[coordinate].MouseDown += new MouseEventHandler(OnLeftDown);
                    pictureboxes[coordinate].MouseDown += new MouseEventHandler(OnRightClick);

                    g.DrawImage(resource, new Rectangle(0, 0, 32, 32), 
                        new Rectangle(32 * i, 32 * k, 32, 32), GraphicsUnit.Pixel);
                    
                    pictureboxes[coordinate].Image = new Bitmap(memory, new Size(32, 32));

                    FLP_Resource.Controls.Add(pictureboxes[coordinate]);
                }

FLP_Resource is the FlowLayoutPanel and pictureboxes is a dictionary[Point, PictureBox] in which I store the PictureBoxes.

Since you can't choose which part of an image is assign to a PictureBox, but can only assign the whole image, I used a Graphics object to draw a certain part of the source image on a memory Bitmap (which I will later resize and use for double buffering).
I first get the desired part of the source image and then assign it to a PictureBox.

Xmen Real 25-Feb-09 23:47

25-Feb-09 23:47

well I really dont understand what you want actually but I'm sure you are making this very complicated. Why you are using Dictionary. You can use List<PictureBox>.

Megidolaon wrote:
Since you can't choose which part of an image is assign to a PictureBox

what that mean ?

TVMU^P[[IGIOQHG^JSH`A#@`RFJ\c^JPL>;"[,*/|+&WLEZGc`AFXc!L
%^]*IRXD#@GKCQ`R\^SF_WcHbORY87֦ʻ6ϣN8ȤBcRAV\Z^&SU~%CSWQ@#2
W_AD`EPABIKRDFVS)EVLQK)JKSQXUFYK[M`UKs*$GwU#(QDXBER@CBN%
Rs0~53%eYrd8mt^7Z6]iTF+(EWfJ9zaK-iTV.C\y
--------------------------------------------------------
128 bit encrypted signature, crack if you can

Megidolaon26-Feb-09 2:02

26-Feb-09 2:02

So that I ensure I have only 1 PictureBox for each coordinate.
In a List I could end up having with 2 PictureBoxes having the same coordiantes.

Xmen wrote:
what that mean ?

When you assign the Image property of a PictureBox, you can only assign the whole image, in my case that would be the whole 256x2000 pixel source image.
What I want is to split that image into 32x32 pixel tiles and assign each of these tiles to a different PictureBox, so you can click on and select each separately.

Then you can paste the 32x32 tiles and build your map with them.

Xmen Real 26-Feb-09 2:49

Re: How to add a ScrollBar where there is none? [modified]

26-Feb-09 2:49

Megidolaon wrote:
So that I ensure I have only 1 PictureBox for each coordinate.In a List I could end up having with 2 PictureBoxes having the same coordiantes.

That mean you are scaring to write a little more code that will validate. Its quite simple, if you dont want to put multiple pictureboxes at same point then you can just iterate through previous pictureboxes' location. BTW I dont think you will get same point again if you try to write a good code (No need for validation) Wink | ;)

Megidolaon wrote:
When you assign the Image property of a PictureBox, you can only assign the whole image, in my case that would be the whole 256x2000 pixel source image.What I want is to split that image into 32x32 pixel tiles and assign each of these tiles to a different PictureBox, so you can click on and select each separately.Then you can paste the 32x32 tiles and build your map with them.

2000 cant be divide by 32, your image must have 2048 height if you gonna tile of 32 x 32

OoO Well, once I wrote a code similar to this but I just used a single PictureBox.
What you need to do is use the MouseClick events of PictureBox. In MouseClick, grab the cursor position, round the position to least tile position and rip it from image.

eg
Cursor Position : 35, 126
Nearest Tile Position(by rounding) : 32, 96

If you are unable to write code to round, just give a bell Wink | ;)

An advice, do not set Image in Image property, use BackgroundImage instead, therefore you can use BackgroundImageLayout and avoid lots of hassles.

Megidolaon26-Feb-09 20:49

26-Feb-09 20:49

As for the PictureBox coordinates, I program by the motto "better save than sorry".
I try to avoid even theoretically impossible situations, like slightly wrong named files (since I'm the only one that names the files), even if such a situation should never happen, I know in the rare case it does (if I forgot the guidelines I made up or whatever), the program will still work fine.
The dictionary works god, I'll just leave it lie that.

Xmen wrote:
2000 cant be divide by 32, your image must have 2048 height if you gonna tile of 32 x 32

I use the Math.Ceiling() method to add enough PictureBoxes to contain images that aren't dividable by 32 and the Image property of the PictureBoxes at the edges should contain the last bit of the source image.
I want to keep the source image size a bit flexible.

Xmen wrote:
Cursor Position : 35, 126
Nearest Tile Position(by rounding) : 32, 96

I already used the MouseDown event to determine which PictureBox was clicked on and changed its BorderStyle.
I laos determined whichPictureBox was last clicked on and changed its BorderStyle back to None, to highlight only the one you clicked on last.

Xmen wrote:
An advice, do not set Image in Image property, use BackgroundImage instead, therefore you can use BackgroundImageLayout and avoid lots of hassles.

I used

pictureboxes[coordinate].BackgroundImageLayout = ImageLayout.Tile;

and tried all available ImageLayouts, with an without my own code.
All PictureBoxes were white and I had a weird smear effect where the the Borders of the PictureBoxes smeared about an inch on the right side of the form, outside the FlowLayoutPanel.

I got it right now, I adjusted my loops and changed a bit, the PictureBoxes were all over the place, with some not even being displayed (I found that out by numbering a few), but now everything is fine.

I even painted the last PictureBoxes first with the BackColor of the form (through a Pen's Brush property) and now it looks like only the source image is displayed.

Xmen Real 27-Feb-09 1:37

Re: How to add a ScrollBar where there is none? [modified]

27-Feb-09 1:37

Since you got it work, no further answers Wink | ;)

if you wanna check mine one, here is the link[^]

Megidolaon1-Mar-09 20:30

1-Mar-09 20:30

Thanks a lot, you helped me a great deal. Wink | ;)

I had a problem with the FlowLayoutPanel, which kept me from displaying the PictureBoxes properly, the FlowLayoutPanel overrides the actual location and changes it according to FlowLayout.

I switched to a normal Panel.
I had a problem where even when setting the AutoScroll peroptery to true, it woudn't add any scrollbars, even if I had many more PictureBoxes then could be displayed at once.
However, I copypasted a Panel from a codeproject article (seemingly the same as mine) and suddenly it worked.
Now my Panel doesn't change the location and adds scrollbars that allow you to scrll arund if the amount of PictureBoxes is too large to display at once.

modified on Monday, March 2, 2009 6:07 AM

Xmen Real 2-Mar-09 5:55

2-Mar-09 5:55

Megidolaon wrote:
which kept me from displaying the PictureBoxes properly

is it public ?

Megidolaon2-Mar-09 20:24

2-Mar-09 20:24

It was private and so were the Panel, I used at first and the Panel, that I use now and which works.

Megidolaon6-Mar-09 1:11

How to Loop through this Arraylist

6-Mar-09 1:11

Now that it works I have a new problem.

The MouseUp event for a PictureBox gets fired the moment I click on a PictureBox.
The problem is that I'd use it allow the user to select multiple tiles while the mouse button is held down and paste them onto the map tiles, again while the mouse button is held down.
If the MouseUp event gets fired without actually releasing the mouse button, this is not possible.

Is there any way around this? Confused | :confused:

Vimalsoft(Pty) Ltd25-Feb-09 3:03

Vimalsoft(Pty) Ltd

25-Feb-09 3:03

Good day All

i have a Following Arraylist that carries the List of Arraylist Values of String type. I want to Disable a Cell that does not match with the Values in the Arraylist.

 ArrayList arr = Disable_Grid();

foreach(arr in ultraGridCycles)
{
  //hide the Cell ;
}

Thank you

Vuyiswa Maseko,

Few companies that installed computers to reduce the employment of clerks have realized their expectations.... They now need more and more expensive clerks even though they call them "Developers" or "Programmers."

C#/VB.NET/ASP.NET/SQL7/2000/2005/2008
http://www.vuyiswamaseko.tiyaneProperties.co.za
vuyiswa@its.co.za
www.ITS.co.za

*Developer Day Scotland - Free community conference
*Colin Angus Mackay's Blog
*Latest Scottish Developers Newsletter

Colin Angus Mackay25-Feb-09 3:14

Colin Angus Mackay

25-Feb-09 3:14

You have not supplied sufficient information.

Vuyiswa Maseko wrote:
I want to Disable a Cell

What cell?

Vuyiswa Maseko wrote:
does not match with the Values in the Arraylist.

There are many values in the array list. Are there many values in each cell?

Do you want to hide cells where the value of the cell is not contained within the ArrayList?

Finally, are you using .NET 1.x? If not, then why are you using an ArrayList.

Vogon Building and Loan advise that your planet is at risk if you do not keep up repayments on any mortgage secured upon it. Remember that the force of gravity can go up as well as down.

Vimalsoft(Pty) Ltd25-Feb-09 3:29

Vimalsoft(Pty) Ltd

25-Feb-09 3:29

Colin Angus Macka wrote:
What cell?

A Grid is made up of Columns and Rows. Like in in Excel we have Cells in a Gridview.

Colin Angus Macka wrote:

There are many values in the array list. Are there many values in each cell?

Yes, The Grid will be Populated with Values like

1234<br />

And in the Arraylist you might Find that there is 4. Now i want to Disable the cell that is carrying the values "123"

Colin Angus Macka wrote:
Do you want to hide cells where the value of the cell is not contained within the ArrayList?

Yes

Am Using .NET 2.0

Thank you

PIEBALDconsult25-Feb-09 3:54

PIEBALDconsult

25-Feb-09 3:54

How about using a HashSet instead?

(No one uses Arraylist anymore anyway.)

Vimalsoft(Pty) Ltd25-Feb-09 4:05

Vimalsoft(Pty) Ltd

25-Feb-09 4:05

That Wouldn't be a problem. I have changed from Arraylist but not to HashSet , am using 2.0 not 3.5

Thanks

Challenge manipulating combobox selectedvalue and selectedvaluechanged

PIEBALDconsult25-Feb-09 6:51

PIEBALDconsult

25-Feb-09 6:51

In my opinion HashSet is the only reason to use 3.5, if it weren't for that I'd still 2.0 as well.

Are you using a Dictionary then? That's what I use in my Set[^] class.

highjo25-Feb-09 2:44

highjo

25-Feb-09 2:44

Hi!
i know people have asked a lot about comboboxes but it's not really about how to get the value or index or whatever.Let me explain.it's users access management application with users, roles and rights:
i have a form editRight with 2 combobox cmbUsers to list users and cmbroles to list role of each users and 3 listboxes.let's pause here

on load event i fill users combobox with users

 private void EditRight_Load(object sender, EventArgs e)<br />
        {<br />
            try<br />
            {<br />
            //Load the user list in the dt_users dataset.dt_users and dt_roles are declare as global variables<br />
            dt_users = UserManager.FindAll().Tables[0];<br />
            //set the combobox cmbUsers datasource<br />
            cmbUsers.DataSource = dt_users.DefaultView;<br />
            //set display member and value member<br />
            cmbUsers.DisplayMember = "user_name";<br />
            cmbUsers.ValueMember = "user_id";<br />
<br />
                CallFillRoleCombo((int)cmbUsers.SelectedValue);<br />
            }<br />
            catch (System.Exception ex)<br />
            {<br />
                MessageBox.Show(ex.Message);<br />
            }<br />
        }<br />
<br />
        private void CallFillRoleCombo(int uid)<br />
        {<br />
            try<br />
            {<br />
                //load users roles into dt_roles database<br />
                dt_roles = UserRoleManager.FindByUser(uid).Tables[0];<br />
<br />
                //set combobox datasource<br />
                cmbroles.DataSource = dt_roles.DefaultView;<br />
                cmbroles.DisplayMember = dt_roles.Columns[2].ToString();<br />
                cmbroles.ValueMember = dt_roles.Columns[1].ToString();<br />
            }<br />
            catch (System.Exception ex)<br />
            {<br />
                MessageBox.Show(ex.Message);<br />
            }<br />
            <br />
        }<br />
<br />
        private void cmbUsers_SelectedValueChanged(object sender, EventArgs e)<br />
        {<br />
            CallFillRoleCombo((int)cmbUsers.SelectedValue);<br />
        }<br />

when i run the code its throws exception:Object reference not set to an instance of an object.It seems that its calling the cmbUsers_SelectedValueChanged eventhandler when setting the display member of the cmbUsers combobox.
How to work around it?Thank you for reading this.

eager to learn

Re: Challenge manipulating combobox selectedvalue and selectedvaluechanged

Cracked-Down25-Feb-09 3:00

Cracked-Down

25-Feb-09 3:00

In the following code for loading data in user combobox
unsubscribe the event cmbUsers_SelectedValueChanged and after filling data

subscribe again

private void EditRight_Load(object sender, EventArgs e)
{
try
{
//Load the user list in the dt_users dataset.dt_users and dt_roles are declare as global variables
dt_users = UserManager.FindAll().Tables[0];
//set the combobox cmbUsers datasource
cmbUsers.DataSource = dt_users.DefaultView;
//set display member and value member
cmbUsers.DisplayMember = "user_name";
cmbUsers.ValueMember = "user_id";


CallFillRoleCombo((int)cmbUsers.SelectedValue);
}
}

hope this works for you!

Re: Challenge manipulating combobox selectedvalue and selectedvaluechanged

Xmen Real 25-Feb-09 3:14