Click here to Skip to main content
15,906,645 members
Home / Discussions / C#
   

C#

 
Questioninsert Data to a MultiColumn ListView By ComboBox Items Pin
nassimnastaran21-Nov-11 4:49
nassimnastaran21-Nov-11 4:49 
AnswerRe: insert Data to a MultiColumn ListView By ComboBox Items Pin
Matt U.21-Nov-11 6:49
Matt U.21-Nov-11 6:49 
QuestionDifference in webconfig "authorization" in .net framework 1.1 and 4.0 Pin
maithilym20-Nov-11 23:50
maithilym20-Nov-11 23:50 
AnswerRe: Difference in webconfig "authorization" in .net framework 1.1 and 4.0 Pin
OriginalGriff21-Nov-11 6:21
mveOriginalGriff21-Nov-11 6:21 
GeneralRe: Difference in webconfig "authorization" in .net framework 1.1 and 4.0 Pin
maithilym21-Nov-11 17:04
maithilym21-Nov-11 17:04 
GeneralRe: Difference in webconfig "authorization" in .net framework 1.1 and 4.0 Pin
Pete O'Hanlon21-Nov-11 22:02
mvePete O'Hanlon21-Nov-11 22:02 
Questionmvc3 custom authentication provider asp.net online list Pin
samwood201120-Nov-11 23:17
samwood201120-Nov-11 23:17 
AnswerRe: mvc3 custom authentication provider asp.net online list Pin
Pete O'Hanlon21-Nov-11 0:44
mvePete O'Hanlon21-Nov-11 0:44 
QuestionTDES Pin
BAZJAK20-Nov-11 21:38
BAZJAK20-Nov-11 21:38 
AnswerRe: TDES Pin
JF201520-Nov-11 22:41
JF201520-Nov-11 22:41 
GeneralRe: TDES Pin
BAZJAK22-Nov-11 0:05
BAZJAK22-Nov-11 0:05 
AnswerRe: TDES Pin
phil.o21-Nov-11 10:23
professionalphil.o21-Nov-11 10:23 
QuestionProblem with SQLDataReader and Insert command Pin
CCodeNewbie20-Nov-11 6:39
CCodeNewbie20-Nov-11 6:39 
AnswerRe: Problem with SQLDataReader and Insert command Pin
Dan Mos20-Nov-11 7:49
Dan Mos20-Nov-11 7:49 
GeneralRe: Problem with SQLDataReader and Insert command Pin
CCodeNewbie20-Nov-11 9:13
CCodeNewbie20-Nov-11 9:13 
GeneralRe: Problem with SQLDataReader and Insert command Pin
Dan Mos20-Nov-11 9:56
Dan Mos20-Nov-11 9:56 
AnswerRe: Problem with SQLDataReader and Insert command Pin
Luc Pattyn20-Nov-11 9:50
sitebuilderLuc Pattyn20-Nov-11 9:50 
GeneralRe: Problem with SQLDataReader and Insert command Pin
CCodeNewbie20-Nov-11 12:04
CCodeNewbie20-Nov-11 12:04 
AnswerRe: Problem with SQLDataReader and Insert command Pin
Luc Pattyn20-Nov-11 12:19
sitebuilderLuc Pattyn20-Nov-11 12:19 
GeneralRe: Problem with SQLDataReader and Insert command Pin
PIEBALDconsult21-Nov-11 4:55
mvePIEBALDconsult21-Nov-11 4:55 
GeneralRe: Problem with SQLDataReader and Insert command Pin
CCodeNewbie21-Nov-11 8:09
CCodeNewbie21-Nov-11 8:09 
GeneralRe: Problem with SQLDataReader and Insert command Pin
Pete O'Hanlon22-Nov-11 0:37
mvePete O'Hanlon22-Nov-11 0:37 
There are a few changes I would make to your code if it was me developing this. First of all, I would wrap the SqlConnection and SqlCommand statements with using so that they are disposed of (which ensures that Close is called).

I would also change your insert statement to include the SELECT COUNT as part of the where clause. The reason that I would do this is because you are working in a multi-user database, so it's entirely possible that somebody else could be inserting the value between the time you did the SELECT COUNT and the INSERT. When you do checks like this, it's always important to remember the multi-user access nature of the database.

Forgive your enemies - it messes with their heads

"Mind bleach! Send me mind bleach!" - Nagy Vilmos


My blog | My articles | MoXAML PowerToys | Mole 2010 - debugging made easier - my favourite utility


GeneralRe: Problem with SQLDataReader and Insert command Pin
CCodeNewbie22-Nov-11 1:13
CCodeNewbie22-Nov-11 1:13 
GeneralRe: Problem with SQLDataReader and Insert command Pin
Pete O'Hanlon22-Nov-11 3:03
mvePete O'Hanlon22-Nov-11 3:03 
GeneralRe: Problem with SQLDataReader and Insert command Pin
CCodeNewbie22-Nov-11 9:50
CCodeNewbie22-Nov-11 9:50 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.