|
Any particular reason your createNewContract takes on 22 parameters? That is an eye sore. Why not have a class that holds the parameters and pass an instance of the class object as a parameter to improve readability.
"Any sort of work in VB6 is bound to provide several WTF moments." - Christian Graus
|
|
|
|
|
Thank you Paul,
I think you are driving me on a direction I wasn't thinking of
How would you do this (on a sample section of code)?
In general, what are the advantages of your solution compared to what I'm doing? Reuse/visibility?
The concept is new to me
Thank you
|
|
|
|
|
Yes, my post was not really directed to your actual question but an off topic observation I made. How to do my suggestion is pretty straightforward. Just have a class with properties that are the parameters (this is where you could check for invalid parameters as well - unless you have checks done elsewhere), and you populate the properties with the respective values and just pass the object.
The advantage is clarity and readability, and it doesn't hurt to have all the values you are passing to be encapsulated in a wrapper class. Either the way you have done it, or my suggestion, both work.
Back to your original post, I would second PIEBald's suggestion if it works for you.
"Any sort of work in VB6 is bound to provide several WTF moments." - Christian Graus
|
|
|
|
|
Something perhaps along the lines of:
public class Contract
{
int employeeId;
string agency, role, contractType, startDate, endDate, lineManager, reportTo;
string costCenter, functionEng, atrNo, atrDate, prNo, prDate, poNo, poDate;
string comments;
decimal duration, workRatePercent;
string currency;
decimal hourlyRate, value;
public Contract()
{
}
public int EmployeeId
{
get
{
return employeeId;
}
set
{
employeeId = value;
}
}
public static void createNewContract()
{
}
}
Inside the properties for anything that works with decimals, you can take care of the conversion there. Again, this is just a slight off topic suggestion, and I do not know how much work it would be to put this into your application, but it's a kind thought
"Any sort of work in VB6 is bound to provide several WTF moments." - Christian Graus
|
|
|
|
|
It all really make sense to me now
I'm going to pursue this way
Thanks a lot!
|
|
|
|
|
You're very welcome. At first, it sounds like it is a bit of extra coding, but it is worth it in the long run!
"Any sort of work in VB6 is bound to provide several WTF moments." - Christian Graus
|
|
|
|
|
how to creat theme with c#?
|
|
|
|
|
Theme for what??
The quality of the answer you get is directly dictated by the quality of your question. If there are critical details you leave out of your question, people will only be guessing at what you really mean.
Is this for generating a theme for another application or for Windows or are you talking about skinning your own Windows Forms app, or your WPF app, or an ASP.NET app, or ... what??
BE SPECIFIC!
|
|
|
|
|
theme for skining on my own windows form
|
|
|
|
|
Try this:
System.Console.Beep ( 349 , 245 ) ;
System.Console.Beep ( 329 , 245 ) ;
System.Console.Beep ( 622 , 245 ) ;
System.Console.Beep ( 587 , 983 ) ;
System.Console.Beep ( 493 , 245 ) ;
System.Console.Beep ( 440 , 245 ) ;
System.Console.Beep ( 493 , 983 ) ;
|
|
|
|
|
Hi! i have a code written in c#, this code is of a server that receives GPRMC frames from the client and it determines the location of the client! what should i do to modify the code and the frame so it will contain a signal of emergency sent by the client?
|
|
|
|
|
Don't repost the same question again. Have some patience.
People will answer your question IF they have any clue what you're talking about and have anything useful to say.
Truthfully, we have no idea what you're doing nor does anyone have any clue why you want to modify the GPS data. To what end??
|
|
|
|
|
i want to change the program, so if the client feels in danger, he will send signs to the server telling him that he is in danger! I want to modify the GPRMC frame so it will send an emergency sign with its other informations
|
|
|
|
|
I take it you're writing both the server and the client software??
If so, then you just need to wrap the GPS data in a message with an appropriate flag telling the server it's an emergency. The server will have to be reworked to expect this message instead of just a line of GPS data, or whatever you've got the server listening for.
If you're not writing the software for both sides of this app then you've got a seriously large problem as it's extremely unlike you've going to get a manufacturer to modify anything to your specifications.
|
|
|
|
|
I havn't understood what you wanted to say, but what i actually want to ask, my code do just one action: the server analyse the frames receives from the clietn and determine the location of the person! So, if we want that the client send a sign of emergency, should we change the type of frame GPRMC or should we add modifications to thar frame? i hope i was clear because am used to speak in frensh
|
|
|
|
|
I think you are missing one part: how will the client signal that it is an emergency?
One of these days I'm going to think of a really clever signature.
|
|
|
|
|
ok! actually my application is reserved to the alzheimer's peaple. They have a device and it sends to the server every 30 seconds a frame telling him where he is, and if the ill person feels in danger, he will press a button, and another frame will be sent telling that the client is in emergency! My question is, should i use another frame or have to modify the GPRMC frame i hope that i wwas clear enough this time :/
|
|
|
|
|
chouu wrote: another frame will be sent telling that the client is in emergency! OK, then your code just needs to recognise the emergency frame.
One of these days I'm going to think of a really clever signature.
|
|
|
|
|
It's not very clear.
Are you writing the code for this device?? Are you writing the code for the server side also??
If not, you've got big problems. Sure, you could modify the data being sent to the server, but if the server isn't familiar with the new data format or is even looking for the data you added, nothing is going to happen at all.
|
|
|
|
|
Now, i am writing the code for the server only! But how can i modify the frame GPRMC? could we do it?
|
|
|
|
|
Dude... You can modify the frame on the server side all you want, but how are you going to know if the patient pushed the little red button??
|
|
|
|
|
that's what i am sayin! the frame should contain a sign that tells the server the patient needs help! so you are saying that we can modify the trame sent by the client? we add the modification from the side cleitn? is that ok ? and how can we do it?
|
|
|
|
|
Back up...
If you're not writeing the code for BOTH ENDS of the communication channel, for the device AND the server, you can't pull this off.
If the patient presses the "help" button on the device, the device has to provide that data in the packet that's sent to the server. AND the server needs to be rewritten to be able to look for that signal in the device.
Perhaps you need to back up and FULLY explain how this system works and what you're writing code for. We can't read your mind or see your monitor from our side of the Internet.
|
|
|
|
|
ok am sorry!! i will explain again and i hope i will be clearer than! So, the patient has a device! this devicce sends to the server every 30 seconds a frame, this frame is a GPRMC and it gives to the server informations about the location of the patient! I wrote only the code of the server, and i want to add an option to this code, the patient will send also signs of emergency when he pushes on a button. The frame should be modified telling that the patient needs help!
What i understood from what you said that i can modify the GPRMC frame, and i can add a zone to the frame telling if he needs help. But, i will present my work to m friends, so i should telle them i have modified the frame to explain my ideas! So from the server's side, it is clear what i am going to do, but from the client's side, i just want to knowa how we can modify a trame to explain it queeckly! is it clear now?
|
|
|
|
|
No.
How is your server EVER going to know that the patient pressed the button??
|
|
|
|