C / C++ / MFC

sock = hci_open_dev( dev_id );

hci_devba

<pre>        bdaddr_t *bdaddr_1={0};

       result = hci_devba(sock, bdaddr_1);
       if(result == 0)
       {
           text = "SUCCESs local device address ";
           //CONVERT char to string
           ba2str(bdaddr_1, addr);
           text = addr;
       }
       else
       {
           text = "FAILED to get local device address (socket) ";
       }
       qDebug()<< text;

hci_devba

Salvatore Terress wrote:

it makes little sense ( to me) to pass "socket" to

if (NULL != lpszNew)
{

if (lpszNew != NULL)
{

charlieg wrote:

The first form is a time honored coding tradition to prevent typos in conditionals.

trønderen wrote:

those who turns the condition around never mixes up assignment and equality operators.

trønderen wrote:

I wonder if anyone ever has remembered to write the conditional backwards, yet used '=' rather than '=='.

trønderen wrote:

I prefer the natural way of writing conditionals

trønderen wrote:

I never say 'if 1979 is the vintage'

trønderen wrote:

I wonder if anyone ever has remembered to write the conditional backwards, yet used '=' rather than '=='. My impression is that those who turns the condition around never mixes up assignment and equality operators.

Quote:

I prefer the natural way of writing conditionals,emphasizing readability over dogmas

#pragma wanring (disable: 6011)

charlieg wrote:

I take the phrase "Here be dragons..." seriously.

void CInfoBar::SetText(LPCTSTR lpszNew)
{
    ASSERT(lpszNew && AfxIsValidString(lpszNew));

if (NULL != lpszNew)
{
    ASSERT(lpszNew && AfxIsValidString(lpszNew));

charlieg wrote:

Still I'm amazed that the MS compiler would distinguish between either version of the source.

Aryan Gupta 2024 wrote:

I know my code is correct. But is my code completing all the demands of the question.

Salvatore Terress wrote:

#include <dbus/dbus-signature.h>
compiler l,fails to "find" this file ONLY
#include <dbus/dbus-syntax.h>

#include <iostream>
#include <dbus/dbus.h>

int main()
{
    std::cout << "Hello World\n";
}

k5054@localhost:~/tmp $ g++ hello.cpp
hello.cpp:2:10: fatal error: dbus/dbus.h: No such file or directory
    2 | #include <dbus/dbus.h>
      |          ^~~~~~~~~~~~~
compilation terminated.

k5054@localhost:~/tmp $ pkg-config --cflags dbus-1
-I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include 

k5054@localhost:~/tmp$ g++ $(pkg-config --cflags dbus-1) hello.cpp
k5054@localhost:~/tmp$ ./a.out
Hello World
k5054@localhost:~/tmp$