C / C++ / MFC

Re: 'sprintf': cannot convert parameter 1 from 'TCHAR *[1024]' to 'char *'

5-Aug-14 2:04

Use wsprintf -

wsprintf(c_buffer, _T("%d"), pb->i_id);

«_Superman_»
I love work. It gives me something to do between weekends.

Microsoft MVP (Visual C++) (October 2009 - September 2013)

Polymorphism in C

Swap95-Aug-14 3:43

Swap9

5-Aug-14 3:43

Worked ! great... thanks Smile | :)

Re: 'sprintf': cannot convert parameter 1 from 'TCHAR *[1024]' to 'char *'

Swap96-Aug-14 1:31

Swap9

6-Aug-14 1:31

Hello superman...just trying my luck by asking this to you...

problem piece of code - if(Function(parm1, parm2, parm3)==0){
error - cannot convert parameter 3 from 'char [1024]' to 'wchar_t *'

Function is expecting wchar_t but its getting char[1024] from some where.
I changed the function signature to accept wchar_t type in header file.
objective is to make the whole code UNICODE enabled. I have added all the tchar.h, wchar.h fiels
param 3 has been defined (modified) as wchar_t in all the connected files too.
I cant debug yet. Pls help how can i get rid of this error.
I am working in vs2010.I counter checked it about five times and gave the search in solution to find if parm3 is still 'char' somewhere else.
I am seriously doubting typecasting the wchar_t parm3[] before passing it function i think.
I went to function declaration and changed it to char* to wchar_t* too. I doubt that might not be straight forward. there should be some changes.

Re: 'sprintf': cannot convert parameter 1 from 'TCHAR *[1024]' to 'char *'

«_Superman_»6-Aug-14 20:22

Re: 'sprintf': cannot convert parameter 1 from 'TCHAR *[1024]' to 'char *'

6-Aug-14 20:22

To support UNICODE, you need to use wchar_t instead of char.
You also need to use the string functions that work on wchar_t like wcslen, wcscat etc.
While defining string literals use the L prefix - L"Hello World"

If you have a string that is already encoded as ASCII, you need to convert it to UNICODE.
Simply typecasting will not work.

You can use the MultiByteToWideChar[^] API to do the conversion.

«_Superman_»
I love work. It gives me something to do between weekends.

Microsoft MVP (Visual C++) (October 2009 - September 2013)

Polymorphism in C

CPallini5-Aug-14 2:36

Re: 'sprintf': cannot convert parameter 1 from 'TCHAR *[1024]' to 'char *'

5-Aug-14 2:36

Quote:
sprintf(c_buffer, "%d", pb->i_id);

change to

C++

_stprintf(c_buffer, _T("%d"), pb->i_id);

see sprintf, _sprintf_l, swprintf, _swprintf_l, __swprintf_l[^]

THESE PEOPLE REALLY BOTHER ME!! How can they know what you should do without knowing what you want done?!?!
-- C++ FQA Lite

Swap95-Aug-14 3:50

Swap9

5-Aug-14 3:50

SQL

However, the swprintf function, which is a VC++ library function is the correct one to use.
The wsprintf function is part of some windows API, and does not support all the formatting options. For example wsprintf does not support the "*" width specification.

Thanks !

Re: 'sprintf': cannot convert parameter 1 from 'TCHAR *[1024]' to 'char *'

Richard MacCutchan5-Aug-14 5:32

how to correct this warning?

5-Aug-14 5:32

If you are using TCHAR to define your data then you must use the routines with the _st prefix as described in http://msdn.microsoft.com/en-us/library/ybk95axf.aspx[^]/ This allows the compiler to generate code for ASCII or Unicode depending on your project settings. If your program is only ever going to handle Unicode character data then you should use WCHAR and the PW prefixed pointers.

mybm15-Aug-14 0:02

5-Aug-14 0:02

Quote:
warning: format ‘%s’ expects argument of type ‘char *’, but argument 2 has type ‘char **’

Richard MacCutchan5-Aug-14 0:08

5-Aug-14 0:08

The message is telling you how to correct it; you must use a char* parameter for the %s format type. See http://msdn.microsoft.com/en-us/library/56e442dc.aspx[^].

mybm15-Aug-14 0:17

5-Aug-14 0:17

ok ,thnk u but for the parameter char ** what format we should declared to print?

Richard MacCutchan5-Aug-14 0:22

5-Aug-14 0:22

Read the documentation I gave you the link for; it describes all the available format types and what parameters they require. There is no format type that handles char**, for a very good reason.

«_Superman_»5-Aug-14 1:10

What are the basic features provide by CCmdTarget??

5-Aug-14 1:10

The format %s is used to output a null terminated string.
The variable it expects is a char*.

I can think of 2 possibilities.
Since you haven't posted any relevant code, I'm only guessing here.

First guess is that you're trying to print a string and are using an extra & character -

char string[20];
printf("%s", &string);    // The & is not needed here.

Second guess is that you've received a char** as a function argument and trying to print it.

void fun(char** arg)
{
    printf("%s", *arg);      // * is needed here.
}

It would be best if you can post the relevant code.

«_Superman_»
I love work. It gives me something to do between weekends.

Microsoft MVP (Visual C++) (October 2009 - September 2013)

Polymorphism in C

sachanratnesh4-Aug-14 20:03

sachanratnesh

4-Aug-14 20:03

What are the basic features provide by CCmdTarget??

Re: What are the basic features provide by CCmdTarget??

«_Superman_»4-Aug-14 20:26

Re: What are the basic features provide by CCmdTarget??

4-Aug-14 20:26

Message mapping and COM support.

«_Superman_»
I love work. It gives me something to do between weekends.

Microsoft MVP (Visual C++) (October 2009 - September 2013)

Polymorphism in C

sachanratnesh4-Aug-14 21:46

sachanratnesh

4-Aug-14 21:46

Thanks.

Re: What are the basic features provide by CCmdTarget??

Richard MacCutchan4-Aug-14 20:57

4-Aug-14 20:57

See CCmdTarget Class[^].

calling of function ?

mybm14-Aug-14 19:17

4-Aug-14 19:17

<blockquote class="quote"><div class="op">Quote:</div>#include<stdio.h>
#include<stdlib.h>
#include<math.h>
// main.c

#include "Utility.c"
#include<dirent.h>
//#include "sample.c"
//#include "noise.c"


float* random1(int SizeOfData);
int main(void)
{
//===================random number sequences generation 

	int i,j;
	int SizeOfData=63530;
	float* squaring;
	float total_sum,summation_noise;
	float* random_seq=(float *)malloc(SizeOfData* sizeof(float ));


          random_seq=random1(SizeOfData);
		for(i=0;i<SizeOfData;i++)
			{
				printf("\t%f\n",random_seq[i]);
				
			} 
				

return 0;
}

</blockquote>

// utility.c

<blockquote class="quote"><div class="op">Quote:</div>float* random1(int SizeOfData)
{
	srand(12345); // generate same random number anytime it run
       //srand((unsigned int)time NULL)
	int i,j;
	float sum=0.0;
	float a=0.2;
	float summation_noise=0.0;

        float *y;

	y=(float *)malloc(SizeOfData* sizeof(float ));
	for(i=0;i<SizeOfData;i++)
		{
   float f= ((float)rand()/(float)(RAND_MAX))*a; //rand return integer value from 0 to RAND_MAX(system dependent)
         		
		        y[i]=f;
			//printf("\t%f\n",f);
			//printf("%f\t",((float)rand()/(float)(RAND_MAX))*a);

			
    			
               }
return y;
          </blockquote>

while running expected output has to be random float number from 0-63530
but it is displaying only one number .

CPallini4-Aug-14 20:32

4-Aug-14 20:32

Quote:
#include "Utility.c"

What's its purpose (usually you include just header files)?
Your program (without such line) runs producing the expected output.

Please note:

Quote:
float* random_seq=(float *)malloc(SizeOfData* sizeof(float ));

is useless, since memory is allocated inside the random1 function.

You never free the allocated memory (you have to ).

THESE PEOPLE REALLY BOTHER ME!! How can they know what you should do without knowing what you want done?!?!
-- C++ FQA Lite

mybm14-Aug-14 20:40

4-Aug-14 20:40

utility.c is the program file where the function is declared from there I was aiming to call to main.c that y I include it.

CPallini4-Aug-14 20:49

4-Aug-14 20:49

maibam debina wrote:
utility.c is the program file where the function is declared

What function? You know, functon declarations should be inside header files and you should include just header files (as rule of thumb for beginners, at least).

Quote:
rom there I was aiming to call to main.c that y I include it

You cannot call a file (main.c is a file).

THESE PEOPLE REALLY BOTHER ME!! How can they know what you should do without knowing what you want done?!?!
-- C++ FQA Lite

mybm14-Aug-14 20:57

4-Aug-14 20:57

In Utility.c its consist of already one created header file Utility.h which consist of struct for waveread do i need to add on this and if needed which way i have to?

#define _USE_MATH_DEFINES

#define PI	M_PI	/* pi to machine precision, defined in math.h */
#define TWOPI	(2.0*PI)




#ifndef UTILITY_H_
#define UTILITY_H_
struct WavHeader {
	char chunkid[4];
	int chunksize;
	char format[4];
	char subchunk1id[4];
	int subchunk1size;
	short int audioformat;
	short int numchannels;
	int samplerate;
	int byterate;
	short int blockalign;
	short int bitspersample;
	char subchunk2id[4];
	int subchunk2size;


};

float * wavRead(char*, int*);

#endif /* UTILITY_H_ */

CPallini4-Aug-14 21:20

4-Aug-14 21:20

You should include Utility.h if you need either WavHeader or wavRead (or both).

Utility.c should contain the wavRead function definition (its implementation).

You should NOT include Utility.c in main.c.

THESE PEOPLE REALLY BOTHER ME!! How can they know what you should do without knowing what you want done?!?!
-- C++ FQA Lite

mybm14-Aug-14 20:59

4-Aug-14 20:59

Is it always neccessary to create header file,if i want to call a function which is in another file?

CPallini4-Aug-14 21:23