|
Even I love this. 
Putting constant at left hand side surely saves from missing '='. The earlier compilers were not intelligent to raise a warning like the latest ones. That might have forced people like me to cultivate this habit. Otherwise one had to debug code to find such kind of bug (Some great minds might have found these kind of bugs with their open eyes, I won't deny that as well). But surely it wont give u a chance to debug the code to find such bugs. That's my personal opinion.
|
|
|
|
|
looks like you are new to programming? Not sure, but when I was a fresher I used to hate my colleague writing
if(bCondition)
andI purposefully wrote my lines as
if(bCondition==TRUE)
Then I realized I'm stupid if I followed my "spoken" code way.
So, in short it's the correct form to keep the constant on the left. Don't do the other way and don't hate your colleague 
Starting to think people post kid pics in their profiles because that was the last time they were cute - Jeremy.
|
|
|
|
|
Ha, I have the opposite problem.
If the variable is decleared to be bool (C++) or BOOL (C/Microsoft) then I don't mind the if (bCondition) or even if (!bCondition). What kills me is if the variable is an int or similar and that short cut is used just because it evaluates to a zero/non-zero test. Damnit, write:
if (iVar != 0) or
if (iVAR == 0) if that's what you're testing for and don't use the "boolean variable" if notation.
if (!iVar) to mean "if iVar is equal to zero" just drives me crazy.
|
|
|
|
|
Chuck O'Toole wrote:
if (!iVar)
to mean "if iVar is equal to zero" just drives me crazy.
I second that.
"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous
|
|
|
|
|
Thirded. 
|
|
|
|
|
Yup I hate that too!
Starting to think people post kid pics in their profiles because that was the last time they were cute - Jeremy.
|
|
|
|
|
VuNic wrote: looks like you are new to programming?
No
VuNic wrote: if(bCondition)
andI purposefully wrote my lines as
if(bCondition==TRUE)
Hungarian notation? tisk tisk
VuNic wrote: So, in short it's the correct form to keep the constant on the left
I disagree, it's a matter of preference and as others have pointed out most compilers will produce a warning if the warning level is set correctly.
|
|
|
|
|
_Josh_ wrote: Hungarian notation? tisk tisk
. What? Hungarian Notation going out of style? Hey, I'm just getting into it having finally stopped following Fortran II notations of variables starting with I thru N are integers, everything else is floating (aka "real"). 
|
|
|
|
|
_Josh_ wrote: I disagree, it's a matter of preference and as others have pointed out most compilers will produce a warning if the warning level is set correctly.
Real men work on turbo C++.
Starting to think people post kid pics in their profiles because that was the last time they were cute - Jeremy.
|
|
|
|
|
I have no problem at all, and in fact prefer the form
if (bcondition)
provided bcondition is of type bool. I hate it though when the variable in question is, in fact, an int or similar, especially when it can take more than 2 values (e. g. when interpreting error codes, where sometimes 0 indicates failure, and on other occasions 0 indicates success and anything else is an enumerated code...)
|
|
|
|
|
I understand the reason people give for doing this, but as far as I'm concerned if you can remember to reverse these conditions then you can also bloody well remember to get the number of '='s right.
David Anton
Convert between VB, C#, C++, & Java
www.tangiblesoftwaresolutions.com
|
|
|
|
|
In my experience, this is not true. Typing '=' instead of '==' is as often a real typing error as it is a coding oversight. I even go so far as to always put the constants on the left hand side in all comparisons, so I don't forget to do so on equality operators. I never ever had a '='/'==' error since I started using this practice some time around 1990. (I did fix quite a few such errors caused by others though, and I can tell you that kind of work is not pretty!)
|
|
|
|
|
Yes that's true. I've had some serious problems in algorithms because of this == typo. That killed me for days. I think all these recent compilers take strain to point out this type of typos. But older ones just wait for you to make one and kill you. Eversince I got my fingers burnt on this, I put the constants on the left for ever! unless I'm typing something for fun.
Starting to think people post kid pics in their profiles because that was the last time they were cute - Jeremy.
|
|
|
|
|
_Josh_ wrote: I have a colleague working with me at the moment and he loves to do this (NULL
first) and I hate it.
If I was working somewhere where that was the most significant problem in the code base then I would be ecstatic.
|
|
|
|
|
Over the past 20+ years, yes, this has saved me a couple dozen times. It's so much faster to just quickly fix a compiler error than hunting down some weird bug that can express itself in all kind of ways, but usually nowhere near the context of the actual source of the problem.
And no, there is no other reason that I am aware of. I don't need any.
|
|
|
|
|
Hi,
I did a setup to install my app, but I need add the activeX (msflxgrd) to show a grid.
How can I add the active X to my project??
Thank you.
The project is in Visual C++, mfc.
|
|
|
|
|
Do you want to add the flexgrid to your dialog box??
Every new day is another chance to change your life.
|
|
|
|
|
Nooo, I have added the msflegrid in my dialog, but now, I did a setup to be able to install my app in any pc, and I need add the activeX here.
If I run the setup I get this:
Can not find source file 'C: \ Windows \ System32 \ msflxgrd.ocx' for file 'msflxgrd.ocx' located in '[TARGETDIR]', the file may be missing or blocked.
I followed this page:
http://www.simple-talk.com/dotnet/visual-studio/getting-started-with-setup-projects/[^]
modified 8-Nov-11 4:22am.
|
|
|
|
|
Include the required "MSFlxgrd.OCX" file into your Setup Project. Copy that file to either system folder or to your application folder. Register the ActiveX from the setup project.
|
|
|
|
|
Check Here[^]
Starting to think people post kid pics in their profiles because that was the last time they were cute - Jeremy.
|
|
|
|
|
In my huge, multithreaded codebase, at one place it use setTimer like
in a class's OnStart() function
::SetTimer(this->m_hWnd, 2020, 60000 ,NULL);
in OnStop() function
::KillTimer(this->m_hWnd, 2020);
So right now SetTimer is set for 1 minute but my requirement is that instead of this constant value, i want to change that value based upon clock time. Say it works as it works now for first 15 minute (checking after every minute) then it start checking every 15 minute, if still its unable to service then after 1 hour change it to every 30 minute.
Can somebody please send me sample callback function that implements the logic i mentioned?
|
|
|
|
|
Why not simply kill the old timer and start a new one when you want to change the interval? It seems to me that you are making the determination of the new interval during processing of the old timer going off so it's easy to reset the time to the next timer event.
Now personally, I wouldn't do it this way, especially if the application is already threaded. I use a thread with a sleep interval that takes me to the next event. In fact, I use a "WaitForSingleObject()" on an event flag with the timer interval as the timeout. This allows for another thread to "wake" the timer thread when some extraordinary event takes place, one that could possible affect when the next interval is supposed to fire.
|
|
|
|
|
Nothing wrong with using timer, but for a changing interval, your suggestion is great (specially the part about using the waitforsingleobject over plain sleep). +5
|
|
|
|
|
Firstly thanks a lot for your reply. I finally reached the timeline, did exactly what you mentioned like killing old timer and starting a new one based upon different conditions so the timer keep on changing the interval. Now the requirement got changed so that i need to continue using the old timer to do task A and invoking the second timer (which needs to be updated say every few minutes) but the first timer is getting invoded every 20 seconds and its independent upon the 2nd timer.
So i was wondering like if when the first timer got fired and invoke the OnTimer(), can i create a new timer(timerB) in the OnTimer() event, kill new timerB and reset new timerB all through the OnTimer() Event. It look like a mess right now since after every few seconds the OnTimer() is getting fired & most of the application logic is written itself in OnTimer Event but the same things i need to invoke/update using 2nd timer which has a big time interval. So what you suggest in this case? like do i need to create Ontimer2()Events for the 2nd timer.
Second solution is the ideal one in my particular case but i've few design constraints that prohibit me to create new threads.
|
|
|
|
|
There is no such thing as "Ontime2()" in the framework, there is only "OnTimer(UINT_PTR nIDEvent)".
Nothing prevents you from having two separate timer IDs
m_TimerID1 = SetTimer(1, TimerValue1, NULL);
m_TimerID2 = SetTimer(2, TimerValue2, NULL);
They will both go through the same "OnTimer()" function, you will be passed the event id so you can test which one went off and act appropriately.
There are probably other ways of handling this kind of situation, including having a "lowest common denominator" interval and managing your own countdown for event A or event B. As long as it doesn't get any crazier, two timers should work out ok.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
![Rose | [Rose]](https://codeproject.global.ssl.fastly.net/script/Forums/Images/rose.gif)
![Rose | [Rose]](https://codeproject.freetls.fastly.net/script/Forums/Images/rose.gif)
