C / C++ / MFC

jharn wrote:

in the part where I compare if (arg1 = a) it tells me expression must have a bool type.

jharn wrote:

Is that not an AND function? ==

jsc42 wrote:

You are trying to compare two strings. The == operator just compares simple scalar values, not arrays.

string vl_reg1[16] = { /* 15 strings */ };
do{
  a = vl_reg1[counter];
  counter = counter + 1;
} while (counter <= 16)

jharn wrote:

This is the VBA code I was trying to translate from, it is a bit cleaner since I am a bit more familiar with it. Just posting so you can see what I was trying to do.

#include <string>
using std::string;
#include <array>
using std::array;
#include <stdexcept>
using std::invalid_argument;

typedef array<const string, 15> Names;
Names names = 
{
	"70-30 Cu-Ni", "90-10 Cu-Ni", "Admiralty Metal", "Aluminum Brass", 
	"Aluminum Bronze", "Arsenical Copper", "Cold-Rolled Low Carbon Steel", "Copper Iron 194 (Olin 194)", 
	"Titanium Grades 1 & 2", "304 SS", "316/317 SS", "N08367 (AL6XN)", 
	"S43035 (TP439)", "S44660 (Sea-Cure)", "S44735 (AL29-4C)"
};

typedef array<const double, 15> SaturationPressure; // saturation pressure in Hg from Names at various temperatures
const SaturationPressure vl_reg12 = {0.71, 0.8, 0.93, 0.92, 0.89, 0.98, 0.81, 1, 0.64, 0.54, 0.53, 0.48, 0.63, 0.58, 0.58};
const SaturationPressure vl_reg14 = {0.78, 0.85, 0.96, 0.95, 0.93, 1, 0.86, 1.01, 0.71, 0.62, 0.61, 0.56, 0.71, 0.66, 0.66};
const SaturationPressure vl_reg16 = {0.83, 0.89, 0.98, 0.97, 0.96, 1.01, 0.9, 1.02, 0.77, 0.69, 0.67, 0.63, 0.77, 0.72, 0.72};
const SaturationPressure vl_reg18 = {0.88, 0.93, 1, 0.99, 0.98, 1.02, 0.94, 1.03, 0.83, 0.75, 0.74, 0.7, 0.82, 0.79, 0.79};
const SaturationPressure vl_reg20 = {0.92, 0.96, 1.01, 1.01, 1, 1.03, 0.97, 1.03, 0.89, 0.82, 0.81, 0.78, 0.88, 0.85, 0.85};
const SaturationPressure vl_reg22 = {0.95, 0.98, 1.02, 1.02, 1.01, 1.03, 0.98, 1.04, 0.91, 0.86, 0.85, 0.82, 0.91, 0.89, 0.89};
const SaturationPressure vl_reg23 = {0.96, 0.99, 1.02, 1.02, 1.01, 1.04, 0.99, 1.04, 0.93, 0.88, 0.87, 0.84, 0.92, 0.9, 0.9};
const SaturationPressure vl_reg24 = {0.97, 0.99, 1.03, 1.02, 1.02, 1.04, 1, 1.04, 0.94, 0.9, 0.89, 0.86, 0.94, 0.92, 0.92};
const SaturationPressure vl_reg25 = {0.97, 1, 1.03, 1.03, 1.02, 1.04, 1, 1.04, 0.95, 0.91, 0.9, 0.88, 0.95, 0.93, 0.93};

typedef array<const SaturationPressure, 9> Pressures;
Pressures pressures = {
	vl_reg12, vl_reg14, vl_reg16, vl_reg18, vl_reg20, vl_reg22, vl_reg23, vl_reg24, vl_reg25};

typedef array<int, 9> Temperatures;
Temperatures temp = {12, 14, 16, 18, 20, 22, 23, 24, 25};

double HEI_F2(const string& name, int temperature)
{
	size_t iName = distance(names.begin(), find(names.begin(), names.end(), name));
	if (iName == names.size())
		throw invalid_argument("Invalid name");

	size_t iTemp = distance(temp.begin(), find(temp.begin(), temp.end(), temperature));
	if (iTemp == temp.size())
		throw invalid_argument("Invalid temperature");
	 
	return pressures[iTemp][iName];
}

#include <iostream>
using std::cout;
using std::endl;
int main()
{
	try
	{
		cout << HEI_F2("Admiralty Metal", 22) << endl; // 1.02
		cout << HEI_F2("Cold-Rolled Low Carbon Steel", 22) << endl; // 0.98
		cout << HEI_F2("Aluminum Bronze", 18) << endl; // 0.98
		cout << HEI_F2("Aluminum Bronze", 30) << endl; // throws Invalid temperature
	}
	catch (invalid_argument& err)
	{
		cout << err.what() << endl;
	}
	return 0;
}