C / C++ / MFC

Cedric Moonen wrote:

Usually, to stop a thread you set a flag to false and this flag is constantly checked within your thread function. Once it is false, the function exits, which stops the thread.

Rajesh R Subramanian wrote:

And if you're thinking of setting m_bAutoDelete to TRUE, I can almost confidently tell that your approach is wrong (it is so, in 90% of the cases).

Rajesh R Subramanian wrote:

It cleans up its own mess, unless you set the m_bAutoDelete variable to TRUE before the thread starts.

CPallini wrote:

Rajesh R Subramanian wrote:

It cleans up its own mess, unless you set the m_bAutoDelete variable to TRUE before the thread starts.

Is quite the opposite, I suppose. Am I wrong?

Rajesh R Subramanian wrote:

I think Carlo was talking with regards to be able to manually 'delete' the CWinThread object

Roger Stoltz wrote:

I think he's talking about that your sentence can be interpreted as "if m_bAutoDelete is set to TRUE, CWinThread will not clean up its own mess".

Rajesh R Subramanian wrote:

Carlo doesn't come up to tell us he was actually talking about Pasta and Rosemary.

CPallini wrote:

If I recall well, that isn't the whole story, The CWinThread pointer is deleted too.

Roger Stoltz wrote:

But the only thing the OP need is to read Joe's article over and over again until it's understood. Really.

mikert_2008 wrote:

CWinThread * myWorkerThread;
myWorkerThread = AfxBeginThread(run, this);

myWorkerThread->m_bAutoDelete = TRUE;

CWinThread* pThread;
// Create thread suspended to avoid race conditions
pThread = AfxBeginThread( run, this, 0, 0, CREATE_SUSPENDED, NULL );

// Make sure the thread could be created and  
// the pointer is valid before operating on it
if( pThread )
{
    // Don't let the object delete itself since we want 
    // to be able to wait on the thread handle
    // This is important and addressed in the article linked to by Carlo!
    pThread->m_bAutodelete = FALSE;
    pThread->ResumeThread();
}

if( pThread )
{
    // Here should probably be something that tells the thread 
    // to stop executing such as an event that is signalled

    if( ::WaitForSingleObject( pThread->m_hThread, INFINITE ) == WAIT_OBJECT_0 )
    {
        // Now it's safe to delete the CWinThread object!
        delete pThread;
        pThread = NULL;
    }
}

mikert_2008 wrote:

This I will put in the destructor of class (which starts the thread)...