C / C++ / MFC

11-Jan-06 11:29

Hello everyone! Big Grin | :-D

I've been wanting to know how good/bad I'm doing as a programmer... Can any expert help me out? (You know, how I'm doing with coding conventions, comments, resource usage, etc.) Here's one of my latest programs: (I've asked a LOT of questions for this one :P )

Binary: www.sulfurmidis.com/mazzee-proto7-NORELEASE.zip (Open "MazzeeMaps.lmg" when it asks you for a map)

Source: www.sulfurmidis.com/Mazzee-source.zip

Thanks! Wink | ;-)

Lord Kixdemp
www.SulfurMidis.com
www.SulfurSoft.tk
[ftp://][http://][hotline://]tsfc.ath.cx

Nick_Kisialiou11-Jan-06 13:21

Nick_Kisialiou

11-Jan-06 13:21

There is always room for improvement. If you are interested to improve your code, you may look into:
Scott Meyers, "Effective C++", "More Effective C++", different editions.
Steve McConnell, "Code Complete", 2nd edition.
Bjarne Stroustrup, "The C++ Programming Language", 3rd edition.

Nick Kisialiou

Owner drawn11-Jan-06 17:15

Owner drawn

11-Jan-06 17:15

RainbowWyrm wrote:
Scott Meyers, "Effective C++", "More Effective C++", different editions

A real cool and effective book.

Hi 5 scott.

Jesus Loves

<marquee direction="up" height="50" scrolldelay="1" step="1" scrollamount="1" style="background:#ffaaaa">
--Owner Drawn
--Nothing special
--Defeat is temporary but surrender is permanent
--Never say quits
--Jesus is Lord

Prakash Nadar11-Jan-06 17:51

Prakash Nadar

11-Jan-06 17:51

very little hungarian notations used, somehow i like using it Smile | :)

.

though c++ allows declaration of variables inbetween statements, i would prefer all variables declaration at start of the block.

some good practice like if(x==NULL) can be coded as if(NULL == x).

Some comments were not required. like //Set it.

These are few that i can comment on.

-Prakash

Vipin Aravind11-Jan-06 23:22

Vipin Aravind

11-Jan-06 23:22

1) Remove all the global variables.
2) quite a lot of code replication. Refactor or Redesign.
3) Create a Dispatcher routine for class and do the forwarding for
keyboard events to appropriate routines each of them handling one type of event.
look back,think of extensibility also. What does it take for another person to easily add code
to your project? Iterate, rethink, look for better concepts,apply generic algorithms. use c++
standard library where you can.

Vipin - MVP

Eytukan12-Jan-06 0:43

Eytukan

12-Jan-06 0:43

you were vipinasda right?

0x0400:
"But your mind is very complex, very tricky. It makes simple things complicated. -- that's its work. And for centuries it has been trained for only one thing: to make things so complicated that your life becomes impossible."- Osho

<marquee scrollamount="1" scrolldelay="1" direction="up" height="10" step="1">--[V]--

Vipin Aravind12-Jan-06 1:32

Vipin Aravind

12-Jan-06 1:32

yes

Vipin - MVP

Eytukan12-Jan-06 1:37

Eytukan

12-Jan-06 1:37

you could have changed your screen name right? Unsure | :~

why you created a new account? that means your message
count'd start again from 0.

<marquee scrollamount="1" scrolldelay="1" direction="up" height="10" step="1">--[V]--

Vipin Aravind12-Jan-06 1:50

Vipin Aravind

12-Jan-06 1:50

hehe, no probs. I had an invalid email id associated with that screen name.

Vipin - MVP

ThatsAlok12-Jan-06 1:37

ThatsAlok

12-Jan-06 1:37

VivekuniQ wrote:
you were vipinasda right?

I believe you right!.. a suggestion if you don't mind please don''t make this forum lounge.. please..

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow

cheers,
Alok Gupta
VC Forum Q&A :- I/ IV

Eytukan12-Jan-06 1:47

Eytukan

12-Jan-06 1:47

do you think i should take him to lounge to say this? Frown | :(

or you felt something about the dialogs i had with toxcct? anyway i'd try talking less in general.

<marquee scrollamount="1" scrolldelay="1" direction="up" height="10" step="1">--[V]--

ThatsAlok12-Jan-06 1:57

ThatsAlok

12-Jan-06 1:57

VivekuniQ wrote:
do you think i should take him to lounge to say this?

sorry for hurting you!.... no probs people like you here Smile | :)

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow

cheers,
Alok Gupta
VC Forum Q&A :- I/ IV

Lord Kixdemp12-Jan-06 11:07

12-Jan-06 11:07

RainbowWyrm:

Thanks! I'll look them up on Sears next time I go! Big Grin | :-D

some good practice like if(x==NULL) can be coded as if(NULL == x).

You mean that the second way is better? Why? Confused | :confused:

quite a lot of code replication. Refactor or Redesign.

You mean the movement functions? You know of a shorter way? TELL ME! I've been looking for that for ages! Frown | :-(

Create a Dispatcher routine for class and do the forwarding for<br />
keyboard events to appropriate routines each of them handling one type of event.

For the game and map maker? Oops... I didn't know you could do events in non-dialog apps... Blush | :O

How?

_T_H_A_N_K_S_ you all! Wink | ;-)

Lord Kixdemp
www.SulfurMidis.com
www.SulfurSoft.tk
[ftp://][http://][hotline://]tsfc.ath.cx

OpenGL w/o MFC?

Lord Kixdemp11-Jan-06 10:38

11-Jan-06 10:38

Hello everyone! Big Grin | :-D

I just want to know how to do OpenGL with MinGW/GCC... I don't want to use VC++ for this, because I want to be portable... But how do I open a window in std C++, and how to I get rid of these errors?:

C:\>g++ Lesson1.cpp<br />
Lesson1.cpp:12:60: gl\glaux.h: No such file or directory<br />
<br />
C:\>g++ Lesson1.cpp<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0x31):Lesson1.cpp: undefined<br />
 reference to `glViewport@16'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0x40):Lesson1.cpp: undefined<br />
 reference to `glMatrixMode@4'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0x48):Lesson1.cpp: undefined<br />
 reference to `glLoadIdentity@0'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0x76):Lesson1.cpp: undefined<br />
 reference to `gluPerspective@32'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0x85):Lesson1.cpp: undefined<br />
 reference to `glMatrixMode@4'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0x8d):Lesson1.cpp: undefined<br />
 reference to `glLoadIdentity@0'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0xa2):Lesson1.cpp: undefined<br />
 reference to `glShadeModel@4'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0xcd):Lesson1.cpp: undefined<br />
 reference to `glClearColor@16'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0xda):Lesson1.cpp: undefined<br />
 reference to `glClearDepth@8'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0xe9):Lesson1.cpp: undefined<br />
 reference to `glEnable@4'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0xf8):Lesson1.cpp: undefined<br />
 reference to `glDepthFunc@4'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0x10f):Lesson1.cpp: undefine<br />
d reference to `glHint@8'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0x12c):Lesson1.cpp: undefine<br />
d reference to `glClear@4'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0x134):Lesson1.cpp: undefine<br />
d reference to `glLoadIdentity@0'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0x192):Lesson1.cpp: undefine<br />
d reference to `wglMakeCurrent@8'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0x1cd):Lesson1.cpp: undefine<br />
d reference to `wglDeleteContext@4'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0x672):Lesson1.cpp: undefine<br />
d reference to `ChoosePixelFormat@8'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0x6d6):Lesson1.cpp: undefine<br />
d reference to `SetPixelFormat@12'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0x725):Lesson1.cpp: undefine<br />
d reference to `wglCreateContext@4'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0x787):Lesson1.cpp: undefine<br />
d reference to `wglMakeCurrent@8'<br />
C:\DOCUME~1\DARTH_~1\LOCALS~1\Temp/ccEXbaaa.o(.text+0xabd):Lesson1.cpp: undefine<br />
d reference to `SwapBuffers@4'<br />
collect2: ld returned 1 exit status<br />
<br />
C:\>

Thanks!

Lord Kixdemp
www.SulfurMidis.com
www.SulfurSoft.tk
[ftp://][http://][hotline://]tsfc.ath.cx

Christian Graus11-Jan-06 10:52

Christian Graus

11-Jan-06 10:52

There is no such thing as a window in C++. Instead, each platform has it's own windowing library. You can move away from MFC and use Win32, which is a lot more work. You could also try TCM/TK ( I think that's what it's called ) or some other cross platform windowing library.

Have you seen the NeHe site ? He has OpenGL samples in just about every possible configuration, for most platforms.

Christian Graus - Microsoft MVP - C++

Lord Kixdemp11-Jan-06 11:17

11-Jan-06 11:17

Ooohh... I see then why some progs have separate sources for different platforms... Thanks! Big Grin | :-D

Lord Kixdemp
www.SulfurMidis.com
www.SulfurSoft.tk
[ftp://][http://][hotline://]tsfc.ath.cx

Curtis Schlak.11-Jan-06 13:22

Curtis Schlak.

11-Jan-06 13:22

If you use Dev-C++, you might want to check out the AllegroGL[^] devpak. It adds OpenGL routines to the Allegro game/graphics framework.

Alternatively, you could download the SDL[^] devpak. It has some very simple bindings to OpenGL that ease the creation of windows in which to use OpenGL.

"we must lose precision to make significant statements about complex systems."
-deKorvin on uncertainty

Lord Kixdemp12-Jan-06 12:33