Linux, Apache, MySQL, PHP

6-Apr-23 4:51

Previously with help of this forum I was able to fix Undefined variable errors using if(isset()) for PHP 8.1.

But this time I was unable to use if(isset()) to fix this error_log:

PHP Warning: Undefined variable $sendid in /home/____/check.php on line 70

Code line 70 is

PHP

printm($str.$sendid);

As above line connected with an array, how can I use isset? Please suggest me a solution.

Full code is given below:

PHP

<?php
include_once 'include/config.inc.php';
include_once 'include/options.inc.php';
include_once 'include/functions.inc.php';
include_once 'include/security.inc.php';
include_once 'templates/'.C_TEMP.'/config.php';
include_once 'templates/'.C_TEMP.'/header.php';

// if(!isset($id)||!isset($code)||!is_numeric($id)||!ereg('^[0-9A-Za-z]',$code)) {
if(!isset($id)||!isset($code)||!is_numeric($id)||!preg_match('/^[0-9A-Za-z]/',$code)) {  
// Code must content only chars and numbers :)
   printm($w[1].'3');
   }
 
/// Check for users with code expired and remove these users
$temp = mysqli_query($conn,"SELECT id FROM ".C_MYSQL_TEMP." WHERE date < DATE_SUB(NOW(), INTERVAL ".C_REG_DAYS." DAY)");
while ($i = mysqli_fetch_array($temp))
{
  $tmp = mysqli_query($conn,"SELECT pic1, pic2, pic3 FROM ".C_MYSQL_MEMBERS." WHERE id='".$i['id']."' and status = '0'");
  while ($j = mysqli_fetch_array($tmp))
  {
    for($k = 1; $k <= 3; $k++) 
  	{
			$tmpm = 'pic'.$k;
     	if (($j[$tmpm] != '') && (is_file(C_PATH.'/members/uploads/'.$j[$tmpm]))) 
			{
		 		@unlink (C_PATH.'/members/uploads/'.$j[$tmpm]);
			}	
    }
 		@mysqli_query($conn,"DELETE FROM ".C_MYSQL_MEMBERS." WHERE id='".$i['id']."' and status = '0'");
	}	
	@mysqli_query($conn,"DELETE FROM ".C_MYSQL_TEMP." WHERE id='".$i['id']."'");
}
/////////////


  
$temp=mysqli_query($conn,"SELECT count(*) as total FROM ".C_MYSQL_TEMP." WHERE id='".$id."' AND code='".$code."' AND date > DATE_SUB(NOW(), INTERVAL ".C_REG_DAYS." DAY)");
$row=mysqli_fetch_array($temp);
$count = $row['total'];
if($count != '0') {
   mysqli_query($conn,"DELETE FROM ".C_MYSQL_TEMP." WHERE id='".$id."' AND code='".$code."'");
   if(C_CHECK_REGISTER == '3') {
      $status='1';
      $str=$w[159];
   } 
   else {
      $status='7';
      $str = $w[46];
   } 
mysqli_query($conn,"UPDATE ".C_MYSQL_MEMBERS." SET status='".$status."' WHERE id='".$id."'");
$result = mysqli_query($conn,'SELECT email, password FROM '.C_MYSQL_MEMBERS.' WHERE id = \''.$id.'\'');
   while($i=mysqli_fetch_array($result) && $status == "7") {
$tm=array(C_SNAME);
$subject=template($w[195],$tm);
switch (C_ID) {
  
  case '2':
    $sendid=$i['email'];
  break;
  default: 
    $sendid=$id;
  break;
  }
  
$tm=array($sendid,'____',C_SNAME);
$message=template($w[588],$tm);
sendmail(C_FROMM,$i['email'],$subject,$message,'text');
}
printm($str.$sendid);
}

else {
     unset($id);
     printm($w[161]);
}
include_once 'templates/'.C_TEMP.'/footer.php';
 ?>

Richard MacCutchan6-Apr-23 6:06

6-Apr-23 6:06

The variable $sendid is not defined anywhere at module level, it is local to the following switch block:

PHP

switch (C_ID) {
  
  case '2':
    $sendid=$i['email'];
  break;
  default: 
    $sendid=$id;
  break;
  }

So once that block ends the variable no longer exists. Change it to something like:

PHP

$sendid = '';
switch (C_ID) {
  global $sendid; // tell switch to use the global variable
  case '2':
    $sendid=$i['email'];
  break;
  default: 
    $sendid=$id;
  break;
  }

You may like to review PHP: Variable scope - Manual[^].

Aruna KN8-Apr-23 5:06

8-Apr-23 5:06

I tried using your code suggestion but when user recieved verification email and clicked on verify link, it gives "HTTP ERROR 500".

Also error_log has following:

PHP Parse error: syntax error, unexpected 'global' (T_GLOBAL), expecting case (T_CASE) or default (T_DEFAULT) or '}'

Richard MacCutchan8-Apr-23 5:09

8-Apr-23 5:09

HTTP status 500 is an internal server error. So you need to look at your server logs, and maybe even add some debug code to find out what is going wrong.

Is this your code or did someone else write it?

Aruna KN8-Apr-23 5:19

8-Apr-23 5:19

Actually this code was written by an outside person.

I will check this further.

Aruna KN8-Apr-23 5:25

8-Apr-23 5:25

Actually issue has been fixed after adding your code suggestion to another place in the same PHP file:

PHP

$tm=array($sendid,'____',C_SNAME);
$message=template($w[588],$tm);
sendmail(C_FROMM,$i['email'],$subject,$message,'text');
}
$sendid = '';
global $sendid;
printm($str.$sendid);
}

Richard MacCutchan8-Apr-23 5:33

8-Apr-23 5:33

Udaya Arunakantha wrote:
this code was written by an outside person.

Then you have my sympathy. I have faced similar issues in the past and it is never easy.

Aruna KN8-Apr-23 5:55

PHP Warning: Undefined variable $conn

8-Apr-23 5:55

You are correct Richard, it's bit hard but your code suggestion worked for another code line in the same PHP code, see my last reply.

Aruna KN3-Apr-23 2:45

Re: PHP Warning: Undefined variable $conn

3-Apr-23 2:45

Following code is working fine up to PHP 7.4 but with PHP 8.1 it makes an error_log:

PHP Warning: Undefined variable $conn

Please suggest me a solution for this issue.

The relevant code line is:

PHP

if(!$conn) $conn = mysqli_connect(C_HOST,C_USER,C_PASS,C_BASE) or die($w[113]);

Full code of the function is:

PHP

function all_online_users()
{
    if(!$conn) $conn = mysqli_connect(C_HOST,C_USER,C_PASS,C_BASE) or die($w[113]);
    
  $sec = 300;
  //exit;
	if(isset($_SESSION['m']))
	{
		$user = is_numeric($_SESSION['m']) ? $_SESSION['m'] : 0;
		$MyAccess = 0;
       
	}
	else
	{
		$user = 0;
		$MyAccess = -1;
	}
	$ip = ($user == 0) ? ip2int(ip()) : 0;
  mysqli_query($conn,"DELETE FROM ".C_MYSQL_ONLINE_USERS." WHERE (time < DATE_SUB(NOW(), INTERVAL ".$sec." SECOND) AND NOW() > ".$sec.") or time > NOW()");
  $result = @mysqli_query($conn,"SELECT * FROM ".C_MYSQL_ONLINE_USERS);
	$cnt=array();$adduser=1;$addguest=1;$users=0;
	while($result && $i = mysqli_fetch_array($result))
	{
		$cnt[$i['usertype']] = (isset($cnt[$i['usertype']])) ? $cnt[$i['usertype']] + 1 : 1;
		If(($MyAccess >= 0) && ($user == $i['user'])) 
		{
			$adduser=$addguest=0;
		}
		If(($MyAccess < 0) && ($ip == $i['ip'])) 
		{
			$adduser=$addguest=0;
		}
	}
	if($adduser || $addguest)
	{
	    mysqli_query($conn,"INSERT INTO ".C_MYSQL_ONLINE_USERS." VALUES (NOW(),".$user.",'".$MyAccess."','".$ip."')");
		$cnt[$MyAccess] = (isset($cnt[$MyAccess])) ? $cnt[$MyAccess] + 1 : 1;
	}
	$k=0;while(isset($cnt[$k]))
	{
		$users = $cnt[$k] + $users;
		$k++;
	}
	if(isset($cnt['-1'])) define('ONLINE_GUESTS',$cnt['-1']);
	else define('ONLINE_GUESTS','0');
	define('ONLINE_USERS',$users);
}

all_online_users();

Richard MacCutchan3-Apr-23 2:50

Re: PHP Warning: Undefined variable $conn

3-Apr-23 2:50

Try using the isset function:

PHP

if(!isset($conn)) ...

See PHP: isset - Manual[^]

Aruna KN3-Apr-23 3:48

3-Apr-23 3:48

Thank you!

PHP 8.1 Count issue

Aruna KN30-Mar-23 0:06

30-Mar-23 0:06

I'm testing my old PHP code with PHP 8.1 (code is working fine with PHP 7.4).

Following line is not working on PHP 8.1

PHP

$total += count($row[0]);

I tried with strlen but it gives totally wrong result because this count is counting messages, size of inbox.

PHP

if (!defined("_COMMON_")) {echo "stop";exit;}
include_once($ld_engine_path."inc_connect.php");
$m_result = mysqli_query($conn,"select new_mails from ".$mysql_table_prefix."users where id=$is_regist") or die("database error<br>".mysqli_error($conn));
if (mysqli_num_rows($m_result))
	list($new_board_messages) = mysqli_fetch_array($m_result, MYSQLI_NUM);
if (!isset($new_board_messages)) $new_board_messages = "0";
mysqli_free_result($m_result);

$m_result = mysqli_query($conn,"select concat(subject,body) from ".$mysql_table_prefix."board where user_id=$is_regist") or die("database error: cannot retrieve mail-messages<br>".mysqli_error($conn));
$total = 0;
while ($row = mysqli_fetch_array($m_result, MYSQLI_NUM))
	$total += count($row[0]); // This line is not working on PHP 8.1

$percentage = round($total / $max_mailbox_size *100);
mysqli_free_result($m_result);

Richard MacCutchan30-Mar-23 0:45

30-Mar-23 0:45

What does "not working" mean, what are you trying to count?

Richard Deeming30-Mar-23 0:45

Richard Deeming

30-Mar-23 0:45

You haven't explained what "not working" means. The only notable difference documented in that function between v7 and v8 is:

PHP: count - Manual[^]:
Prior to PHP 8.0.0, if the parameter was neither an array nor an object that implements the Countable interface, 1 would be returned, unless value was null, in which case 0 would be returned.

So either you're now getting a TypeError where previously you were just counting the number of rows; you're now getting the sum of the string lengths, whereas previously you were counting the number of rows; or something else is happening, which you haven't explained.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Aruna KN30-Mar-23 1:38

30-Mar-23 1:38

You are correct, previously it was counting number of rows, now it's counting string lenghths which is not the requirement.

Please suggest me a solution

Richard Deeming30-Mar-23 2:53

Richard Deeming

30-Mar-23 2:53

Replace:

PHP

$total += count($row[0]);

with:

PHP

$total += 1;

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Aruna KN30-Mar-23 3:21

If command triggering at wrong time with PHP 8.1

30-Mar-23 3:21

Yes it worked!!

Thank you!

Aruna KN29-Mar-23 18:56

Re: If command triggering at wrong time with PHP 8.1

29-Mar-23 18:56

I'm trying to migrate my PHP code which is working on PHP 7.4 to PHP 8.1.

With PHP 8.1, following

PHP

if($message_id == "") {

code is triggering for logged in users too.

Can somebody point out common errors in this code?

PHP

require_once("inc_common.php");
include($engine_path."users_get_list.php");
set_variable("message_id");
set_variable("send_to");
set_variable("send_to_id");
$send_to_id = intval($send_to_id);
if (!$exists)  {
	$error_text = "$w_no_user";
	include($file_path."designes/".$design."/error_page.php");
	exit;
}

$u_ids = array();
$u_names = array();
$tmp_body = "";
$tmp_subject = "";

$info_message = "";

if($message_id == "") {
	if ($send_to!="") {
		$user_to_search = $send_to;
		include($ld_engine_path."users_search.php");
		if (!count($u_ids)) $info_message = "".str_replace("~",""".htmlspecialchars($send_to).""",$w_search_no_found)."<br>";
	}
	if ($send_to_id!="") {
		include("inc_user_class.php");
		$ttt = $is_regist;
		$is_regist = $send_to_id; #fake again :(
		include($ld_engine_path."users_get_object.php");
		$u_ids[] = $is_regist;
		$is_regist = $ttt;
		$u_names[] = $current_user->nickname;
	}
}
else {
	$board_operation = "reply";
	$id = $message_id;
	include($ld_engine_path."board_process_message.php");
	$u_ids[] = $board_message["from_id"];
	$u_names[] = $board_message["from"];
	$tmp_body =  str_replace("<br>","\n",$board_message["body"]);
	$tmp_body  = "\n\n_______ ".str_replace("~", $board_message["from"], $w_user_wrote)." ______\n$tmp_body";
	$tmp_subject = str_replace("\"",""","Re: ".$board_message["subject"]);
}

include($file_path."designes/".$design."/board_send.php");

modified 30-Mar-23 1:04am.

Richard Deeming29-Mar-23 21:22

Richard Deeming

29-Mar-23 21:22

The only place that variable is mentioned prior to the test is the set_variable("message_id"); line.

As far as I can see, that's not a built-in PHP function. So you need to check what that function is doing, and try to work out why its behaviour has changed in PHP 8.

We can't do that for you, since we can't see the function.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Re: If command triggering at wrong time with PHP 8.1

Aruna KN29-Mar-23 21:27

Re: If command triggering at wrong time with PHP 8.1

29-Mar-23 21:27

Thank you for the tip.

I will check it

Aruna KN29-Mar-23 22:15

Blank space or NULL with PHP 8.1

29-Mar-23 22:15

The issue has been resolved after adding null by replacing ""

Old code:

PHP

if ($send_to_id!="") {

New code:

PHP

if ($send_to_id!=null) {

But will it do the same?

Aruna KN14-Mar-23 22:57

Re: Blank space or NULL with PHP 8.1

14-Mar-23 22:57

I'm trying to migrate my PHP code which is working on PHP 7.4 to PHP 8.1.

With PHP 8.1, following "if" code executes Javascript but with PHP 7.4 it didn’t execute Js part and it was the normal state.

If I use null instead of “” after the != will it fix this? and is it correct?

PHP

if ($error != "") echo "<script>alert('".str_replace("<br>","\\n",str_replace("\n","\\n",str_replace("\r","",str_replace("'","\'",$error_text))))."');</script>";

Richard MacCutchan15-Mar-23 7:10

PHP Fatal error: Uncaught TypeError: count()

15-Mar-23 7:10

I have tried that code in version 7 and 8 and get the same results in both. You need to provide some more details.

Aruna KN10-Mar-23 20:17