The Weird and The Wonderful

The Weird and The Wonderful forum is a place to post Coding Horrors, Worst Practices, and the occasional flash of brilliance.

We all come across code that simply boggles the mind. Lazy kludges, embarrassing mistakes, horrid workarounds and developers just not quite getting it. And then somedays we come across - or write - the truly sublime.

Post your Best, your worst, and your most interesting. But please - no programming questions . This forum is purely for amusement and discussions on code snippets. All actual programming questions will be removed.

Re: .Net Core 6 jumps the shark

MSBassSinger7-Dec-21 8:53

MSBassSinger

7-Dec-21 8:53

Quote:
Code written with a using block is going to be significantly more "correct" than code that eschews it in favour of manual clean-up.

That comes across as more religion than a rational approach.

In order to illustrate my point, I can add the C# code I used for the test (in .NET 6.0) and the MSIL output of both. The unit test for the "using" statement took 28 ms, while the standard use took 18 ms. The MSIL for the "using" statement produced 47 lines of MSIL code, while the standard approach without "using" produced 31 lines of MSIL code.

I kept the IDisposable instance simple for this example.

In order to capture the constructor exception, the using block has to be wrapped with a try-catch.

The results of this test, combined with how I capture exception data and the runtime values associated with the exception (to significantly reduce support costs of the SDLC), is why I do not use the "using" statement in production apps. I do use it where appropriate in proof-of-concept and personal utilities, where support and performance is less of a concern.

IDisposable class:

namespace UsingTest
{
	public class DisposableClass : IDisposable
	{

		private Boolean m_blnDisposeHasBeenCalled = false;

		public DisposableClass()
		{
			Int32 denom = 20;
			Int32 numer = 0;
			Int32 result = denom / numer;

		}

		public String WhoIsIt()
		{
			return $"{Environment.UserDomainName}\\{Environment.UserName} on {Environment.MachineName} from {Environment.CurrentDirectory} on thread ID {Environment.CurrentManagedThreadId.ToString()}.";
		}

		#region IDisposable Implementation

		/// <summary>
		/// Implement the IDisposable.Dispose() method
		/// Developers are supposed to call this method when done with this Object.
		/// There is no guarantee when or if the GC will call it, so 
		/// the developer is responsible to.  GC does NOT clean up unmanaged 
		/// resources, such as COM objects, so we have to clean those up, too.
		/// 
		/// </summary>
		public void Dispose()
		{
			try
			{
				// Check if Dispose has already been called 
				// Only allow the consumer to call it once with effect.
				if (!m_blnDisposeHasBeenCalled)
				{
					// Call the overridden Dispose method that contains common cleanup code
					// Pass true to indicate that it is called from Dispose
					Dispose(true);

					// Prevent subsequent finalization of this Object. This is not needed 
					// because managed and unmanaged resources have been explicitly released
					GC.SuppressFinalize(this);
				}
			}
			catch (Exception exUnhandled)
			{
				exUnhandled.Data.Add("m_blnDisposeHasBeenCalled", m_blnDisposeHasBeenCalled.ToString());
				throw;
			}
		}

		/// <summary>
		/// Explicit Finalize method.  The GC calls Finalize, if it is called.
		/// There are times when the GC will fail to call Finalize, which is why it is up to 
		/// the developer to call Dispose() from the consumer Object.
		/// </summary>
		~DisposableClass()
		{
			// Call Dispose indicating that this is not coming from the public
			// dispose method.
			Dispose(false);
		}

		/// <summary>
		/// Clean up any resources being used.
		/// </summary>
		/// <param name="disposing">true if managed resources should be disposed; otherwise, false.</param>
		public void Dispose(Boolean disposing)
		{
			try
			{
				// Here we dispose and clean up the unmanaged objects and managed Object we created in code
				// that are not in the IContainer child Object of this object.
				// Unmanaged objects do not have a Dispose() method, so we just set them to null
				// to release the reference.  For managed objects, we call their respective Dispose()
				// methods and then release the reference.
				// DEVELOPER NOTE:
				//if (m_obj != null)
				//    {
				//    m_obj = null;
				//    }

				// Set the flag that Dispose has been called and executed.
				m_blnDisposeHasBeenCalled = true;
			}
			catch (Exception exUnhandled)
			{
				exUnhandled.Data.Add("m_blnDisposeHasBeenCalled", m_blnDisposeHasBeenCalled.ToString());
				throw;
			}
		}
		#endregion IDisposable Implementation
	}
}

Unit test with the "using" statement

[TestMethod]
public void UsingStatementTest()
{
    try
    {
        using (DisposableClass test = new())
        {
            try
            {
                String result = test.WhoIsIt();
            }
            catch (Exception ex)
            {
                Assert.Fail($"INNER: {ex.Message}");
            }
        }
    }
    catch (Exception exOuter)
    {
        Assert.Fail($"OUTER: {exOuter.Message}");
    }
}

Unit test with a standard approach:

[TestMethod]
public void StandardUsageTest()
{

    DisposableClass test = null;

    try
    {
        test = new();

        String result = test.WhoIsIt();
    }
    catch (Exception exOuter)
    {
        Assert.Fail($"ONLY: {exOuter.Message}");
    }
    finally
    {
        test?.Dispose();
    }
}

MSIL from the "using" statement text method:

.try
{
  IL_0000:  newobj     instance void [UsingTest]UsingTest.DisposableClass::.ctor()
  IL_0005:  stloc.0
  .try
  {
    .try
    {
      IL_0006:  ldloc.0
      IL_0007:  callvirt   instance string [UsingTest]UsingTest.DisposableClass::WhoIsIt()
      IL_000c:  pop
      IL_000d:  leave.s    IL_0027
    }  // end .try
    catch [System.Runtime]System.Exception
    {
      IL_000f:  stloc.1
      IL_0010:  ldstr      "INNER: "
      IL_0015:  ldloc.1
      IL_0016:  callvirt   instance string [System.Runtime]System.Exception::get_Message()
      IL_001b:  call       string [System.Runtime]System.String::Concat(string,
                                                                        string)
      IL_0020:  call       void [Microsoft.VisualStudio.TestPlatform.TestFramework]Microsoft.VisualStudio.TestTools.UnitTesting.Assert::Fail(string)
      IL_0025:  leave.s    IL_0027
    }  // end handler
    IL_0027:  leave.s    IL_0033
  }  // end .try
  finally
  {
    IL_0029:  ldloc.0
    IL_002a:  brfalse.s  IL_0032
    IL_002c:  ldloc.0
    IL_002d:  callvirt   instance void [System.Runtime]System.IDisposable::Dispose()
    IL_0032:  endfinally
  }  // end handler
  IL_0033:  leave.s    IL_004d
}  // end .try
catch [System.Runtime]System.Exception
{
  IL_0035:  stloc.2
  IL_0036:  ldstr      "OUTER: "
  IL_003b:  ldloc.2
  IL_003c:  callvirt   instance string [System.Runtime]System.Exception::get_Message()
  IL_0041:  call       string [System.Runtime]System.String::Concat(string,
                                                                    string)
  IL_0046:  call       void [Microsoft.VisualStudio.TestPlatform.TestFramework]Microsoft.VisualStudio.TestTools.UnitTesting.Assert::Fail(string)
  IL_004b:  leave.s    IL_004d
}  // end handler

MSIL for the unit test of the standard approach:

.try
{
  .try
  {
    IL_0002:  newobj     instance void [UsingTest]UsingTest.DisposableClass::.ctor()
    IL_0007:  stloc.0
    IL_0008:  ldloc.0
    IL_0009:  callvirt   instance string [UsingTest]UsingTest.DisposableClass::WhoIsIt()
    IL_000e:  pop
    IL_000f:  leave.s    IL_0033
  }  // end .try
  catch [System.Runtime]System.Exception
  {
    IL_0011:  stloc.1
    IL_0012:  ldstr      "ONLY: "
    IL_0017:  ldloc.1
    IL_0018:  callvirt   instance string [System.Runtime]System.Exception::get_Message()
    IL_001d:  call       string [System.Runtime]System.String::Concat(string,
                                                                      string)
    IL_0022:  call       void [Microsoft.VisualStudio.TestPlatform.TestFramework]Microsoft.VisualStudio.TestTools.UnitTesting.Assert::Fail(string)
    IL_0027:  leave.s    IL_0033
  }  // end handler
}  // end .try
finally
{
  IL_0029:  ldloc.0
  IL_002a:  brfalse.s  IL_0032
  IL_002c:  ldloc.0
  IL_002d:  call       instance void [UsingTest]UsingTest.DisposableClass::Dispose()
  IL_0032:  endfinally
}  // end handler

Re: .Net Core 6 jumps the shark

Richard Deeming7-Dec-21 22:10

Richard Deeming

7-Dec-21 22:10

MSBassSinger wrote:
That comes across as more religion than a rational approach.

Says the person trying to convince me that a using block swallows exceptions, whilst showing no evidence of it doing so. D'Oh! | :doh:

MSBassSinger wrote:
The unit test for the "using" statement took 28 ms, while the standard use took 18 ms.

So code with different behaviour, compiled in a debug build, has approximately 10ms difference in your tests?

Aside from the issue of micro-optimisation - any extra overhead from the using construct will be dwarfed by the cost of your real code - a unit test is not suitable for micro-benchmarks. You need to "warm up" your code, then measure performance over thousands of runs to get a meaningful result. Try using BenchmarkDotNet[^] to measure the code instead.

And while you're at it, fix your tests so that you're comparing the same - or at least comparable - code. Change your "standard" test to:

public void StandardUsageTest()
{
    try
    {
        DisposableClass test = null;
        try
        {
            test = new();
            try
            {
                String result = test.WhoIsIt();
            }
            catch (Exception ex)
            {
                Assert.Fail($"INNER: {ex.Message}");
            }
        }
        finally
        {
            test?.Dispose();
        }
    }
    catch (Exception exOuter)
    {
        Assert.Fail($"OUTER: {exOuter.Message}");
    }
}

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Re: .Net Core 6 jumps the shark

MSBassSinger8-Dec-21 5:17

MSBassSinger

8-Dec-21 5:17

I am sorry you do not fully understand what I wrote.

First, I did show that constructor exceptions are "swallowed", though I do admit that is a subjective term. To be more precise, constructor exceptions occur outside the MSIL exception handling. In order to catch the constructor exception, the "using" has to be wrapped in a try-catch of its own.

Second, because of what I just explained, the unit test that implements "using" needs the outer try-catch, while the other approach does not. The "using" approach results in nested try-catches, which is why it creates more lines of code to be executed. The coding for the unit tests is correct "as-is". The outer try-catch in your version of the StandardUsageTest() method is unnecessary.

Third, the execution time is not the point. I ran them several times, to account for any caching, and the time relationship remains the same. The point is that a very popular C# coding shortcut results in more lines of code to be executed (MSIL) than the other approach, and forecloses the opportunity to capture runtime values in the exception's Data dictionary within the MSIL code.

If you want to stick with the "using" statement, then do so. I am not trying to tell you or anyone else what they should do. I am presenting information for the "what" and "how" so that an objective person can decide for themselves. I provided the details, as was asked, and it completely and rationally supports my thesis. If you agree, fine. If you disagree with rational reasons you can explain, then educate us all. But since you are disagreeing without a rational basis, that is fine. You should continue to do things the way you think is best. But if you don't like my approach, just admit it is a personal preference to stick with the "using" statement. For example, if benefitting from more advanced exception handling does not provide a value for you, then implementing the "using" statement makes sense.

Re: .Net Core 6 jumps the shark

Richard Deeming8-Dec-21 6:18

Richard Deeming

8-Dec-21 6:18

MSBassSinger wrote:
To be more precise, constructor exceptions occur outside the MSIL exception handling. In order to catch the constructor exception, the "using" has to be wrapped in a try-catch of its own.

OK, that makes more sense now. Smile | :)

However, unless you specifically need different catch blocks for exceptions thrown from constructing the class and exceptions thrown from using the class, you can still get away with a single try..catch block in your code; it just needs to wrap the entire using block.

[TestMethod]
public void UsingStatementTest()
{
    try
    {
        using (DisposableClass test = new())
        {
            String result = test.WhoIsIt();
        }
    }
    catch (Exception exOuter)
    {
        Assert.Fail($"ONLY: {exOuter.Message}");
    }
}

You'll still have the try..finally from the using block nested within the try..catch block from your own code. But as you can see from the MSIL of your own StandardUsageTest method, a try..catch..finally block is implemented as a try..catch block wrapped in a try..finally block.

The IL, for comparison:

MSIL

  1  .method public hidebysig static 
  2      void StandardUsageTest () cil managed 
  3  {
  4      // Method begins at RVA 0x2104
  5      // Code size 70 (0x46)
  6      .maxstack 3
  7      .locals init (
  8          [0] class DisposableClass test,
  9          [1] string result,
 10          [2] class [System.Private.CoreLib]System.Exception exOuter
 11      )
 12  
 13      IL_0000: nop
 14      IL_0001: ldnull
 15      IL_0002: stloc.0
 16      .try
 17      {
 18          .try
 19          {
 20              IL_0003: nop
 21              IL_0004: newobj instance void DisposableClass::.ctor()
 22              IL_0009: stloc.0
 23              IL_000a: ldloc.0
 24              IL_000b: callvirt instance string DisposableClass::WhoIsIt()
 25              IL_0010: stloc.1
 26              IL_0011: nop
 27              IL_0012: leave.s IL_0034
 28          } // end .try
 29          catch [System.Private.CoreLib]System.Exception
 30          {
 31              IL_0014: stloc.2
 32              IL_0015: nop
 33              IL_0016: call class [System.Private.CoreLib]System.IO.TextWriter [System.Console]System.Console::get_Error()
 34              IL_001b: ldstr "ONLY: "
 35              IL_0020: ldloc.2
 36              IL_0021: callvirt instance string [System.Private.CoreLib]System.Exception::get_Message()
 37              IL_0026: call string [System.Private.CoreLib]System.String::Concat(string, string)
 38              IL_002b: callvirt instance void [System.Private.CoreLib]System.IO.TextWriter::WriteLine(string)
 39              IL_0030: nop
 40              IL_0031: nop
 41              IL_0032: leave.s IL_0034
 42          } // end handler
 43  
 44          // sequence point: hidden
 45          IL_0034: leave.s IL_0045
 46      } // end .try
 47      finally
 48      {
 49          IL_0036: nop
 50          IL_0037: ldloc.0
 51          IL_0038: brtrue.s IL_003c
 52  
 53          IL_003a: br.s IL_0043
 54  
 55          IL_003c: ldloc.0
 56          IL_003d: call instance void DisposableClass::Dispose()
 57          IL_0042: nop
 58  
 59          IL_0043: nop
 60          IL_0044: endfinally
 61      } // end handler
 62  
 63      IL_0045: ret
 64  } // end of method Program::StandardUsageTest

MSIL

  1  .method public hidebysig static 
  2      void UsingStatementTest () cil managed 
  3  {
  4      // Method begins at RVA 0x2174
  5      // Code size 66 (0x42)
  6      .maxstack 3
  7      .locals init (
  8          [0] class DisposableClass test,
  9          [1] string result,
 10          [2] class [System.Private.CoreLib]System.Exception exOuter
 11      )
 12  
 13      IL_0000: nop
 14      .try
 15      {
 16          IL_0001: nop
 17          IL_0002: newobj instance void DisposableClass::.ctor()
 18          IL_0007: stloc.0
 19          .try
 20          {
 21              IL_0008: nop
 22              IL_0009: ldloc.0
 23              IL_000a: callvirt instance string DisposableClass::WhoIsIt()
 24              IL_000f: stloc.1
 25              IL_0010: nop
 26              IL_0011: leave.s IL_001e
 27          } // end .try
 28          finally
 29          {
 30              // sequence point: hidden
 31              IL_0013: ldloc.0
 32              IL_0014: brfalse.s IL_001d
 33  
 34              IL_0016: ldloc.0
 35              IL_0017: callvirt instance void [System.Private.CoreLib]System.IDisposable::Dispose()
 36              IL_001c: nop
 37  
 38              // sequence point: hidden
 39              IL_001d: endfinally
 40          } // end handler
 41  
 42          IL_001e: nop
 43          IL_001f: leave.s IL_0041
 44      } // end .try
 45      catch [System.Private.CoreLib]System.Exception
 46      {
 47          IL_0021: stloc.2
 48          IL_0022: nop
 49          IL_0023: call class [System.Private.CoreLib]System.IO.TextWriter [System.Console]System.Console::get_Error()
 50          IL_0028: ldstr "ONLY: "
 51          IL_002d: ldloc.2
 52          IL_002e: callvirt instance string [System.Private.CoreLib]System.Exception::get_Message()
 53          IL_0033: call string [System.Private.CoreLib]System.String::Concat(string, string)
 54          IL_0038: callvirt instance void [System.Private.CoreLib]System.IO.TextWriter::WriteLine(string)
 55          IL_003d: nop
 56          IL_003e: nop
 57          IL_003f: leave.s IL_0041
 58      } // end handler
 59  
 60      IL_0041: ret
 61  } // end of method Program::UsingStatementTest

SharpLab[^]

Practically the same number of lines for both. Smile | :)

The one advantage I can see to your method is that, assuming the constructor hasn't thrown an exception, the instance will be available and not disposed-of in your catch block. With the using block wrapped in a try..catch block, the instance will already have been disposed of, and the variable will be out of scope, by the time you reach the catch block.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Re: .Net Core 6 jumps the shark

PIEBALDconsult11-Dec-21 8:50

PIEBALDconsult

11-Dec-21 8:50

If it actually matters, then...

Widget w = new Widget();

using ( w ) ...

Re: .Net Core 6 jumps the shark

zezba900029-Nov-21 9:35

zezba9000

29-Nov-21 9:35

Even VS 2022 does this. I hate it & its not the correct way to be writing anything in C#.

Re: .Net Core 6 jumps the shark

PIEBALDconsult11-Dec-21 8:42

PIEBALDconsult

11-Dec-21 8:42

Ooohhh... Perl...

What the heck are they teaching philosophers in Florida?

honey the codewitch28-Nov-21 5:54

honey the codewitch

28-Nov-21 5:54

Edit: My husband had to explain to me that "DOCTOR OF PHILOSOPHY" is what you write on all doctoral dissertations, regardless. This is what I get for not ever pursuing a degree. You may commence with the public shaming now.

I stumbled upon this on the internet while looking for information on LL(k) parsing

GENERAL CONTEXT-FREE RECOGNITION AND PARSING BASED ON VIABLE PREFIXES
By
D. CLAY WILSON
A DISSERTATION PRESENTED TO THE GRADUATE SCHOOL OF THE UNIVERSITY OF FLORIDA IN PARTIAL FULFILLMENT OF THE REQUIREMENTS FOR THE DEGREE OF DOCTOR OF PHILOSOPHY
UNIVERSITY OF FLORIDA

Philosophers are doing this stuff? Really? This is some heavy math and logic. Now, I can see it from the perspective of demonstrating a grasp of the principles of logic, but this seems like overkill, especially given the math involved! This is something I expect of a Doctor of Computer Science, not a Philosophy PhD.

Real programmers use butterflies

modified 28-Nov-21 12:15pm.

Re: What the heck are they teaching philosophers in Florida?

trønderen28-Nov-21 6:04

trønderen

28-Nov-21 6:04

And no smiley? Smile | :)

(I take for granted that you know the meaning of "PhD".)

Re: What the heck are they teaching philosophers in Florida?

honey the codewitch28-Nov-21 6:05

honey the codewitch

28-Nov-21 6:05

Yes, but it's early so you'll have to forgive my transgression.

moar coffee. (edited)

Real programmers use butterflies

Re: What the heck are they teaching philosophers in Florida?

honey the codewitch28-Nov-21 6:08

honey the codewitch

28-Nov-21 6:08

Wait a minute, are you saying this dissertation is probably for a CS degree?

Real programmers use butterflies

Re: What the heck are they teaching philosophers in Florida?

Daniel Pfeffer28-Nov-21 21:37

Daniel Pfeffer

28-Nov-21 21:37

trønderen wrote:
I take for granted that you know the meaning of "PhD".

Piled higher and deeper? Smile | :)

Freedom is the freedom to say that two plus two make four. If that is granted, all else follows.
-- 6079 Smith W.

Re: What the heck are they teaching philosophers in Florida?

Greg Utas28-Nov-21 6:06

Greg Utas

28-Nov-21 6:06

"PhD" stands for Doctor of Philosophy and is a generic term used in many disciplines, including Computer Science, for doctoral degrees. Some universities used ScD (Doctor of Science) instead.

Robust Services Core | Software Techniques for Lemmings | Articles
The fox knows many things, but the hedgehog knows one big thing.

Re: What the heck are they teaching philosophers in Florida?

honey the codewitch28-Nov-21 6:06

honey the codewitch

28-Nov-21 6:06

I meant to put PhD after philosophy, not computer science. it's early here and I haven't had enough coffee. I'm fixing that. (Edited since)

Edit: Wait. I think I misunderstood you. Are you saying this dissertation was probably for a Comp Sci doctorate?

Real programmers use butterflies

Re: What the heck are they teaching philosophers in Florida?

Greg Utas28-Nov-21 6:49

Greg Utas

28-Nov-21 6:49

Yes, almost certainly for a Comp Sci doctorate.

Robust Services Core | Software Techniques for Lemmings | Articles
The fox knows many things, but the hedgehog knows one big thing.

Re: What the heck are they teaching philosophers in Florida?

honey the codewitch28-Nov-21 6:50

honey the codewitch

28-Nov-21 6:50

Yeah my hubby had to explain how this worked to me.

Real programmers use butterflies

Re: What the heck are they teaching philosophers in Florida?

Greg Utas28-Nov-21 6:53

Greg Utas

28-Nov-21 6:53

I'm glad that got sorted so there won't be any confusion when some university calls to give you an honorary one!

Robust Services Core | Software Techniques for Lemmings | Articles
The fox knows many things, but the hedgehog knows one big thing.

modified 29-Nov-21 7:01am.

Re: What the heck are they teaching philosophers in Florida?

Marc Clifton28-Nov-21 7:01

Marc Clifton

28-Nov-21 7:01

There are no philosophers in Florida. The alligators ate most of them, and the rest realized that FL is not the place to live if you are practicing philosophy.

Latest Articles:
DivWindow: Size, drag, minimize, and maximize floating windows with layout persistence

It is called a Doctorate of Philosophy because...

Michael Breeden29-Nov-21 1:04

Michael Breeden

29-Nov-21 1:04

You receive a Doctorate of Philosophy when presenting new work proving that you can extend science. It is not considered science though when you submit it. It becomes science when it is peer-reviewed and has gone through the other procedures that get it accepted into what is considered the body of science. Until then, your work is considered philosophy.

Re: What the heck are they teaching philosophers in Florida?

obermd29-Nov-21 6:39

obermd

29-Nov-21 6:39

Just remember when dealing with thesis papers:

BS => Bull S.
MS => More of the Same
PhD => Piled Higher and Deeper

Smile | :)

Re: What the heck are they teaching philosophers in Florida?

Chris Maunder29-Nov-21 19:16

Chris Maunder

29-Nov-21 19:16

On a serious note, I admire people who can own their gaffs proudly. Much respect.

cheers
Chris Maunder

Re: What the heck are they teaching philosophers in Florida?

honey the codewitch29-Nov-21 20:53

honey the codewitch

29-Nov-21 20:53

A little late to disguise myself and slink away at this point anyway. You people recognize me. Laugh | :laugh:

Real programmers use butterflies

Message Closed

28-Feb-22 1:43

zaamindas

28-Feb-22 1:43

Message Closed

Does anyone recognized this "decryption" algorithm?

Gary Wheeler23-Nov-21 9:55

Gary Wheeler

23-Nov-21 9:55

I'm reverse-engineering some code, and I've found this as the "decryption" for some data:

unsigned char encrypted[...];
unsigned char decrypted[sizeof(encrypted)];

for (int i = 0; i < (int)sizeof(encrypted); i += 4)
{
    DWORD temporary = ((((DWORD)encrypted[i + 0]) << 24) & 0xFF000000)  |
                      ((((DWORD)encrypted[i + 1]) << 16) & 0x00FF0000)  |
                      ((((DWORD)encrypted[i + 2]) <<  8) & 0x0000FF00)  |
                      ((((DWORD)encrypted[i + 3]) <<  0) & 0x000000FF);

    temporary = temporary * 487709855; // I hate magic numbers
    
    decrypted[i + 0] = (BYTE)((temporary & 0xFF000000) >> 24);
    decrypted[i + 1] = (BYTE)((temporary & 0x00FF0000) >> 16);
    decrypted[i + 2] = (BYTE)((temporary & 0x0000FF00) >>  8);
    decrypted[i + 3] = (BYTE)((temporary & 0x000000FF) >>  0);
}

I remember seeing this sort of thing before, but I don't remember what it's called. Any suggestions?

Software Zen: delete this;

Re: Does anyone recognized this "decryption" algorithm?

PIEBALDconsult23-Nov-21 10:10

PIEBALDconsult

23-Nov-21 10:10

Obscurity?

Edit, how about:

Affine cipher - Wikipedia[^]

Further edit:

If it is Affine, is it Quadruple-Affine? Effectively using a different key for each of four bytes all at once?

modified 24-Nov-21 16:59pm.

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.