The Weird and The Wonderful

1-Oct-13 0:27

A padded number in a file name!

// Set to padded number
int fileCount = Directory.GetFiles("[censored]", "*.csv", SearchOption.AllDirectories).Length + 1;
string fileCountStr = (fileCount <= 999 ? fileCount <= 99 ? fileCount <= 9 ? "000" : "00" : "0" : "") + fileCount;

I think this should win an award for readability in a triply-nested ternary condition Roll eyes | :rolleyes:

Nagy Vilmos1-Oct-13 0:49

Nagy Vilmos

1-Oct-13 0:49

And what about when someone deletes 085.csv? Big Grin | :-D

speramus in juniperus

SortaCore1-Oct-13 0:55

1-Oct-13 0:55

Oh, don't worry. None of the accounts have delete permissions. Unsure | :~

PIEBALDconsult1-Oct-13 4:18

1-Oct-13 4:18

It's so good to know that the hard work of the developers of String.PadLeft[^] and Int32.ToString[^] is providing so much joy to so many, other than you.

By the way, what language is that? It can't be C#, or did you also override the + operator? OMG | :OMG:

Richard Deeming1-Oct-13 4:27

1-Oct-13 4:27

PIEBALDconsult wrote:
It can't be C#

Really?

http://msdn.microsoft.com/en-GB/library/k1a63xkz.aspx[^]

When one or both operands are of type string, + concatenates the string representations of the operands.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

PIEBALDconsult1-Oct-13 6:27

1-Oct-13 6:27

Richard Deeming wrote:
When one or both operands are of type string

Yes, and are they?

Richard Deeming1-Oct-13 7:09

1-Oct-13 7:09

PIEBALDconsult wrote:
Yes, and are they?

Yes, the first operand is a string. It's the result of the ternary operator:

fileCount <= 999 
    ? fileCount <= 99 
        ? fileCount <= 9 
            ? "000" 
            : "00"
        : "0"
    : ""

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

PIEBALDconsult1-Oct-13 10:43

1-Oct-13 10:43

And the second?

Richard Deeming1-Oct-13 10:57

1-Oct-13 10:57

PIEBALDconsult wrote:
And the second?

Doesn't matter. The documentation clearly states, "When one or both operands are of type string...", so the type of the other operand is irrelevant.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Big Daddy Farang1-Oct-13 11:23

Big Daddy Farang

1-Oct-13 11:23

I missed that the first time also. Smile | :)

BDF

The internet makes dumb people dumber and clever people cleverer.
-- PaulowniaK

PIEBALDconsult1-Oct-13 13:44

1-Oct-13 13:44

Where do you see that in the documentation? I don't even see + in the documentation.

And what idiot thought that was a good idea? WTF | :WTF:

Time to find a new language; this one's becoming VB. Dead | X|

Edit: I finally found it; it's not documented with String; what a POS. Thumbs Down | :thumbsdown:

I'm fairly sure that no self-respecting C# professional uses it that way.

modified 1-Oct-13 20:03pm.

Richard Deeming2-Oct-13 1:44

2-Oct-13 1:44

It's the link that I posted in my previous message:
http://msdn.microsoft.com/en-GB/library/k1a63xkz.aspx[^]

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

SortaCore2-Oct-13 2:07

2-Oct-13 2:07

PIEBALDconsult wrote:
I'm fairly sure that no self-respecting C# professional uses it that way.

Heh, I go for the shorter version. If it doesn't make sense with a mishmash of ints/strings I use brackets or ToString() to clarify.

int i = 124, j = 253;
string s = "JD" + i + j;   // Could be two things and no one wants to look up operator precedence, so instead...
string t = "JD" + (i + j);

But yeah, usually I don't bother.
Although, theoretically, I could now do

string s = 0;      // won't initialise
string t = "" + 0; // will work fine O.o

So, let's get back to self-respecting... Roll eyes | :rolleyes:

PIEBALDconsult2-Oct-13 3:12

2-Oct-13 3:12

string t = System.String.Format ( "JD{0}" , i + j ) ;

Richard Deeming2-Oct-13 3:19

2-Oct-13 3:19

Make that:

string t = string.Format(CultureInfo.InvariantCulture, "JD{0:D}", i + j);

You typically don't want culture-specific formatting or group separators in the result.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

PIEBALDconsult2-Oct-13 3:28

2-Oct-13 3:28

I've never had that problem.

SortaCore2-Oct-13 9:21

2-Oct-13 9:21

And of course don't forget to set the string to "" at the end, else if the garbage collector is a little slow you might run out of memory!
Better yet, just keep re-using global strings.

SortaCore1-Oct-13 10:48

1-Oct-13 10:48

I think I wrote it in one of those points in the week where I just couldn't think. Dead | X|

Methinks I'll replace it tomorrow.