The Weird and The Wonderful

Nathan D Cook wrote:

 
First, why check for null every time and a ToString().ToUpper() every
time? Why not just check it once and set a string that we can check?

Nathan D Cook wrote:

Third, in the VoidPayment function why are we doing yet another ToUpper when we
know we are passing in either a capitalized PAID or ADJUSTED string? VoidPayment
is only called from those two spots, and it's not really a function that should
be called elsewhere or added anywhere else later.

if (combo.SelectedItem.ToString() != null)
   {
   switch (combo.SelectedItem.ToString().ToUpper())
      {
      case "APPROVED":
         ...
         break;
      case "UNAPPROVED":
         ...
         break;
...

string selection = null;
if (combo.SelectedItem != null) selection = combo.SelectedItem.ToString().ToUpper();
switch (selection)
{
  case "APPROVED":
    //...
    break;
  case "UNAPPROVED":
    //...
    break;
  default:
    //...
    break;
}

_field = string.Copy(s.Field);

_field = s.Field

public class Form
{
    Form() {

    }
 }

public class SurveyController : Controller
{
    public SurveyController() {

        Form form = new Form();
    }

}

Error	1	'FormularioAvaliacaoSaude.Models.Formulario.Formulario()' is inaccessible due to its protection level	C:\workspace\FormularioAvaliacaoSaude\FormularioAvaliacaoSaude\Controllers\PesquisaController.cs	22	31	FormularioAvaliacaoSaude

MSDN wrote:

The declaration of the empty constructor prevents the automatic generation of a default constructor. Note that if you don't use an access modifier with the constructor it will still be private by default. However, the private modifier is usually used explicitly to make it clear that the class cannot be instantiated.