|
It's an int, nothing but the int, so help me glod.
|
|
|
|
|
In Visual C++ MFC, there's a CString. And to check if a CString has values, it's "if (!str.IsEmpty()).
So the QA person, who had a degree from Stevens Institute of Technology, sat there and argued with me for 2 HOURS, and brought it all the way up to the VP, because it wasn't the "obvious way to do the logical operation." Didn't matter at all that is was the way Microsoft implemented it, and we had to use it.
|
|
|
|
|
Hopefully you'll be gratified to learn I just used this as an example to one of my students, introducing him to refactoring poor code and [specifically] bad if statements.
|
|
|
|
|
If it stops anybody else making the same mistake, then I'm glad to help.
|
|
|
|
|
Ahhh, teaching him a lifetime skill huh? I hope most of us, who read bad code go:
Is it working correctly?
if no, write a bug and hope someone assigns you ownership so you can fix it.
Hope it's approved, and whoever is assigned the bug takes the time to fix it.
else: Is this egregiously bad, causing performance issues or something else that might cause severe system problems?
if yes, write a bug etc.
else: Do you work in a best practice shop and this violates a best p?
if yes, write a bug etc.
else: Do you work in a best practice shop
if yes, suggest a new best practice reffering to your source and hope it is adopted and the source is addressed.
else: ask yourself if it is worth suggesting to your manager one more thing that could be improved.
if yes, wow, you have a manager who listens to you and acts on your suggestions, or you are working for a new manager, or you are a perrenial optimist.
else: Join the regular ranks, shake your head about the code you see, and go on with your life.
Maybe I have a gift for seeing bad logic.
It took me three days to convince someone this was a bug:
if (current_thread_count <= maximum_thread_count + thread_count_to_add)
add_new_threads(thread_count_to_add);
It took asking for the specification document because I was told this met specifications. I agreed that this exactly met specifications, the only problem is, that specifications aren't asking for what is intended. Huh, what? It took going to the lap, finding out what values they were configured for (maximum_thread_count=120, thread_count_to_add=25) and showing what that would do. (Say your current count is 119, if you add 25 more, the current count would go to 144. You don't want that to happen, right? "Right." Well, 119 is less than 145... "How did you come up with 145" Well, the first value is 120, the second value is 25, added together they are 145. Well, the light dawns, but we continue the exercise proving that the count would go up to 169 because the loop is immediate when if the statement was true and the request is relatively immediate. In theory the count could go to 170.
Anyway, if there is a heavy enough load the service machines should blow up with a thread allocation error. The lab guy who gave us the numbers, pipes up "Oh, yea, we have that problem all the time!"
I'm thinking it would have been nice to know that the problem existed instead of just reading C# code to get up to speed on what the group was doing while waiting for my next assignment. Also, how can the specs get through code review. The person creating the code doesn't see it. I have so much trouble convincing someone there is a problem. I'm passively reading it and it's so bad it almost hurts my eyes.
I heard the problem was significantly reduced, but still occurs. I was on an assignment so it can wait. (Just like everyone else in the group while I was there.)
|
|
|
|
|
Your alternate solution is just as valid. To me the original is perfectly readable, but I'd prefer:
if (value > 0) {//do something useful}
else (throw ...);
Since you have CDO, this is probably too much reading to do before you get to the else statement. 
|
|
|
|
|
It is accurate, but inelegant!
------------------------------------
I will never again mention that I was the poster of the One Millionth Lounge Post, nor that it was complete drivel. Dalek Dave
CCC League Table Link
CCC Link[ ^]
|
|
|
|
|
Firstly, with most languages both examples will produce the same code, so there is no need to prefer one from a performance standpoint. So the choice comes down to clarity and depending on the specific situation (and perhaps the individual) either one could be preferable. The first example has the advantage that it more directly reflects the comment. I don't really regard this as a coding horror.
Steve
|
|
|
|
|
Found this in production code. Variable names changed to protect the innocent:
For i As Integer = 0 To 0
Dim lb As LinkButton = GetLinkButton(i)
Next
Future proofing the code?
|
|
|
|
|
Scalablility 
|
|
|
|
|
Optimization... reduce the number of iterations until you achieve reasonable performantcy*.
* I just made that up.
|
|
|
|
|
Boss said to the newby, "take this code and make it run faster."
Gary
|
|
|
|
|
Warning: The Following is a Rant.
From time to time I get into the religious 'To Stored Proc or not To Stored Proc' argument.
Let me confess right now. As much as I appreciate all the pro's of Stored Procs, I still prefer to not use them when it can be avoided.
It may be a technically inferior solution but I still prefer to create functions and subs in my VB or C# code that perform the equivalent task.
I have finally decided that the reason for my bias is that the greatest Code Horrors I deal with now are badly written Packages and Stored Procs etc.
It's a bloody nightmare.
And to top it all, I regularly have to deal with the fact that the features needed to debug aren't installed, or they're running some cut down version of a DBMS.
So I'm debugging this rats maze of code using techniques that I haven't used since I wrote Basic on my Sinclair Spectrum. Plug in Values. Run. Check Log File. Nothing Happened. Plug in Values. Run. Check Log File. Something unexpected happened. repeat to fade.
Right now I'm trawling through the PL/SQL code of a very large globally known company. Honestly I've decided that what I'm looking at is a cast off from that team of monkeys that are working on the complete works of Shakespeare.
I also regularly have to deal with Databases that contain hundreds of functions, procs and views where nobody knows if they are needed anymore but everybody is terrified to modify or remove any of them.
I see companies who spawn a new copy every time a proc needs to be changed (just in case) and use that.
I see companies who have no Gold version of their DB. When they need a DB either for test or for a new Production site, they just copy an existing production site.
As for version control. It seems DB Objects live in some abstract zone, like International waters that aren't covered by the treaties that cover version control.
This is no way to live.
Thanks for letting me get that off my chest.
Now back to the rats maze.
-Richard
Hit any user to continue.
|
|
|
|
|
Richard A. Dalton wrote: I have finally decided that the reason for my bias is that the greatest Code Horrors I deal with now are badly written Packages and Stored Procs etc.
But THIS is the problem, not really the 'concepts' of stored procedures or packages. The same can be said about regular code and writing shared libraries and using objects.
Poorly written anything is junk.
You can’t blame the tool or the concept really.
Blame the user of the concept/tool = YES
Blame the reviewer of the designer = YES
Blame the reviewer of the implementation = YES
You can use the best tools on the best platform using the best agreed upon methodologies and still write code that is ugly.
|
|
|
|
|
Ray Cassick wrote: You can use the best tools on the best platform using the best agreed upon methodologies and still write code that is ugly.
|
|
|
|
|
I agree 100%, there is too many drawbacks on using adhock queries in the client application that most of the times prevents scaling an application. what if you have a table holding customer records, and you want to move the address columns to a new table to introduce multiple addresses for a customer.
how are you going to due this when you have a web app, thick client, analysis cubes, reporting that will all require change and how do you manage deploying this change out?
by preventing adhock or table direct queries all one would have to due is modify a few views and procs.
secondly how can you ensure that all the adhock queries in all applications that are consuming this database are all using indexes, common business logic and formulas. and how would you trace down a poorly written adhock query that is table scanning, how do you go about fixing it and deploying it without impacting other user applications.
my developers may only select from a view or call a proc from any application period....
look on the bright side, you have an opportunity to catalog all objects and send out impact statements to understand who is using what and also have an opportunity to find synergies between your development teams to come to a common process
|
|
|
|
|
Well, in a well designed application, the data access logic would be in a separate library called from all you clients. So you'd change it there (similar to just changing the SP). The change is still in one place - but it is in code, that the developer can find, debug, version control, etc. And a quick scan of the code can find the references - no orphaned SP hanging out there.
|
|
|
|
|
You are echoing exactly the point I made about VB. It's the developers not the tools that are the problem.
Yes. You can write good, clear PL/SQL (ish).
Yes. All of the problems I have mentioned are the fault
of humans, not the software, not the language.
BUT.......
The level of expertise generally for PL/SQL or T/SQL or
indeed databases in general seems so poor that I consider them toxic pieces of technology.
Right now I'm working on Code that comes from...ORACLE.
Surely to goodness if any company should care about turning out a decent stab at good PL/SQL it should be ORACLE.
It's a fricken mess. I can't stress enough just how bad this code is. I've been in this business for over 14 years and this is genuinely the worst code of any kind that I have ever worked with. I will go so far as to say that it is impossible to work with.
Now. As bad as the code can be in VB or ASP.Net or C++ or Whatever, at least I have decent relatively mature and solid debugging tools.
At least by and large source code tends to be under source control.
At lest by and large there tend not to be multiple different versions of the same functions (ish).
Also, the nature of PL/SQL and T/SQL etc are that they are In my opinion fundamentally ugly languages. Verbose and difficult to work with when doing anything but the most basic tasks.
The Development Tools seem geared towards light admin rather than heavy development.
Perhaps, with the right set of tools, life could be easier, but far from the right set of tools, most companies I visit don't even have a basic set of tools. They set up the cheapest simplest configuration that gets them moving. Need Debugging? Screw you Jack...create some log files.
So we have a number of problems coming together in a perfect storm.
1. Developers DB skills beyond the absolute basics are poor.
Attitude seems to be...DB? Pff How hard can that be?
It's just SQL right?
2. Most who can write PL/SQL or T/SQL have no concept of
what quality code is. Indeed I don't think they see
their PL/SQL as code, and they don't feel obliged to
observe ANY rules of craftsmanship.
3. Development and Debugging tools are poor at best.
4. Most clients seem confused about how to integrate DB
development into their overall development process.
And seem reluctant to heed advice on how to do so.
5. There can and often is a turf war between developers and
DBA's that make a difficult situation worse.
Overall...my feeling is...it's not worth it.
Develop as much as possible in Visual Studio or whatever
IDE you are using. Keep as much as possible within your
control.
Treat the DB as a data store only
*unless* the client has the infrastructure and the expertise to support using the DB for more.
-Rd
Hit any user to continue.
|
|
|
|
|
Richard A. Dalton wrote: Treat the DB as a data store only *unless* the client has the infrastructure and the expertise to support using the DB for more.
Agreed. Or unless, you control the DB as well.
Richard A. Dalton wrote: Screw you Jack...create some log files.
Well, at least you're not named Jack. 
|
|
|
|
|
Andrew Rissing wrote: Agreed. Or unless, you control the DB as well.
I think this small modification of my original point answers the points raised by PoweredByOtgc above.
Yes. There are types of applications and applications of a certain scale where it's very hard to get by without using the additional powers of the DB Server.
but...
If you are building one of those applications you damn well better be in an environment that can handle it and know what you are doing.
Using the old 80/20 rule. 80% of apps can probably get by with using the DB as a pure dumb data store, and in my opinion that should probably be the default approach.
The DB is too important. It's the foundation of all your systems. It's too important to be screwed around with by code monkeys who assume that because they can write an SQL query and know what an index is they can write Stored Procs, Packages and all manner of things.
I'll say it right now, hand on heart, I've been writing PL/SQL and T/SQL for years and in my opinion even I shouldn't be. I don't believe I am skilled enough. It's a specialised area that needs a hell of a lot more respect and perhaps a sprinkling of fear.
Nobody assumes that because you can use Javascript you must therefore be able to write enterprise apps in Java. Yet that seems to be the assumption when considering SQL Queries and PL/SQL.
Part of the problem is the notion that YOU MUST USE STORED PROCS. It drives inexperienced codes down a road they shouldn't be on.
I think far from encouraging programmers to work with stored procs by default. The default approach should be
to work with AdHoc queries entirely in your language of choice.
When you advance to a level where you can work effectively in PL/SQL and T/SQL you would probably be working in that 20% or less of apps that really need that.
And that PL/SQL T/SQL track should be a clearly defined path that you follow, not something you fell into.
Bottom line folks...can we pleeease get a bit of software craftsmanship in the DB.
Anyhoo, thanks for listening. It's been a help.
-Rd
Hit any user to continue.
|
|
|
|
|
1. Developers DB skills beyond the absolute basics are poor. Attitude seems to be...DB? Pff How hard can that be? It's just SQL right?
That's why a development team should hire GOOD developers. Anyone that say this is IMHO NOT a 'good developer'.
2. Most who can write PL/SQL or T/SQL have no concept of what quality code is. Indeed I don't think they see their PL/SQL as code, and they don't feel obliged to observe ANY rules of craftsmanship.
That's why you should hire GOOD DBAs. And by Good I don't mean 'can write a query with joins and that does not use Select * all over the place. I mean a real DBA. I would agree that many don not feel they are writing code, but add to that the fact that ANY company that has ANY change management or review process SHOULD be running these resources through a code review process.
3. Development and Debugging tools are poor at best.
I don't know if I agree here. I have seen some pretty good tools. I am getting partial to Toad lately, and the SQL Enterprise manager does some decent performance monitoring metrics. The large gap I see when things like web services must run multiple queries against disparate Dbs from different vendors and do aggregation before returning result sets, but that is just something inherent in using multiple platforms like I run up against all th times (IE: Mixing data from DB2, SQL and Oracle SPs).
4. Most clients seem confused about how to integrate DB development into their overall development process. And seem reluctant to heed advice on how to do so.
Again, people problem that can be solved (IE: The idiots need to be fired) and not really a technology issue.
5. There can and often is a turf war between developers and DBA's that make a difficult situation worse.
I hear that but again, people problem.
I seem to remember hearing a discussion VERY similar to this way way back in the days when OOP was 'invented' and people started to discuss the n-tier model and how UI side developers were never going to 'get' how their design impacts the overall use of the app so code jockeys should just be allowed to write it all.
Man, what comes around goes around
But I DO understand it... been knee deep in it... lived through it...
|
|
|
|
|
Ray Cassick wrote: That's why a development team should hire GOOD developers.
Yes. Of course. As I've said, no matter what the tool ultimately it comes down to the people.
But I'm coming from the perspective of 14 years of being brought into existing projects, or starting new projects in existing teams.
I don't have the option (generally) of getting the team and the infrastructure the way I like.
I am seriously considering throwing my hat at it and I have spoken to a few companies about joining them full time, but I'll only do it if I know I'm joining somewhere that is doing software properly (or at least seriously trying to hit that ideal).
I've reached the point where I'll take the pay cut if I have to in order to work with good guys and gals.
In the meantime I'm faced with debugging our profession as best I can.
Boy, as a profesion we sure do suck.
Right now I'm faced with the problems that aren't even the fault of the developers surrounding me. There is nobody to fire because the code that's screwing me up now comes from a Vendor, and no, dropping the vendor isn't an option either.
And Yes, even if my notion of keeping developers away from the DB for as long as possible were to take hold in this company it wouldn't fix the problem of Vendors shipping bad DB Code.
But it would be a start.
We need to make a start.
The Packages and Procs and Views that surround a Database are an API. They need to be given the same respect as any API.
They are perceived as something less than an API. Something more pliable than an API.
I so often hear the excuse that you should put logic into stored procs because Stored Procs are easier to change than code.
THEY ARE NOT. They are exactly as difficult to change as code. You have the same difficulties of keeping backward compatibility of interfaces.
I would contend that the "belief" that the DB is easier to change than code is a big part of the problem.
I'm not saying you should't use Procs packages etc.
I'm just saying that it shouldn't be the no-brainer people seem to want it to be. Particularly when you or your team are no-brainers.
-Rd
Hit any user to continue.
|
|
|
|
|
"Treat the DB as a data store only"
Sorry but that’s not any better a philosophy to follow either unless your DB and use load is so small that performance doesn't matter.
The problem is one of 2 competing camps in which few are able to work with the other, less are knowledgeable about both and even fewer can properly work in and properly use each as it is intended to be.
Your right in that the DB should be your data store and your App should be your interface to the user but you don't place your business logic in your app just because you don’t like or aren't familiar with using T-SQ/ or PL-SQL. When procedural or OOP types trying to do their own IUD's (Inserts, Updates and/or Deletes) they almost always resort to that most foul of all things in SQL programming the CURSOR. They do this because they get the CURSOR concept and so they can use it with far less effort. The problem is that CURSOR is Latin for "Slow this Mo-Fo Down" and so performance and good design get thrown out like last year’s lowest rated reality TV show.
The answer is if you know how to use both, the OOP/Procedural app side and the RBDMS/SQL side then use each as they should be. If you are one who likes CURSORS then you got no business writing DML statements. On the flip side if you can't properly design and instantiate classes and objects or worse you ask what the difference is then you got no business in Visual Studio. Experience however shows that more often you have developer types doing too much DML coding in their app instead of leaving it to the more knowledgeable DBA types then the reverse. Most DBA's are happy not dealing with the OOP world and so you don’t really have to worry about them crossing over where they shouldn’t.
Reading SAMS “SQL in 24 Hours” no more makes a developer a good DBA then “.Net in 24 Hours or less” makes a DBA a good developer.
|
|
|
|
|
You make some good points, but you're replying to only half of a quote... He said:
Treat the DB as a data store only
*unless* the client has the infrastructure and the expertise to support using the DB for more.
In other words, don't mess with stored procedures unless you (or your client) has the skill-set available to support and maintain them.
So you guys seem to be pretty much in agreement
|
|
|
|
|
It's not the tool that's used, it's the tool that uses it!
====================================
Transvestites - Roberts in Disguise!
====================================
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
