|
|
|
I'm surprised that CP didn't give an "Out of memory exception" when the OP posted that code. Whew!
There are only 10 types of people in the world, those who understand binary and those who don't.
|
|
|
|
|
As I always say, it ain't the tool that is used that's the problem, but the tool that uses it.
=========================================================
I'm an optoholic - my glass is always half full of vodka.
=========================================================
|
|
|
|
|
What do you get when you cross a joke with a rhetorical question?
|
|
|
|
|
Not the sole domain, but a particularly frequent one due to some bad language design decisions.
JavaScript is similarly plagued, and of course one can always create bad code in any language, just some make it the default way of working for many.
"If you don't fail at least 90 percent of the time, you're not aiming high enough."
Alan Kay.
|
|
|
|
|
Holy crap.
Here's what you do.
Install Strawberry Perl on that machine, and have that function shell out to a perl one-liner. It'll still be more efficient and less dain bramaged.
|
|
|
|
|
mikepwilson wrote: Install Strawberry Perl
No, I don't think so...
mikepwilson wrote: less dain bramaged
you were saying? 
|
|
|
|
|
I dunno man, consider it.
Perl is the language for programmers who have actual work to get done.
|
|
|
|
|
Die! Die! Die!
I won't bother with the code, it's all the same. 
|
|
|
|
|
Sorry, I have to disagree; some code is much worse that others.
Just because the code works, it doesn't mean that it is good code.
|
|
|
|
|
NV: Die! Die! Why won't you die?... Why won't you die?
VB6: Beneath this mask there is more than flesh. Beneath this mask there is an idea, Mr. Nagy, and ideas are bulletproof.
I'm not questioning your powers of observation; I'm merely remarking upon the paradox of asking a masked man who he is. (V)
|
|
|
|
|
Wow, that was a bit strong. Nagy isn't alone in his opinion of VB6, luckily it won't be much longer before it gets to its final resting place.
"If you don't fail at least 90 percent of the time, you're not aiming high enough."
Alan Kay.
|
|
|
|
|
I've had very bad experience with VB6 and don't mind to dance on it's grave - sooner is better...
But I do not blame VB or VB6 or VB.NET per se - in my experience it always related to human error (bad choice in most case)...
I'm not questioning your powers of observation; I'm merely remarking upon the paradox of asking a masked man who he is. (V)
|
|
|
|
|
Re-using variables can be dangerous. The following code had me baffled for hours. This code queries a dozen different XML files on the server, builds a response, and serves it to different dashboards.
fileName = "FinSummaryByMonth";
xmlFile = Server.MapPath("Data/" + DistrictNumber + "/" + sYearFolder + "/" + fileName + ".xml");
srcDoc = XDocument.Load(xmlFile);
fileName = "MealSummaryByMonth";
srcDoc = XDocument.Load(xmlFile);
Being a newbie to linq, I had assumed the mistake was in the query. 2 hours later, looking at the output, I realize that the rows in the problem section were identical to the rows in the previous section nevermind that the results should have been ints. 
"Go forth into the source" - Neal Morse
|
|
|
|
|
"Omit needless local variables." -- Strunk... had he taught programming
Or, better, write a method and eliminate the repetitive code.
You'll never get very far if all you do is follow instructions.
|
|
|
|
|
PIEBALDconsult wrote: Or, better, write a method and eliminate the repetitive code.
This.
|
|
|
|
|
Good advice! I suppose I could stick the file names into a list with any parameters distinct to each query and return a loaded XDocument or Array. Maybe in the next version! Thanks! 
"Go forth into the source" - Neal Morse
|
|
|
|
|
Yes, I'm back with yet another gem from the the VB hell I'm porting:
Private Sub LoadGrid()
Dim SQL As String
Dim x As Long
Dim rst As New ADODB.Recordset
txtMode.Text = mode
txtPID.Text = PID
txtPolTypeID.Text = policytypeid
x = Val("" & txtPID.Text)
End Sub
That comment wasn't there, that was my contribution!
This is fairly typical of the code quality - note that..
1. The name is unrelated to the procedure.
2. There are two local variables that are dead.
3. It loads a text box from an integer field (PID is an Integer), but still feels in necessary to prepend "" in the last line, just in case!
They're wondering why it's taking me a long time to port. Can't imagine.
<Edit>And of course I forgot to mention that both txtPID and txtPolTypeID are hidden fields, with OnChange event handlers that carry out further processing - flow-of-control in this application is fractal-like.</Edit>
"If you don't fail at least 90 percent of the time, you're not aiming high enough."
Alan Kay.
|
|
|
|
|
|
Rob Grainger wrote: VB hell
Why VB. It's a hell of non-programming, but not because of VB but because of the men wrote it...
I'm not questioning your powers of observation; I'm merely remarking upon the paradox of asking a masked man who he is. (V)
|
|
|
|
|
Because this particular hell was constructed in VB. I've seen plenty of JavaScript hell too (and many others), but VB seems to particularly attract the infernal.
"If you don't fail at least 90 percent of the time, you're not aiming high enough."
Alan Kay.
|
|
|
|
|
I done VB development of very large scale application (Microsoft sold us that VB is the language of the future). We done it in VB6 using every dirty trick we found - still the code was well written and readable...The application went off at 1999 and still working...
I'm not questioning your powers of observation; I'm merely remarking upon the paradox of asking a masked man who he is. (V)
|
|
|
|
|
I feel your pain Rob. I've spent the last three weeks on a refactoring job that was supposed to last two days at most. The guy who wrote the original code was pretty sharp, with a deep background in embedded development in C. Unfortunately, the code in question is for a Windows service written in C++. Unsafe pointer casts everywhere, no attempt to follow the group naming convention, class member variables that were unused, lots of pointer arithmetic rather than straightforward array indexing, locals that were initialized and never referenced, the list goes on. The worst was the mix of MFC and STL collection classes. I spent four days alone getting the thing to shutdown without throwing exceptions or locking up due to threading issues.
Software Zen: delete this;
|
|
|
|
|
In many ways I suspect that's worse - at least VB doesn't tend to just bomb when an error occurs (at least while debugging) - in C/C++ unhandled exceptions tend to be, well, fatal.
I don't envy you.
"If you don't fail at least 90 percent of the time, you're not aiming high enough."
Alan Kay.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
