The Weird and The Wonderful

The Weird and The Wonderful forum is a place to post Coding Horrors, Worst Practices, and the occasional flash of brilliance.

We all come across code that simply boggles the mind. Lazy kludges, embarrassing mistakes, horrid workarounds and developers just not quite getting it. And then somedays we come across - or write - the truly sublime.

Post your Best, your worst, and your most interesting. But please - no programming questions . This forum is purely for amusement and discussions on code snippets. All actual programming questions will be removed.

Re: Profanity in code

Stefan_Lang3-Sep-12 4:21

Stefan_Lang

3-Sep-12 4:21

I wonder what downtimes refers to in this context ...

Re: Profanity in code

Sander Rossel18-Sep-12 9:30

Sander Rossel

18-Sep-12 9:30

I once made the misstake of spelling "Sauce" instead of "Source".
I did this in a company library and our entire software was littered with "Sauce", until a bright colleague finally pointed out the spelling mistake.
We had a good laugh about it Laugh | :laugh:

It's an OO world.

public class Naerling : Lazy<Person>{
    public void DoWork(){ throw new NotImplementedException(); }
}

Re: Profanity in code

Brisingr Aerowing18-Sep-12 9:46

Brisingr Aerowing

18-Sep-12 9:46

I see a lot of silly spelling mistakes in a number of libraries, including several DevExpress libraries (Most of those mistakes have been fixed, however).

I think computer viruses should count as life. I think it says something about human nature that the only form of life we have created so far is purely destructive. We've created life in our own image.
Stephen Hawking

Re: Profanity in code

ian dennis11-Oct-12 13:38

ian dennis

11-Oct-12 13:38

As recently as yesterday, a colleague sent me an email that was supposed to include the word "assign". However, she transposed the last two letters Smile | :)

A MySQL horror

Bernhard Hiller21-Aug-12 3:25

Bernhard Hiller

21-Aug-12 3:25

In a MySQL table, the start and en time of using a service are recorded. I tried to get the sum of usage per user and day:

SQL

SELECT OriginationName, Date(StartTime), count(*), sum(timediff(endtime,starttime)) as duration
FROM ippbxcdr
Group by OriginationName, Date(StartTime)
order by OriginationName, Date(StartTime)

With a start time of '2012-08-21 15:02:29' and an end time of '2012-08-21 15:03:59', that duration of 1 minute 30 seconds was shown as 130.0000.

No, no, no: thou shalt not use sum with timediff!
The Lord of MySQL giveth no error message, he punisheth with a wrong result.

Re: A MySQL horror

Brisingr Aerowing21-Aug-12 8:54

Brisingr Aerowing

21-Aug-12 8:54

Re: A MySQL horror

Brady Kelly23-Aug-12 21:21

Brady Kelly

23-Aug-12 21:21

Ooouch!!!

Re: A MySQL horror

hussainnagri24-Aug-12 0:55

hussainnagri

24-Aug-12 0:55

Horrifying

Re: A MySQL horror

Frans_5512924-Aug-12 1:49

Frans_55129

24-Aug-12 1:49

¿ Are you sure you haven't multiple records with the same values ?
When you have 100 records with these values......you'll have this result.

Re: A MySQL horror

RafagaX24-Aug-12 4:18

RafagaX

24-Aug-12 4:18

Your punishment is accord to your sins, long live to our migthy and fair MySQL Lord! Laugh | :laugh:

CEO at:
- Rafaga Systems
- Para Facturas
- Modern Components
for the moment...

MySQL: A Horror

Dan Sutton24-Aug-12 7:33

Dan Sutton

24-Aug-12 7:33

I have renamed your thread appropriately!

Re: A MySQL horror

Dan Metheus24-Aug-12 12:44

Dan Metheus

24-Aug-12 12:44

You figured out to use timestampdiff(SECOND, time1, time2)?

Re: A MySQL horror

Bernhard Hiller26-Aug-12 21:01

Bernhard Hiller

26-Aug-12 21:01

Yes, I found a solution:

SQL

SEC_TO_TIME( sum( time_to_sec(endtime)-time_to_sec(starttime))) as Duration

Looks complicated, but it works.

Re: A MySQL horror

englebart27-Aug-12 5:12

englebart

27-Aug-12 5:12

Maybe time diff is using some sort of fixed place BCD storage scheme.
If you span a year does it produce a value out in the thousands?

Something like:
yyyymmddhhmmss
or
dddddddhhmmss

I worked on a database once where dates were stored like:
yyyymmdd. Everything collated correctly and it was easy to extract the field you wanted.

Re: A MySQL horror

Michael Kingsford Gray24-Aug-12 22:47

Michael Kingsford Gray

24-Aug-12 22:47

Another good reason to buy SQL Server, or ORACLE, etc.
Anyone who relies on MySql to run their vital business infrastructure deserves no less than burning at the stake.

Re: A MySQL horror

Florin Jurcovici27-Aug-12 1:56

Florin Jurcovici

27-Aug-12 1:56

Michael K Gray wrote:
Another good reason to buy SQL Server, or ORACLE, etc.

That's plain wrong. It all depends on the business model and on the app using the database.

Besides, MySQL does have its strengths - it beats any commercial offering from MS or Oracle when 90% of the workload is reads performed by a server with limited hardware (depending on the table type being used).

Re: A MySQL horror

englebart27-Aug-12 5:17

englebart

27-Aug-12 5:17

We have (for many years now) a worse problem in Or-ache-le.
A query should return 3000 rows. It just returns 1200 and does not generate any error.

A corrupted value in a key terminated the retrieval, but it still returned success.

String.Format - I'm sure there must be a worse way to do this.

RCoate15-Aug-12 16:08

RCoate

15-Aug-12 16:08

I'm a bit surprised there isn't an embedded String.Concatenate call in there as well.

DateTime dt = DateTime.Now;

// Get year, month, and day
string year = dt.Year.ToString();
string month = dt.Month.ToString();
string day = dt.Day.ToString();

// Format month
if (month.Length == 1){ month = "0" + month; }

// Format day
if (day.Length == 1){ day = "0" + day; }

string DocumentName = string.Format("Application - [{0}] - " + year + month + day, this.Person.RegistrationNo.ToString());

I'm thinking that there is a ToString() call missing just before the final ; too.

Oh - and this one too.

TRIMSDK.Location trimLocation = trimLocation = trimManager.FindLocationFromNickname(string.Format("{0}", this.Person.RegistrationNo.GetValueOrDefault(0).ToString()));

I think I need a Rum! WTF | :WTF:

modified 15-Aug-12 23:47pm.

Re: String.Format - I'm sure there must be a worse way to do this.

egenis15-Aug-12 18:36

egenis

15-Aug-12 18:36

RCoate wrote:
// Format month
if (month.Length == 1){ month = "0" + month; }

// Format day
if (day.Length == 1){ day = "0" + day; }

Now if that had been done with a StringBuilder... I would have been impressed!
$Shucks | :-\$

Re: String.Format - I'm sure there must be a worse way to do this.

RCoate15-Aug-12 18:56

RCoate

15-Aug-12 18:56

// Format month
var sbMonth = new StringBuilder();
if (month.Length == 1)
{
    sbMonth.Append("0");
}
sbMonth.Append(month);

Awesome! I knew there was another method missing!
Smile | :)

Re: String.Format - I'm sure there must be a worse way to do this.

PIEBALDconsult16-Aug-12 3:43

PIEBALDconsult

16-Aug-12 3:43

Now try it with Insert.

Re: String.Format - I'm sure there must be a worse way to do this.

RCoate16-Aug-12 12:25

RCoate

16-Aug-12 12:25

Got your insert right here.

// Format month
var sbMonth = new StringBuilder();
sbMonth.Append(month);
if (month.Length == 1)
{
    sbMonth.Insert(0, "0");
}

I'm sure if the genius who wrote this was aware of Insert and string builders, it would have been used.

Can't complain too much. At least the code actually produces the required outcome. I can't always claim that. Smile | :)

Re: String.Format - I'm sure there must be a worse way to do this.

Slacker00716-Aug-12 22:53

Slacker007

16-Aug-12 22:53

String.Remove() and String.Insert() - I use these a lot. BTW, I hardly use StringBuilder(), but that's just my style.

Wink | ;)

Re: String.Format - I'm sure there must be a worse way to do this.

0bx19-Aug-12 8:50

0bx

19-Aug-12 8:50

var sbMonth = new StringBuilder();
try
{
  int x = 1 / month.Length -1;
  sbMonth = AppendMonth(sbMonth);
}
catch
{
  sbMonth = AppendMonth(sbMonth, "0" + month);
}

private StringBuilder AppendMonth(StringBuilder sb, string s)
{
    string x = sb.Append(s).ToString();
    StringBuilder y = new StringBuilder();
    return y.Append(x);
}

Giraffes are not real.

Re: String.Format - I'm sure there must be a worse way to do this.

RCoate19-Aug-12 13:06

RCoate

19-Aug-12 13:06

Yep. That's worse.

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.