|
Clearly your predecessor did not understand either the type system nor TimeSpans. 
Just because the code works, it doesn't mean that it is good code.
modified 20-Sep-12 13:11pm.
|
|
|
|
|
Likely both.
I think computer viruses should count as life. I think it says something about human nature that the only form of life we have created so far is purely destructive. We've created life in our own image.
Stephen Hawking
|
|
|
|
|
I've seen stranger DateTime usage in the Web Service I'm working on. We use a nullable type too, but in this case it was a WTF because Microsoft handed us a WTF with WCF. Stranger is our code that handles a DataSet which has a DateTime column as part of an incoming web request. Whenever we get new developers on board, we watch them when they come across this piece of code. Some of them slump down in their desks and go into a trance, while some quickly walk away and wash their hands with plenty of SOAP. 
SG
Aham Brahmasmi!
|
|
|
|
|
Here's a 'nice' pattern I saw in some code I've inherited...
catch (Exception ex)
{
if (ex is ExceptionSpecialType)
throw new SomeException()
{
CustomData = (ex as ExceptionSpecialType).SomeThing.ToXmlString()
};
else
{
throw new SomeException()
{
CustomData = new CustomError(ex).ToXmlString()
};
}
}
Oh, and yes, my predecessor loved using 'if (X is T) (X as T).M();'.
'I'm French! Why do you think I've got this outrrrrageous accent?' Monty Python and the Holy Grail
|
|
|
|
|
And I thought my custom unrecoverable Exception handling wrapper sucked:
Helper.logUnrecoverable(this.GetType().ToString(), "doSync - createHeader or createLine fail. Action rollbacked", e.Message, true);
Where true is whether it should log the StackTrace or not. But this is a whole different -ness level
Full-fledged Java/.NET lover, full-fledged PHP hater.
Full-fledged Google/Microsoft lover, full-fledged Apple hater.
Full-fledged Skype lover, full-fledged YM hater.
|
|
|
|
|
Obviously, your predecessor did not have the slightest understanding of proper exception handling. Even reading one article on Code Project about exception would have helped him greatly 
Just because the code works, it doesn't mean that it is good code.
|
|
|
|
|
I've worked with a codebase where each and every method has a try catch block.
The catch logged the error and that's that. As a result, every method you called would return normally like everything went fine.
Something like an Exception or unexpected results when updating a database record could very well be the result of a ReferenceNull- or InvalidCastException somewhere in some method.
Good luck trying to find it
It's an OO world.
public class Naerling : Lazy<Person>{
public void DoWork(){ throw new NotImplementedException(); }
}
|
|
|
|
|
"Look boss, never any error!"
In Visual Studio, you can set a kind of breakpoints on exceptions just when they're thrown, I guess it could help with that kind of monstrous codebase.
'I'm French! Why do you think I've got this outrrrrageous accent?' Monty Python and the Holy Grail
|
|
|
|
|
Julien Villers wrote: it could help with that kind of monstrous codebase
We would sit and cry in the corner waiting for help... Help never came 
It's an OO world.
public class Naerling : Lazy<Person>{
public void DoWork(){ throw new NotImplementedException(); }
}
|
|
|
|
|
WPF by any chance? I was forced to write code like that for it.
He who asks a question is a fool for five minutes. He who does not ask a question remains a fool forever. [Chineese Proverb]
Jonathan C Dickinson (C# Software Engineer)
|
|
|
|
|
Nope. I'm mostly working in Silverlight, but this is backend code for a webservice, so ASP.NET.
I don't see any reason to 'force' you to write bad exception handling code, ie catching Exception, then testing type.
'I'm French! Why do you think I've got this outrrrrageous accent?' Monty Python and the Holy Grail
|
|
|
|
|
I made the following code, and I stand by it (kind of):
var numTweets = parseInt("<%= NumTweets.ToString() %>", 10);
Can you figure out why I would do such a thing?
|
|
|
|
|
Because your tweets were numb? 
|
|
|
|
|
While most tweeters are numskulls, that is not the reason.
|
|
|
|
|
Because you really don't wanna know and don't care about the number of twits?
Full-fledged Java/.NET lover, full-fledged PHP hater.
Full-fledged Google/Microsoft lover, full-fledged Apple hater.
Full-fledged Skype lover, full-fledged YM hater.
|
|
|
|
|
While true, it's not the reason.
|
|
|
|
|
What's the type of NumTweets? Perhaps it is not an int type and the conversion of it's type to var is different from the conversion of int to var.
Chris Meech
I am Canadian. [heard in a local bar]
In theory there is no difference between theory and practice. In practice there is. [Yogi Berra]
posting about Crystal Reports here is like discussing gay marriage on a catholic church’s website.[Nishant Sivakumar]
|
|
|
|
|
It's an int. This is an ASP.Net page, so the code inside the string is VB.Net and the outside code is JavaScript.
|
|
|
|
|
Because you have written this in a JavaScript function in ASP.NET, and NumTweets could be any base number, but you want it translating back to base 10. Or, you're a masochist.
|
|
|
|
|
All true (and that's sado-masochist to you!), but not the reason.
|
|
|
|
|
I've made worse... in cases i were asleep:
@{
var style = "style=\"color=@color;\"";
}
I'm brazilian and english (well, human languages in general) aren't my best skill, so, sorry by my english. (if you want we can speak in C# or VB.Net =p)
|
|
|
|
|
just realized that this way you still get code formatting to your javascript, while if you'd used:
var numTweets = <%= NumTweets.ToString() %>;
the formatting from visual studio and the intellisense would've blown up
I'm brazilian and english (well, human languages in general) aren't my best skill, so, sorry by my english. (if you want we can speak in C# or VB.Net =p)
|
|
|
|
|
That is exactly correct! 
|
|
|
|
|
Fortunately there were three cases alone, other wise he would have ended up parsing the same enum multiple times! Comments are mine, rest remains the same!
foreach (string name in names)
{
if (StringValueOf((Enum)Enum.Parse(enumType, name)).Equals(value))
{
return Enum.Parse(enumType, name);
}
else if (AlternateStringValueOf((Enum)Enum.Parse(enumType, name)).Equals(value))
{
return Enum.Parse(enumType, name);
}
else if (name.Equals(value))
{
return Enum.Parse(enumType, name);
}
}
modified 14-Sep-12 2:06am.
|
|
|
|
|
I think computer viruses should count as life. I think it says something about human nature that the only form of life we have created so far is purely destructive. We've created life in our own image.
Stephen Hawking
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
