|
An example of how the World SHOULD work...
|
|
|
|
|
At first glance I thought it was just an awkward way to do it, as in why not just create a date from the MDY, then compare. Then I saw the real problem...
|
|
|
|
|
same happened to me, I just couldn't see what was wrong
|
|
|
|
|
in order to fix the bugs, you could write:
ok=!(year<dtStart.Year||(year==dtStart.Year&&(month<dtStart.Month||(month==dtStart.Month&&day<dtStart.Day)))||
year>dtEnd.Year||(year==dtEnd.Year&&(month>dtEnd.Month||(month==dtEnd.Month&&day>dtEnd.Day))))
which still sits in the right forum.
|
|
|
|
|
Minor correction. Try:
ok=!(year<dtStart.Year||(year==dtStart.Year&&(month<dtStart.Month||(year==dtStart.Year&&month==dtStart.Month&&day<dtStart.Day)))||
year>dtEnd.Year||(year==dtEnd.Year&&(month>dtEnd.Month||(year==dtStart.Year&&month==dtEnd.Month&&day>dtEnd.Day))))
Else you'll end up with 'valid' dates that are well within the month/date bracket, but in the wrong year(s)!
hth 
|
|
|
|
|
I disagree.
|
|
|
|
|
Or (in no particular language):
long ymd = (year * 12 + month) * 31 + day
bool ok = ymd >= (dtStart.Year * 12 + dtStart.Month) * 31 + dtStart.Day
&& ymd <= (dtEnd.Year * 12 + dtEnd.Month) * 31 + dtEnd.Day
This is still in the right forum as it permits 31st Nov and 33rd Feb and 0th May, -9th day of the 17th month etc. without fixing them properly; but valid dates work.
An even more horrible way with similar failings, but much faster would be (using << as a shift left logical operator and | as a bitwise OR):
long ymd = year << 9 | month << 5 | day
bool ok = ymd >= (dtStart.Year << 9 | dtStart.Month << 5 | dtStart.Day)
&& ymd <= (dtEnd.Year << 9 | dtEnd.Month << 5 | dtEnd.Day)This assumes less than 32 days per month (2^5) and less than 16 months per year (2^4). The year << 9 bits are year * 32 * 16. So 33rd Feb and -9th day of the 17th month would be somewhat disasterous.
|
|
|
|
|
the shifting way is what I would actually do when DateTime were not available; with a little optimization:
int ymd = (((year<<4)+month)<<5)+day;
eyc.
IMO it is the cheapest mapping from dates to integers that supports chronological ordering. I do add parentheses, for readability if nothing else.
|
|
|
|
|
DateTime dt = new DateTime(year, month, day);
return (dt <= dtEnd & dt >= dtStart);
How about this one?
Enclosing it in try catch will cop with invalid dates too.
|
|
|
|
|
Sadly, I've written code like that. 
Marc
|
|
|
|
|
Yes, but you only do it once, and then when you realize your blunder, you promise yourself to never go there again. Right? 
--
Kein Mitleid Für Die Mehrheit
|
|
|
|
|
Jörgen Sigvardsson wrote: , you promise yourself to never go there again. Right?
Exactly. And generalizing the blunder, you realize how evil "if" statements actually are and carefully consider the use of them!
Marc
|
|
|
|
|
I stopped using branches years ago. It's my way or the highway!
--
Kein Mitleid Für Die Mehrheit
|
|
|
|
|
Remembers me to some date comparisons I have done with plain C - long ago 
(but mine were at least correct )
I was very happy when I had to do it the first time with C# and found out I can do it like this:
DateTime dtPast = new DateTime(2009, 9, 9);
DateTime dtNow = new DateTime(2010, 10, 10);
DateTime dtFuture = new DateTime(2011, 11, 11);
bool bIsBetween = dtNow > dtPast && dtNow < dtFuture;
|
|
|
|
|
So I was looking at some code I wrote a few years back, when I was first learning objective-C. I found many places where I did something like this:
char buffer[100];
sprintf(buffer, "the value: %d", someValue);
NSString* string = [NSString stringWithCString:buffer];
of course, with more useful text and values. I think there may have even been some times when I malloc'd buffer rather than having it on the stack... for those who aren't familiar with obj-C, this could be more sanely/appropriately written as:
NSString* string = [NSString stringWithFormat:"the value: %d", someValue"];
|
|
|
|
|
I constantly observe the same type of constructions with the MFC CString, when the programer does not realize there is a .Format() function to do the same thing.
I also crack up at the use of strlen and its variants to detect if the string is empty. How about just chekcing the first array slot for a zero! Or maybe they weren't after any kind of performance after all...
|
|
|
|
|
I have known programmers who say that readability is more important than small performance gains. This doesn’t sound too bad until you realize that by “readable” they mean “using what they are familiar with” and not learning new, faster and better ways of doing things. Also the performance of their code is abysmal.
Just because the code works, it doesn't mean that it is good code.
|
|
|
|
|
The real horror here is that you don't check for the possibility of buffer overrun.
|
|
|
|
|
I found this jewel in my company's codebase
check the name of the Enum on the second line
szError = PrnError.GetLoadImgError(iflRet);
Done(szError, ModusOperandi.ImageErrorMgr);
|
|
|
|
|
This is what happens when lawyers become programmers )
P.S. Once a musician saw my C# book and asked me "Why is this thick book called Do-Diese?"
|
|
|
|
|
|
As Modus Operandi means, literally, "Method of Operating", I can see that applying as a valid (if unusual) name in many situations.
Unfortunately not this one, I guess that should be Modus Non Operandi.
So I guess that remains a horror.
|
|
|
|
|
Rob Grainger wrote: Unfortunately not this one, I guess that should be Modus Non Operandi.
So I guess that remains a horror.
So, in an interview for a programming job when asked what languages he knows, the correct answer would be..."I've used Latin, but I'm no expert".
-Rd
|
|
|
|
|
Richard A. Dalton wrote: So, in an interview for a programming job when asked what languages he knows, the correct answer would be..."I've used Latin, but I'm no expert".
And if I were the interviewer, I would extend my hand to the prospect and say with a smile: Noli me vocare. Ego te vocabo.
|
|
|
|
|
if (lang == "Japanese")
{
msg.BodyEncoding = System.Text.Encoding.UTF8;
msg.SubjectEncoding = System.Text.Encoding.UTF8;
}
else
{
msg.BodyEncoding = System.Text.Encoding.UTF8;
msg.SubjectEncoding = System.Text.Encoding.UTF8;
}
R A M
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
