|
// Try this:
DateTime now = DateTime.Now;
DateTime date = new DateTime(now.Year, now.Month, now.Day);
|
|
|
|
|
One thing it will do is break if you run it in America.
If the date is 5th March 2009, the ToString conversion will give you 05/03/2009. But because no format is specified on the Parse method, it will assume the default date format, which in America is MM/dd/yyyy. So 05/03/2009 will get converted to 3rd May 2009.
My guess would be this is someone from a Java background because java.util.Date doesn't have an equivalent to .NET's DateTime.Date property, and it's not so easy to strip off the time part. The correct way to do it in Java is with java.util.Calendar, but lots of people use this sort of clumsy format/parse approach.
|
|
|
|
|
Yup, a java-based programmer was involved, I did suspect something like that (there is lots of other Java-inspired "Goodness" in the code). I would have excused him, but he did manage to use DateTime.Now.Date as part of this coding beauty. Ho hum.
|
|
|
|
|
Tell him about properties; people unfamiliar with Windows are propably not familiar with properties either. Java didn't have them when I used it.
Luc Pattyn [Forum Guidelines] [My Articles]
The quality and detail of your question reflects on the effectiveness of the help you are likely to get.
Show formatted code inside PRE tags, and give clear symptoms when describing a problem.
|
|
|
|
|
Java still does not have properties. There was a big argument about whether they should be added to Java 7 or not (the next version due next year) and in the end they were not included.
Personally, I don't miss properties in Java, possibly because I write mostly server-side Java apps, and properties are more useful for simple binding to UI controls. You can do that with Java beans and Swing but it's a bit messy.
|
|
|
|
|
It happens both ways round. Because the syntax for Java and C# is very similar, it's easy to switch between the two languages and end up coding things inappropriately.
|
|
|
|
|
Actually you're dead wrong in so many ways. 
1) Since ToString() and Parse() both use the *same* culture, it doesn't matter what that culture is.
2) The culture used is not necessarily the system default. It is the current culture, which can be set programmatically to whatever we'd like it to be.
3) The default culture doesn't actually depend on where the machine is located.
I once wrote a disposable class called CultureBubble in order to easily run portions of code with a specific culture, like this:
using (new CultureBubble("FR"))
{
foo();
bar();
}
This technique is quite useful, as it requires minimal coding compared to writing logic for dealing with different cultures everywhere data is parsed or presented in culture-dependent ways.
|
|
|
|
|
Ha,
I come from a Java background so my first thought was "What's wrong with it"
I switched over to .NET about 7 years ago. so now I would write it like this:
DateTime.Now.Date.ToShortDateString()
|
|
|
|
|
7 years of .NET experience and you don't see what's wrong with it? Or is there a joke in there that I'm missing? (Monday morning, brain not fully engaged yet)
|
|
|
|
|
Drink some coffee, it was a joke 
|
|
|
|
|
Actually
DateTime date = DateTime.Parse(DateTime.Now.Date.ToString("dd/MM/yyyy"));
can be written as
DateTime date = DateTime.Now.Date;
No strings involved! You'll also notice that the original coder acutally had the "DateTime.Now.Date" bit, which they then cast to a string (in UK date format) that is subsequently parsed back to a DateTime.
|
|
|
|
|
In some parts of the world the original statement and yours will not yield the same result.
And the original may throw an exception, yours wouldn't. So we need to see the specs first.
Luc Pattyn [Forum Guidelines] [My Articles]
The quality and detail of your question reflects on the effectiveness of the help you are likely to get.
Show formatted code inside PRE tags, and give clear symptoms when describing a problem.
|
|
|
|
|
Well spotted. Have some brick points.
|
|
|
|
|
TimeSpan keyDays = new TimeSpan(this.FooLicenceKeyHolder.FooLicence.Licence.LicenceExpiryDate.Ticks);
TimeSpan nowDays = new TimeSpan(System.DateTime.Now.Ticks);
int daysLeft = keyDays.Days - nowDays.Days;
|
|
|
|
|
LOL. That example makes me want to fold. 
Chris Meech
I am Canadian. [heard in a local bar]
In theory there is no difference between theory and practice. In practice there is. [Yogi Berra]
|
|
|
|
|
Chris Meech wrote: makes me want to fold.
Head-slamming the desk is a form of folding, not?
(but seriously, that code still exists in our code base, not wrong, but funny  )
|
|
|
|
|
For a moment there I thought you were measuring your licence expiry in ticks.
"This evaluation licence will expire in 342,827,400 nanoseconds."
|
|
|
|
|
  
Yep, that takes the biscuit. What's the conversion rate of Idiotions into Imbiciles (our local dim-wit currency)?
|
|
|
|
|
Simply amazing! Thanks for sharing, I had a good laugh.
|
|
|
|
|
My jaw hurts from having it smack the desktop.
|
|
|
|
|
keefb wrote: I still can't work out why
As to why, he only wants the date, with the time portion set to 0. 
Marc
Will work for food.
Interacx
I'm not overthinking the problem, I just felt like I needed a small, unimportant, uninteresting rant! - Martin Hart Turner
|
|
|
|
|
And I should add the simplest version is:
DateTime.Today
Regards,
Mark Hurd, B.Sc.(Ma.) (Hons.)
|
|
|
|
|
Not good but I've seen worse.
I'm sitting in front of code that's full of...
try
{
// various code here
}
catch
{
}
finally
{
}
Empty catch and finally blocks everywhere.
In your case though I think that will break if regional language settings define the date format as anything other than date/month/year as it'll format it with the date first and then reparse it as say mm/dd/yyyy in the US causing the date and month to be swapped.
|
|
|
|
|
I just ran across this line of condition in a KeyUp handler.
if ((e.Modifiers.GetHashCode().ToString() + "+" + e.KeyCode.GetHashCode().ToString()) == "131072+39")
|
|
|
|
|
It could be worse. They could then split the generated string by the "+", convert each element to a float, and ask if the value is 131072. Then if it is, repeat the process with the second element using a nested if-statement.
Between the idea
And the reality
Between the motion
And the act
Falls the Shadow
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
