The Weird and The Wonderful

The Weird and The Wonderful forum is a place to post Coding Horrors, Worst Practices, and the occasional flash of brilliance.

We all come across code that simply boggles the mind. Lazy kludges, embarrassing mistakes, horrid workarounds and developers just not quite getting it. And then somedays we come across - or write - the truly sublime.

Post your Best, your worst, and your most interesting. But please - no programming questions . This forum is purely for amusement and discussions on code snippets. All actual programming questions will be removed.

First Prev Next

Re: Horror from an article in CP

Pete O'Hanlon6-Sep-07 23:47

Pete O'Hanlon

6-Sep-07 23:47

There's the difference between you and me. You would run screaming. I would hunt them down and burn them. Burn the witch. Burn the witch.

Deja View - the feeling that you've seen this post before.

OOP 101

Leisuresuit Larry31-Aug-07 10:58

Leisuresuit Larry

31-Aug-07 10:58

Java code:

public class Account
{
...
public String type;
public String acctNumber;
public String balance;
...
}

public class CreditCardAccount extends Account
{
...
}

public Account getAccount(String id)
{
...
}

public void transferMoney(Account account, double amount)
{
...
if (<credit card transfer>)
{
CreditCardAccount cca = (CreditCardAccount)account;
...
}
...
}

Looks okay so far, but I got a ClassCastException when I did:

Account account = getAccount("12345");
...
transferMoney(account, amount);

It turns out, transferMoney *never* returns a CreditCardAccount object, but instead returns an Account object, with the type member set to "CreditCardAccount". The engineer who wrote this told me that I should change my code to:

Account account = getAccount("12345");
if (account.type.equals("CreditCardAccount"))
{
CreditCardAccount cca = new CreditCardAccount();
cca.type = account.type;
cca.acctNumber = account.acctNumber;
cca.balance = account.balance;
...
transferMoney(cca, amount);
}

Re: OOP 101

PIEBALDconsult31-Aug-07 14:17

PIEBALDconsult

31-Aug-07 14:17

I hope you told him to change his.

Re: OOP 101

Andy Brummer31-Aug-07 20:03

Andy Brummer

31-Aug-07 20:03

Leisuresuit Larry wrote:
The engineer who wrote this told me that I should change my code to

I think you meant:

The "engineer" who wrote this told me that I should change my code to

That's wrong on so many different levels. I hope you aren't dealing with a system where this kind of thing is rampant. If so, run, run far away.

This blanket smells like ham

Re: OOP 101

Nickolay Karnaukhov4-Sep-07 0:21

Nickolay Karnaukhov

4-Sep-07 0:21

He don't deserve the "engineer"... He can be named "mess-professional"...

But honestly - it's really really bad to work with such people who create mess themself and then argue when someone telling them that they're wrong...

------------------------------------------------------------
Want to be happy - do what you like!

Re: OOP 101

Le centriste4-Sep-07 3:19

Le centriste

4-Sep-07 3:19

He's obviously object-disoriented.

-----

If atheism is a religion, then not collecting stamps is a hobby. -- Unknown

God is the only being who, to rule, does not need to exist. -- Charles Baudelaire

Get me a count....

Vikas Salvi30-Aug-07 4:35

Vikas Salvi

30-Aug-07 4:35

I m really speechless on this..

<br />
string strQuery = "Select * from tblExtension where UserType = " + _UserType;<br />
			int _Count = 0;<br />
			OleDbDataReader drExtension = OleDbHelper.ExecuteReader(Utility.ConnectionString, CommandType.Text, strQuery);<br />
			using(drExtension)<br />
			{<br />
				while(drExtension.Read())<br />
				{<br />
					++_Count;<br />
				}<br />
			}<br />
			return _Count;<br />

ny comment??

Vikas Salvi

Programmer Analyst