The Weird and The Wonderful

Brisingr Aerowing wrote:

Visual Studio 2013 Premium.

if (GetLimitMessage(a, b).Length > 0)
    MessageBox.Show(GetLimitMessaage(a, b));

if (!GetLimitMessage(a, b).equals(GetLimitMessage(1, -1)) {
    if (!String.IsNullOrEmpty(GetLimitMessage(a, b)) {
        MessageBox.Show(GetLimitMessaage(a, b));
    }
    else
    {
        MessageBox.Show("The monkey's dead!");
    } 
}

try {
    if (GetLimitMessage(a,b) != null && GetLimitMessage(a,b).Equals(GetLimitMessage(1, -1))) {
        if (!string.IsNullOrEmpty(GetLimitMessage(a,b)) {
            try {
                MessageBox.Show(GetLimitMessage(a,b));
            }
            catch (Exception ex) {
                throw;
            }
        }
    }
}
catch (Exception ex) {
    MessageBox.Show("The monkey's dead!");
}

if(Helper.GetLimitMessage(total, 100)) //Yep, 100 is harcoded on every line it's used...
{
    ViewBag.LimitMessage = Helper.GetLimitMessage(total, 100);
    ViewData["LimitMessage"] = Helper.GetLimitMessage(total, 100);
}

@if(ViewBag.LimitMessage != "")
{
     @Helper.GetLimitMessage(total, 100)
}
else if (ViewData["LimitMessage"] != null)
{
     @ViewData["LimitMessage"]
}

Manfred R. Bihy wrote:

And what with the uninitialised statusMutex thingy?

Marco Bertschi wrote:

It is Qt code, where objects can be initialized by just writing "ObjectType variablename;".

Marco Bertschi wrote:

Not initialized variables are bad!

class  MutexLocker {
    QMutex &m;
public:
    MutexLocker(QMutex &qm) : m(qm) { m.lock(); }
    ~MutexLocker() { m.unlock(); }
}; // class

int GetStatus(){
   MutexLocker tmp(statusMutex);
   return status;
   // destructor unlocks 
}