|
when I get really plastered I let Spuds MacKenzie do the coding.
|
|
|
|
|
Never ever try Haskell then, you may get a habit.
|
|
|
|
|
Haskell and Hennessey, it may just work.
Panic, Chaos, Destruction. My work here is done.
Drink. Get drunk. Fall over - P O'H
OK, I will win to day or my name isn't Ethel Crudacre! - DD Ethel Crudacre
I cannot live by bread alone. Bacon and ketchup are needed as well. - Trollslayer
Have a bit more patience with newbies. Of course some of them act dumb - they're often *students*, for heaven's sake - Terry Pratchett
|
|
|
|
|
My coding gets 'creative' in two circumstances: my manic phase prior to a migraine starting, and the stoned phase when I've taken my drugs to deal with the migraine. Manic code is usually amazing for its quantity (quality is merely average). Stoned code is low in quantity, but the quality is fairly high, since I recognize I'm buzzed and I don't work on difficult stuff.
Software Zen: delete this;
|
|
|
|
|
i have to get drunk to understand that ha
|
|
|
|
|
I tried that once, then there was a person who commented that the code appeared to be written by someone who was drunk.
That person was me. Thankfully is wasn't at work, just some stuff I wrote for coursework that did not get turned in. I had to rewrite it.
It was broke, so I fixed it.
|
|
|
|
|
Came across this "class" during a code review. My reaction is pretty much "the f*** is this". Do you think this is good code or not?
class Listalizer {
public static function listalize( $convert, &$data ) {
if ( is_object( $data ) ) {
try {
$data = call_user_func( $convert, $data );
} catch ( \Exception $ex ) {
try {
trigger_error( "listalize: Callable " . self::callable2String( $convert )
. " caused an exception: " . $ex->getMessage(), E_USER_WARNING );
} catch ( \Exception $exx ) {
$exx = (object)$exx;
}
$data = false;
}
}
if ( is_array( $data ) || $data instanceof \ArrayObject ) {
foreach ( $data as $key => &$value ) {
self::listalize( $convert, $value );
}
}
}
public static function objectify( $convert, &$data, $role = null ) {
if ( is_array( $data ) ) {
try {
$data = call_user_func( $convert, $data, $role );
} catch ( \Exception $ex ) {
try {
trigger_error( "objectify: Callable " . self::callable2String( $convert )
. " caused an exception: " . $ex->getMessage(), E_USER_WARNING );
} catch ( \Exception $exx ) {
$exx = (object)$exx;
}
$data = false;
}
}
if ( is_array( $data ) || $data instanceof \ArrayObject ) {
foreach ( $data as $key => &$value ) {
self::objectify( $convert, $value, $key );
}
}
}
public static function callable2String( $callable ) {
if ( is_array( $callable ) && count( $callable ) === 1 ) {
$callable = array_pop( $callable );
}
if ( is_string( $callable ) ) {
return $callable;
} elseif ( is_object( $callable ) ) {
return get_class( $callable ) . '->__invoke';
} elseif ( is_array( $callable ) ) {
$target = $callable[0];
$method = $callable[1];
if ( is_string( $target ) ) {
return "$target::$method";
} elseif ( is_object( $target ) ) {
$class = get_class( $target );
return "$class->$method";
} else {
return '(array)';
}
}
return '(' . var_export( $callable, true ) . ')';
}
}
|
|
|
|
|
Ick. That's PHP, right?
Bob Dole The internet is a great way to get on the net.
2.0.82.7292 SP6a
|
|
|
|
|
Yep, PHP. Though some people consider this to be a horror on itself, that's not what I am getting at here
|
|
|
|
|
Could be worse. It could have been vb...
I wasn't, now I am, then I won't be anymore.
|
|
|
|
|
I am getting tired of silly comments about vb. Presumably by someone who has not checked out vb since vb6.
|
|
|
|
|
Apparently you missed the Joke icon. I've had to do plenty of vb and vb.net work over the years so I do not speak ignorantly on the matter.
I wasn't, now I am, then I won't be anymore.
|
|
|
|
|
Damn. I knew I had to get my eyes tested.
|
|
|
|
|
Last year I translated a whole lot of VB6 code into VB.NET 10. After the project was over he complained that most of my code was unintelligible and "I had used LINQ!"
|
|
|
|
|
Bob G Beechey wrote: I am getting tired of silly comments about vb. Presumably by someone who has not checked out vb since vb6.
I've used VB2 through VB6 and VB.Net (2002) through VB.Net 2005.
VB's mother wears army boots!
--
Harvey
|
|
|
|
|
Okay ... what are you getting at?
|
|
|
|
|
Jeroen De Dauw wrote: My reaction is pretty much "the f*** is this". Do you think this is good code or not?
Well the try-blocks in the catch-statements are... Well, I don't know.
It's not the best code, but I've seen much worse. I think with some arguments this programmer would be able to code readable, efficient code. So there is more than a shimmer of hope.
------------------------------
Author of Primary ROleplaying SysTem
How do I take my coffee? Black as midnight on a moonless night.
War doesn't determine who's right. War determines who's left.
|
|
|
|
|
Mhm... lot of if s and elseif s... and try-catch es.
Could be more compact...
(yes|no|maybe)*
modified 30-Jan-13 16:11pm.
|
|
|
|
|
Ok, I found a spelling mistake in the code (an extra 'x')
Jeroen De Dauw wrote: $exx
|
|
|
|
|
Your reaction is the same as mine. Obvious digs at PHP aside, what does this class even do?
|
|
|
|
|
Too much
$exx Or not enough...
It was broke, so I fixed it.
|
|
|
|
|
I think this just converts an array to a string. Can be used in those beginner/advanced/pro/guru code examples
modified 20-Oct-19 21:02pm.
|
|
|
|
|
the f***. developer needs more Argh comments. (am I supposed to include an emoticon?)
|
|
|
|
|
After taking a good look see, this class
takes an array, converts it to strings and
tests to see if the string is a callable
object with a method inside.
In PHP, you can assign a function or object
name to a string and call it as though you
you had hard coded the name in the code.
This code, despite all the complaints is
actually what you would have to do in order
to avoid the exceptions that occur when
you call a function or object that does
not exist.
The author is utilizing a class perhaps to
keep all the related code in one place, but
a simple function would have sufficed.
|
|
|
|
|
I just noticed a variable I had created at some point was later refactored by somebody else from "entity" to "entty". When spoken, they both sound about the same... perhaps somebody was trying to shorten variable names?
|
|
|
|