I have a program that fails to work

Question

0.00/5 (No votes)

See more:

This program developed under Borland C++ (V4) running on Win XP. The program was developed to work on Win XP, Vista, 7 & 10. It runs with full 'privaleges' enabled and has been working fine for years. I sometimes add enhancements.

The latest is to display the name of the default system printer. It works fine on XP (not tried Vista) but crashes on Win 7 & 10. Illegal access to memory 0000 004C.

Here is the offending code:

AnsiString s_Bfr

  s_Bfr = Printer()->Printers[Printer()->PrinterIndex ].GetText();

Any thoughts as to why?

The program does print reports, I wanted let the user know what printer is being used.

What I have tried:

The single instruction is the cause. If I comment it out, no crash.

Posted 31-May-20 23:35pm

Andy Belton

Updated 1-Jun-20 0:04am

v2

Add a Solution

Comments

KarstenK 1-Jun-20 13:12pm

separate this statement in 5 (fixe) statements with zero check, to ensure that it doesnt crash. This also helps to debug it.

2 solutions

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2020-05-31T23:46:00

At a guess, Win7 and 10 return different values to XP, and either Printer() or Printers[Printer()->PrinterIndex ]is returning null.

Break the line up into individual parts as separate lines, and use the debugger to isolate exactly what is being returned: Try it on XP and Win 7 / 10 and you should see differences.
I can't check it at all - I don't have XP any more and Borland 4 is ... um ... rather out of date. Like it's older than about 50% of our members here! :laugh:

Andy Belton · Answer 2 · 2020-06-01T00:06:00

Solution 2

I will try what you have suggested. It may take some time as I'm older the Borland. I will be 70 next year.

Thanks for your input
AGB

Posted 1-Jun-20 0:06am

Andy Belton

Comments

OriginalGriff 1-Jun-20 6:50am

That's OK - I'm 61!

Don't post comments as solutions: only the OP - you - get notified that you did, which means the answerer doesn't know you wanted to talk further. Instead, use the "Have a question of comment?" button below each solution (the Reply widget for comments) and the poster gets an email.

I can strongly suggest moving from Borland to Visual Studio - it's a lot better once you get used to the modern frameworks, and the Community Edition is free direct from Microsoft. 27 year old software does tend to have ... problems ... interfacing with modern OSes.

Richard MacCutchan 1-Jun-20 7:41am

You young people ... :)

I have a program that fails to work

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

I have a program that fails to work

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us