cant get 2 on click listeners toghether

Question

3.00/5 (2 votes)

See more:

Hi there!
Im net to android programming so sorry if this is noobish, but cant find a good example anywhere. I have 2 image button on the same screen using a on click listener. I keep getting bracket errors and Syntax error on tokens, AnnotationName expected instead errors.

Java

    startButton1.setOnClickListener(new OnClickListener() {
        startButton2.setOnClickListener(new OnClickListener() {

        @Override
        public void onClick(View v) {



            if(currentRun == 0){

                startButton1.setText(hitButtonText);
                startButton1Parent.setBackgroundResource(R.drawable.pump_red);
                startButton2.setText(hitButtonText);
                startButton2Parent.setBackgroundResource(R.drawable.pump_red);
                new TimerClass().execute();
            }else{
                if(allowHit){
                    isHit = true;
                }
            }
        }
    });
}

any ideas?

thank you

Posted 7-Jan-13 16:18pm

Justin Jones

Add a Solution

Comments

[no name] 7-Jan-13 23:30pm

Hi Justin Jones,
Why dont you seperate event for each button ?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

WebMaster · Accepted Answer · 2013-01-07T19:35:00

You can define event for each button.

Another way, you can do like this:

Java

private OnClickListener mListener = new OnClickListener() {
	@Override
	public void onClick(View v) {
		Button btn = (Button)v;
                // if btn is startButton1
		if (btn.getId() == R.id.startButton1) {
                // do something
                } else (btn.getId() == R.id.startButton2) {
                // do something
                }
	}
};

startButton1.setOnClickListener(mListener);
startButton2.setOnClickListener(mListener);

TorstenH. · Accepted Answer · 2013-01-07T19:45:00

Solution 2

Java

new OnClickListener() {
  startButton2.setOnClickListener(new OnClickListener() {
    // some code
 }
}

THAT will never work.

When you declare such a OnClickListener, you declare an anonymous class. That one is defined. If there is no directly accessable method onClick(View v), the action will not happen.

Try this:

Java

startButton1.setOnClickListener(new OnClickListener() {
  @Override
  public void onClick(View v) {
    // fancy code for button1
  }
});
startButton2.setOnClickListener(new OnClickListener() {
  @Override
  public void onClick(View v) {
    // fancy code for button2
  }
});

Posted 7-Jan-13 19:45pm

TorstenH.

Comments

[no name] 8-Jan-13 5:04am

Exactly.
Or, declare and define an OnClickListener instance.
Then pass it as argument in setOnClickListener method of button as my solution.

Cheer.

TorstenH. 8-Jan-13 6:33am

... working with an instance would need identification of the button as both buttons would probably get the same instance from the onClickListener. I do so when using a lot of controls.

[no name] 8-Jan-13 22:20pm

Yes, agree with you.

Justin Jones 8-Jan-13 22:27pm

Thank You Torsten that helped me understand a lot!

cant get 2 on click listeners toghether

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us