how to insert data into database using combo box

Question

4.50/5 (2 votes)

See more:

i just want to insert a data into database column using event handler like a button
i have inserted a text box's text but i dont know about combobox
can anybody help me out
i have my insertion code here

C#

private void button1_Click(object sender, EventArgs e)
        {
            SqlConnection con = new SqlConnection();
            con.ConnectionString = @"Data Source=.\SQLEXPRESS;AttachDbFilename=c:\documents and settings\aquib\my documents\visual studio 2010\Projects\login\login\Database1.mdf;Integrated Security=True;User Instance=True";
            string q="insert into Table1 values('"+textBox1.Text+"','"+textBox2.Text+"','"+textBox3.Text+"')";
            con.Open();
            SqlCommand cmd = new SqlCommand(q, con);
            cmd.ExecuteNonQuery();
            con.Close();
            MessageBox.Show("suceed");
        }

i just want to add one combo box's data here to add in database column
thanks in advance

Posted 25-Aug-12 4:29am

sariqkhan

Updated 24-Dec-19 0:17am

Wendelius

v2

Add a Solution

3 solutions

Solution 1

First of all, don't concatenate the values into your SQL statement directly. This will leave you open to SQL injections and may cause data type conversion problems and so on. Instead use the SqlParameter[^].

About the actual question, you can use the SelectedValue[^] of the combobox to retrieve the value behind the selection, taken that you have defined the ValueMember[^]

Posted 25-Aug-12 4:37am

Wendelius

Comments

__TR__ 25-Aug-12 14:37pm

+5

Wendelius 25-Aug-12 14:42pm

Thanks :)

Solution 3

just swap between

C#

textBox1.Text

and

C#

comboBox1.Items[0].ToString()

where items[0] mean the first value in ComboBox and you can replace it with the second value items[1] ...etc >> good luck

Posted 25-Aug-12 14:55pm

Cheetah.syr

Comments

sariqkhan 25-Aug-12 22:37pm

thanks bro

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sandip.Nascar · Accepted Answer · 2012-08-25T06:11:00

Just like for Textbox you get the txt using textbox1.Text, for combobox, you need to get the selectedindex and then get the text

Try this..

private void button1_Click(object sender, EventArgs e)
        {
            string s = "";
             if(comboBox1.SelectedIndex>=0)
                 s = comboBox1.Items[comboBox1.SelectedIndex].ToString();
            SqlConnection con = new SqlConnection();
            con.ConnectionString = @"Data Source=.\SQLEXPRESS;AttachDbFilename=c:\documents and settings\aquib\my documents\visual studio 2010\Projects\login\login\Database1.mdf;Integrated Security=True;User Instance=True";
            string q="insert into Table1 values('"+textBox1.Text+"','"+textBox2.Text+"','"+s+"')";
            con.Open();
            SqlCommand cmd = new SqlCommand(q, con);
            cmd.ExecuteNonQuery();
            con.Close();
            MessageBox.Show("suceed");
        }

Here I replaced the last parameter with combox selected item.

Hope this helps.
cheers