Rich Edit control save to file

Question

0.00/5 (No votes)

See more:

Hi,

I'm making a text editor for C++ using rich edit control.
I use CFileDialog to save the code in Rich edit to a *.cpp or *.h file.
When I save it and then open it with Visual C++ environment, it shows me Line endings message and it puts an empty line between every line of code.

How can I fix it?

Thanks in advance!

Posted 17-Mar-11 9:52am

George Findulov

Updated 18-Mar-11 12:15pm

Dalek Dave

v2

Add a Solution

Comments

Dalek Dave 18-Mar-11 18:15pm

Edited for Grammar.

2 solutions

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Espen Harlinn · Accepted Answer · 2011-03-17T10:23:00

Solution 1

I'd rather drop the rich edit control and use something like:
Using Scintilla for syntax coloring in MFC[^]

It will save you a lot of time, and add a number of nifty features :)

Best regards
Espen Harlinn

Posted 17-Mar-11 10:23am

Espen Harlinn

Comments

Sergey Alexandrovich Kryukov 18-Mar-11 15:15pm

Scintilla is the must-know thing is one looks to select and editor. Still, it has some problems.
As those problems are not your fault :-) and there are not many good options :-) you got 5.

Wait a minute... is there Scintilla for C++?
--SA

Dalek Dave 18-Mar-11 18:16pm

Good Call.

Ozer Karaagac · Accepted Answer · 2011-03-17T16:04:00

Solution 2

You probably open output file as text mode to save RE content. You can try to open it as binary when saving (and loading, too, of course).

Technical explanation: You get RE content from control with end of line chars intact, that is, 0x0d 0x0a ("\r\n") which are used by MS OSes as being end of line marker. When saving, RTL routine replaces all 0x0a ('\n') chars with 0x0d 0x0a ("\r\n"), then end of lines have become 0x0d 0x0d 0x0a ("\r\r\n"). When opening this file by VC++ editor, it complains for these unexpected EOL markers, then interprets them double end of lines.

EDIT:

You aren't opening the file as binary mode. You should specify CFile::typeBinary flag. If you don't specify it, the default mode is typeText for CStdioFile.

CFileDialog dlg(FALSE, NULL, NULL, OFN_OVERWRITEPROMPT, 
	 L"C++ Source Files (*.cpp)|*.cpp|C++ Header Files (*.h)|*.h|");

CStdioFile file; 
CString buffer; 
CString textfile; 
if(dlg.DoModal() == IDOK) 
{ 
    file.Open(dlg.GetPathName(), // more appropriate instead of GetFileName()
      CFile::typeBinary | CStdioFile::modeCreate | CStdioFile::modeWrite);
    text.GetWindowText(buffer);
    file.Write((void*)(LPCTSTR)buffer, buffer.GetLength() * sizeof(TCHAR));
    file.Close();
}

You aren't doing anything for UNICODE conversion with above code. If you didn't change project settings to MBCS, saved file should still be UNICODE.

Posted 17-Mar-11 16:04pm

Ozer Karaagac

Updated 18-Mar-11 10:23am

v2

Comments

George Findulov 18-Mar-11 6:12am

When i make it binary, my program reads it the way it should, but VC++ can't read it normally.

Ozer Karaagac 18-Mar-11 6:18am

Do you build your project using UNICODE character set?

George Findulov 18-Mar-11 6:23am

yeah, is that a problem?

Ozer Karaagac 18-Mar-11 6:31am

Normally you don't have any problem with it. Try open the file with notepad or any other text editor that supports UNICODE. I think, VC++ editor doesn't support UNICODE text files. If you want to save it as ANSI, you need to convert it before saving (maybe vise versa when loading).

George Findulov 18-Mar-11 6:39am

Notepad opens it normally. Anyway how can i convert unicode to ASCII and the result should stay in letters, not the numbers - like (int)myLetter. Thanks!

Ozer Karaagac 18-Mar-11 7:11am

Not at all. In general, you can use WideCharToMultiByte(...) function in order to convert it to any code page you want. If you are using MFC string, you can convert it like that CStringA strAsc(strFromRichEdit). But be careful about string lengths while writing to a file.

George Findulov 18-Mar-11 7:25am

Well, in all cases it puts empty lines in VC++ and i think it might not be because of the UNICODE.

Ozer Karaagac 18-Mar-11 8:02am

Which cases? I didn't say that empty lines are because of UNICODE. They should be related file open mode. Try this. Save it as UNICODE and in binary mode. But before the text insert two '0xff 0xfe' lead bytes into file beginning. You can do this by using following lines. Beware, file pointer should point to start.

BYTE leadbytes[2] = { 0xff, 0xfe };
file.Write((void *)leadbytes, 2)

You should be able to open the (UNICODE) file in VC++ editor (recent versions, I mean). You will probably post another question regarding two lead bytes when loading it into RE control. :-)

George Findulov 18-Mar-11 9:24am

Visual C++ 6.0 doesn't open the file, because it's unicode, Visual C++ 2008 opens it. I'll have to make ASCII to work on VC++ 6.0.

Ozer Karaagac 18-Mar-11 9:33am

You're right. VC6 doesn't and 2008 does. ASCII is better for your aim.

George Findulov 18-Mar-11 12:42pm

Oh, i made it ASCII, even tested if it works with MessageBox - if(WideCharToMultiByte(...)) MessageBox() - it showed me it was working. These lines continue showing in VC++... :(

Ozer Karaagac 18-Mar-11 12:49pm

How do you open the file? Text or binary. I think, it's time to post file open codes here.

Sergey Alexandrovich Kryukov 18-Mar-11 15:15pm

Good effort.
--SA

Ozer Karaagac 18-Mar-11 15:18pm

Thanks SA. :-)

George Findulov 18-Mar-11 15:31pm

CFileDialog dlg(FALSE, L"C++ Source Files (*.cpp)|*.cpp|C++ Header Files (*.h)|*.h|",NULL,OFN_OVERWRITEPROMPT, L"C++ Source Files (*.cpp)|*.cpp|C++ Header Files (*.h)|*.h|");

CStdioFile file;

CString buffer;
CString textfile;

if(dlg.DoModal() == IDOK)
{
file.Open(dlg.GetFileName(), CStdioFile::modeCreate | CStdioFile::modeWrite);
text.GetWindowText(buffer);

file.WriteString(buffer);

file.Close();
}

Dalek Dave 18-Mar-11 18:16pm

Excellent answer.

Ozer Karaagac 18-Mar-11 18:30pm

Thanks Dalek. :-)

Rich Edit control save to file

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

Rich Edit control save to file

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us