String/Substring find and replace

Question

0.00/5 (No votes)

See more:

I am currently using RegEx and C# to search a string and replace all non-numeric characters...

string strung = Regex.Replace(unstrung, @"[^\w]", "Strings");

What I am wondering is: Is this the fastest way to do this simple action? I have seen it quoted that RegEx can be slow and this seems a pretty simple thing.

Oddly I have a pretty ok knowledge of RegEx, but not one of the expansive .Net string tools etc...

Any help or direction pointing would be greatly appreciated.

Posted 11-Jan-11 6:29am

JasonD_S

Add a Solution

2 solutions

Solution 1

It depend on your alternative. If your task really needs replacements like this, you may want to do equivalent code using string operations yourself. Good chances are it will be slower than Regex. Are you curious enough to try?

Also, if you care about performance, it tells me you need to repeat this operation many times (otherwise, who cares about your performance). In this case you may gain performance if you use Regex constructor, not the static method you show. In this way regular expression can be pre-parsed -- just once.

Posted 11-Jan-11 6:40am

Sergey Alexandrovich Kryukov

Comments

JOAT-MON 11-Jan-11 13:00pm

Insightful point +5

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

#realJSOP · Accepted Answer · 2011-01-11T06:41:00

Solution 2

It's certainly the fastest way to type it.

If you want to try to find faster ways, be a programmer and try different ways to approach the problem.

Performance for such a task would greatly depend on the length of the string involved.

Posted 11-Jan-11 6:41am

#realJSOP

Comments

Sergey Alexandrovich Kryukov 11-Jan-11 12:42pm

That's true - my 5.

JasonD_S 20-Jan-11 3:35am

I had almost forgotten about my asking this question. I have had a play around with this and although I haven't given it the time that proper experimentation requires. I think I've found a solution that works well for me. Which is basically leaving it how it is. The performance hasn't been an issue, although I thought it might and if it ain't broke don't fix it.

I guess my lesson learned here was; sometimes although pontificating and interest just aren't as important to the customer as a ticked requirement. Problem solved, next question. Although I might do some playing at home and write an article.