Loop with break or without

Question

0.00/5 (No votes)

See more:

Hi experts,

There is a debate between some acadimic and non academic programmers especially in the Franco world of whether to break inside a loop.

The bellow code illustrates what I mean.

What do you think best to use and why:
1.

C++

for(int i=0; i<10; i++)
{
  WriteLine("saisir une valeur");
  int valeur = Convert.ToInt32(ReadLine());
  if(valeur == 50){
       WriteLine("Bingo! FOUND!");
       break;
  }
}

2.

C++

bool found = false;
int tentatives = 0;
while(!found && ++tentatives <= 10)
{
   WriteLine("saisir une valeur");
  int valeur = Convert.ToInt32(ReadLine());
  if(valeur == 50){
       WriteLine("Bingo! FOUND!");
       found = true;
  }
}

What I have tried:

I tried the first option, a teacher 10 years ago asked to not do that. The same happened to a friend of mine who is preparing his degree in Electrical engineering.

Posted 27-Oct-17 5:02am

Nabil Droussi

Updated 27-Oct-17 11:36am

CPallini

v2

Add a Solution

Comments

Richard MacCutchan 27-Oct-17 11:30am

It is largely a question of style and personal choice. However, option 2 makes it clear what condition will cause the loop to break.

W∴ Balboos, GHB 27-Oct-17 11:41am

Isn't that also absolutely clear in example 1? I.e., valeur==50 ?

Richard MacCutchan 27-Oct-17 11:53am

It is in that example, but in a longer and more complex loop it may not be. Personally I generally choose option 1.

W∴ Balboos, GHB 27-Oct-17 11:56am

My head works the other way for increasing complexity - it must be some sort of French thing.

Richard MacCutchan 27-Oct-17 12:01pm

I don't have any real preference either way, I just tend to write what seems to make sense at the time. And then spend the next few hours trying to debug it.

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Answer 1 · 2017-10-27T05:40:00

Solution 1

I usually go with the first option (even with return, if appropriate) because of less code to type and see.
However it is just personal taste.

Posted 27-Oct-17 5:40am

CPallini

W∴ Balboos, *GHB* · Answer 2 · 2017-10-27T05:47:00

I would prefer the internal break - it's absolutely clear and makes it easier to follow if one has, for example, multiple handlers for a desired value and a break;

Alternatively, the while() test could grow and grow, becoming more difficult to understand and easier to code with errors.

Also, the first method allows you to stop processing immediately - rather than falling through to more code. Using 'continue;' would get around this - but what would be the point?

The independent internal breaks really speak for themselves and can be added to, modified, and the entire content between the curly-braces otherwise manipulated easily.

Patrice T · Answer 3 · 2017-10-27T09:25:00

Solution 3

My like goes to first option.
But I use both depending on situation, there is no absolute rule.

Posted 27-Oct-17 9:25am

Patrice T

BillWoodruff · Answer 4 · 2017-10-27T11:36:00

I don't think the two examples shown are comparable. When the loop on the second example exits, information persists in a variable 'tentatives that will tell you how many iterations occurred to find the match ... if it found the match. The first example does not persist the iteration count.

The usual discriminating factor in the choice of 'for vs. 'while is whether you know the number of iterations to be carried out. I find it helpful to C# students to suggest thinking of 'for as 'repeat this many times;' with 'while I suggest an analogy of 'keep on doing this as long as whatever.' With 'do-while 'keep doing this until whatever.'

Loop with break or without

4 solutions

Solution 1

Solution 2

Solution 3

Solution 4

Add your solution here

Preview 0